From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id C902C2A5D for ; Wed, 14 Dec 2016 09:17:33 +0100 (CET) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga101.jf.intel.com with ESMTP; 14 Dec 2016 00:17:32 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,346,1477983600"; d="scan'208";a="17883696" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga002.jf.intel.com with ESMTP; 14 Dec 2016 00:17:32 -0800 Received: from fmsmsx153.amr.corp.intel.com (10.18.125.6) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 14 Dec 2016 00:17:32 -0800 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by FMSMSX153.amr.corp.intel.com (10.18.125.6) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 14 Dec 2016 00:17:32 -0800 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.11]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.77]) with mapi id 14.03.0248.002; Wed, 14 Dec 2016 16:17:28 +0800 From: "Liu, Yong" To: "Xu, HuilongX" , "dts@dpdk.org" CC: "Xu, HuilongX" Thread-Topic: [dts] [PATCH V1] fix kni ping/stress Thread-Index: AQHSVElgZ8ETr5Cy502Nl1PHcoNos6EHG7fQ Date: Wed, 14 Dec 2016 08:17:27 +0000 Message-ID: <86228AFD5BCD8E4EBFD2B90117B5E81E62D166EF@SHSMSX103.ccr.corp.intel.com> References: <1481527734-28062-1-git-send-email-huilongx.xu@intel.com> In-Reply-To: <1481527734-28062-1-git-send-email-huilongx.xu@intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMTY2N2QwMWQtZTk1ZS00ZGRmLWFjNDYtNTVjY2UwMDdlM2NhIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IjRzeml6MnBCVWJOdFNiOHlmV1dxc3FGcGNXeVwvM01PQjNsTUg1bkpVZ2dFPSJ9 x-ctpclassification: CTP_IC x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dts] [PATCH V1] fix kni ping/stress X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Dec 2016 08:17:34 -0000 Thanks Huilong. Two comments below. > -----Original Message----- > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of xu,huilong > Sent: Monday, December 12, 2016 3:29 PM > To: dts@dpdk.org > Cc: Xu, HuilongX > Subject: [dts] [PATCH V1] fix kni ping/stress >=20 > Signed-off-by: xu,huilong > --- > tests/TestSuite_kni.py | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) >=20 > diff --git a/tests/TestSuite_kni.py b/tests/TestSuite_kni.py > index 18bd768..432526e 100644 > --- a/tests/TestSuite_kni.py > +++ b/tests/TestSuite_kni.py > @@ -574,12 +574,13 @@ class TestKni(TestCase): >=20 > out =3D self.dut.send_expect("ping6 -w 1 -I %s %s" % > (virtual_interface, > str(ipv6_address)), "# ", 10) > - self.verify("64 bytes from %s: icmp_seq=3D1 ttl=3D64" % > + # some os ping6 out info not same > + self.verify("64 bytes from %s" % > ipv6_address in out, "ping6 not supported") >=20 Not sure what's the difference here, please give some descriptions. > out =3D self.tester.send_expect( > "ping6 -w 1 -I %s %s" % (tx_interface, str(ipv6_address)= ), > "# ", 10) > - self.verify("64 bytes from %s: icmp_seq=3D1 ttl=3D64" % > + self.verify("64 bytes from %s" % > ipv6_address in out, "kni cannot reply ping6 > packet") >=20 > ipv6list =3D list(ipv6_address) > @@ -806,14 +807,13 @@ class TestKni(TestCase): > try: > out =3D self.start_kni(step['lo_mode'], > step['kthread_mode']) > self.verify("Error" not in out, "Error found during kni > start") > + # kni setup out info by kernel debug function. so should > re-build kenel. > + # now not check kni setup out info, only check kni setup > ok and setup no error output > + out =3D self.dut.send_expect('ps -aux', "]# ") > except: > # some permutations have to fail > pass >=20 > - out =3D self.dut.send_expect('dmesg -c | grep "KNI"', "]# ") > - self.verify(len(re.findall(expectedMessage, out, re.DOTALL))= > > 0, > - "Module not properly loaded") > - After removed check with kernel message, we should add check with kernel pr= ocess.=20 Please add it. > def test_perf_loopback(self): > """ > KNI loopback performance > -- > 1.9.3