test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Liu, Yong" <yong.liu@intel.com>
To: "Yao, Lei A" <lei.a.yao@intel.com>, "dts@dpdk.org" <dts@dpdk.org>
Cc: "Yao, Lei A" <lei.a.yao@intel.com>
Subject: Re: [dts] [PATCH V1] framework ssh_pexpect: add timeout to avoid file	uncomplete during scp file from host to VM
Date: Mon, 19 Dec 2016 02:50:22 +0000	[thread overview]
Message-ID: <86228AFD5BCD8E4EBFD2B90117B5E81E62D1A457@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <1481871227-4334-1-git-send-email-lei.a.yao@intel.com>

Hi Lei,
One question for why added the dealy.

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Yao Lei
> Sent: Friday, December 16, 2016 2:54 PM
> To: dts@dpdk.org
> Cc: Yao, Lei A
> Subject: [dts] [PATCH V1] framework ssh_pexpect: add timeout to avoid file
> uncomplete during scp file from host to VM
> 
> From: lei yao <lei.a.yao@intel.com>
> 
> Signed-off-by: lei yao <lei.a.yao@intel.com>
> ---
>  framework/ssh_pexpect.py | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/framework/ssh_pexpect.py b/framework/ssh_pexpect.py
> index d5b6616..09095a1 100644
> --- a/framework/ssh_pexpect.py
> +++ b/framework/ssh_pexpect.py
> @@ -185,6 +185,7 @@ class SSHPexpect(object):
>          if i == 1:
>              time.sleep(0.5)
>              p.sendline(password)
> +            time.sleep(10)
>              p.expect("100%", 60)
Expect function has been already wait for about one minute, look like there's no need to add more time.

>          if i == 4:
>              self.logger.error("SCP TIMEOUT error %d" % i)
> --
> 2.7.4

  reply	other threads:[~2016-12-19  2:50 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-16  6:53 Yao Lei
2016-12-19  2:50 ` Liu, Yong [this message]
2016-12-19  3:15   ` Yao, Lei A
2016-12-19  3:24     ` Liu, Yong
2016-12-19  3:30       ` Yao, Lei A
2016-12-19  3:50         ` Liu, Yong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86228AFD5BCD8E4EBFD2B90117B5E81E62D1A457@SHSMSX103.ccr.corp.intel.com \
    --to=yong.liu@intel.com \
    --cc=dts@dpdk.org \
    --cc=lei.a.yao@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).