From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id F3BC0FC27 for ; Wed, 21 Dec 2016 09:43:36 +0100 (CET) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga101.jf.intel.com with ESMTP; 21 Dec 2016 00:43:34 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,382,1477983600"; d="scan'208";a="1102381785" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga002.fm.intel.com with ESMTP; 21 Dec 2016 00:43:32 -0800 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 21 Dec 2016 00:43:31 -0800 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.20]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.159]) with mapi id 14.03.0248.002; Wed, 21 Dec 2016 16:43:30 +0800 From: "Liu, Yong" To: "Yao, Lei A" , "dts@dpdk.org" CC: "Yao, Lei A" Thread-Topic: [dts] [PATCH V2] test: add vhost/virtio pvp performance test based on qemu Thread-Index: AQHSW2QVU8yZm8Ktv02PZiSOUYSt66ESErqA Date: Wed, 21 Dec 2016 08:43:29 +0000 Message-ID: <86228AFD5BCD8E4EBFD2B90117B5E81E62D2C5A1@SHSMSX103.ccr.corp.intel.com> References: <1482308869-9080-1-git-send-email-lei.a.yao@intel.com> In-Reply-To: <1482308869-9080-1-git-send-email-lei.a.yao@intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMTQ5NTc4NmQtMzM1Zi00N2ExLWE5ZGQtNmU3ZDJiZTBjODVhIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IjF2UUxwUXRHcHFIbGJ0aUxUSmZUZnAwNUt0NWQ1Slhuek9JRkJwR0F1RDg9In0= x-ctpclassification: CTP_IC x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dts] [PATCH V2] test: add vhost/virtio pvp performance test based on qemu X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Dec 2016 08:43:37 -0000 Hi Lei, remaining two comments. > -----Original Message----- > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of lei,yao > Sent: Wednesday, December 21, 2016 4:28 PM > To: dts@dpdk.org > Cc: Yao, Lei A > Subject: [dts] [PATCH V2] test: add vhost/virtio pvp performance test > based on qemu >=20 > From: lei yao >=20 > The test case include 3 part: > 1. virtio 0.95 performance test > virtio0.95 is the default version for qemu. Vector, normal, mergeable pat= h > will be tested on this version > 2. Test vector performance on virtio 1.0. >=20 > Signed-off-by: lei yao > --- > tests/TestSuite_vhost_qemu_pvp_performance.py | 311 > ++++++++++++++++++++++++++ > 1 file changed, 311 insertions(+) > create mode 100644 tests/TestSuite_vhost_qemu_pvp_performance.py >=20 > diff --git a/tests/TestSuite_vhost_qemu_pvp_performance.py > b/tests/TestSuite_vhost_qemu_pvp_performance.py > new file mode 100644 > index 0000000..32f5c56 > --- /dev/null > +++ b/tests/TestSuite_vhost_qemu_pvp_performance.py > + > + self.number_of_ports =3D 1 > + self.header_row =3D ["FrameSize(B)", "Throughput(Mpps)", > "LineRate(%)", "Cycle"] > + self.memory_channel =3D 4 > + # Specify the path of Qemu binary for different Qemu versions, > user can modify this as necessary > + self.qemu_path =3D ["/home/lei/qemu_install/qemu_2.5/bin/qemu- > system-x86_64", > + "/home/lei/qemu_install/qemu_2.6/bin/qemu- > system-x86_64", > + "/home/lei/qemu_install/qemu_2.7/bin/qemu- > system-x86_64"] Please remove hard code path, its' better to use configuration file. > + > + def set_up(self): > + # > + # Run before each test case. > + # > + # Launch vhost sample using default params > + # > + self.dut.send_expect("rm -rf ./vhost.out", "#") > + self.dut.send_expect("rm -rf ./vhost-net*", "#") > + self.dut.send_expect("killall -s INT vhost-switch", "#") > + self.dut.send_expect("killall -s INT qemu-system-x86_64", "#") > + Please not direct killall qemu, maybe someone are using them for other usag= e. You can simple trust framework stop function. If there's still has issue in kill qemu process, let's fix it in framework.