test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Liu, Yong" <yong.liu@intel.com>
To: "Xu, GangX" <gangx.xu@intel.com>, "dts@dpdk.org" <dts@dpdk.org>
Cc: "Xu, GangX" <gangx.xu@intel.com>
Subject: Re: [dts] [PATCH V1] fix timeout on FreeBSD error
Date: Wed, 28 Dec 2016 02:17:08 +0000	[thread overview]
Message-ID: <86228AFD5BCD8E4EBFD2B90117B5E81E62D32BC2@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <1482748810-13580-1-git-send-email-gangx.xu@intel.com>

Gang, one comment for your patch.

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of xu,gang
> Sent: Monday, December 26, 2016 6:40 PM
> To: dts@dpdk.org
> Cc: Xu, GangX
> Subject: [dts] [PATCH V1] fix timeout on FreeBSD error
> 
> 
> Signed-off-by: xu,gang <gangx.xu@intel.com>
> ---
>  tests/TestSuite_unit_tests_eal.py     | 2 +-
>  tests/TestSuite_unit_tests_mbuf.py    | 2 +-
>  tests/TestSuite_unit_tests_mempool.py | 2 +-
>  3 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/tests/TestSuite_unit_tests_eal.py
> b/tests/TestSuite_unit_tests_eal.py
> index 8fea148..efcf34b 100644
> --- a/tests/TestSuite_unit_tests_eal.py
> +++ b/tests/TestSuite_unit_tests_eal.py
> @@ -282,7 +282,7 @@ class TestUnitTestsEal(TestCase):
>          """
> 
>          self.dut.send_expect(self.test_app_cmdline + ' -m 64',
> "R.*T.*E.*>.*>", self.start_test_time)
> -        out = self.dut.send_expect("eal_flags_autotest", "RTE>>",
> self.run_cmd_time)
> +        out = self.dut.send_expect("eal_flags_autotest", "RTE>>", 600)


Please add some description for this change.

>          self.dut.send_expect("quit", "# ")
>          self.verify("Test OK" in out, "Test failed")
> 
> diff --git a/tests/TestSuite_unit_tests_mbuf.py
> b/tests/TestSuite_unit_tests_mbuf.py
> index df73e5d..5ff91ff 100644
> --- a/tests/TestSuite_unit_tests_mbuf.py
> +++ b/tests/TestSuite_unit_tests_mbuf.py
> @@ -69,7 +69,7 @@ class TestUnitTestsMbuf(TestCase):
>          """
> 
>          self.dut.send_expect("./%s/app/test -n 1 -c ffff" % self.target,
> "R.*T.*E.*>.*>", 60)
> -        out = self.dut.send_expect("mbuf_autotest", "RTE>>", 60)
> +        out = self.dut.send_expect("mbuf_autotest", "RTE>>", 180)
>          self.dut.send_expect("quit", "# ")
>          self.verify("Test OK" in out, "Test failed")
> 
> diff --git a/tests/TestSuite_unit_tests_mempool.py
> b/tests/TestSuite_unit_tests_mempool.py
> index 70cf4f3..fcd8dd1 100644
> --- a/tests/TestSuite_unit_tests_mempool.py
> +++ b/tests/TestSuite_unit_tests_mempool.py
> @@ -78,7 +78,7 @@ class TestUnitTestsMempool(TestCase):
>          Run memory pool performance autotest.
>          """
>          self.dut.send_expect("./%s/app/test -n 1 -c fffe" % self.target,
> "R.*T.*E.*>.*>", 60)
> -        out = self.dut.send_expect("mempool_perf_autotest", "RTE>>", 700)
> +        out = self.dut.send_expect("mempool_perf_autotest", "RTE>>", 840)
>          self.dut.send_expect("quit", "# ")
>          self.verify("Test OK" in out, "Test failed")
> 
> --
> 1.9.3

      reply	other threads:[~2016-12-28  2:17 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-26 10:40 xu,gang
2016-12-28  2:17 ` Liu, Yong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86228AFD5BCD8E4EBFD2B90117B5E81E62D32BC2@SHSMSX103.ccr.corp.intel.com \
    --to=yong.liu@intel.com \
    --cc=dts@dpdk.org \
    --cc=gangx.xu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).