From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 44317201 for ; Wed, 28 Dec 2016 03:43:00 +0100 (CET) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga104.jf.intel.com with ESMTP; 27 Dec 2016 18:42:59 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,419,1477983600"; d="scan'208";a="1087309714" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by fmsmga001.fm.intel.com with ESMTP; 27 Dec 2016 18:42:59 -0800 Received: from fmsmsx119.amr.corp.intel.com (10.18.124.207) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.248.2; Tue, 27 Dec 2016 18:42:59 -0800 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by FMSMSX119.amr.corp.intel.com (10.18.124.207) with Microsoft SMTP Server (TLS) id 14.3.248.2; Tue, 27 Dec 2016 18:42:58 -0800 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.20]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.204]) with mapi id 14.03.0248.002; Wed, 28 Dec 2016 10:42:55 +0800 From: "Liu, Yong" To: "Xu, GangX" , "dts@dpdk.org" CC: "Xu, GangX" Thread-Topic: [dts] [PATCH V2 2/2] add test plan vhost_pmd_xstats Thread-Index: AQHSYLAPjnR0l+Dsy06R7SPR12mBmaEco4ig Date: Wed, 28 Dec 2016 02:42:54 +0000 Message-ID: <86228AFD5BCD8E4EBFD2B90117B5E81E62D32C6B@SHSMSX103.ccr.corp.intel.com> References: <1482891276-18365-1-git-send-email-gangx.xu@intel.com> <1482891276-18365-2-git-send-email-gangx.xu@intel.com> In-Reply-To: <1482891276-18365-2-git-send-email-gangx.xu@intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMjI5MTViMzktNGZjNC00ZmVmLTk4NzgtNmMwMTgxNTVlNDJjIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IjJsMFFQeEhSdTlEdTNLU1Z3V0E0VlJiWTVvUVFRQkRxOWlJcGgxMTZcL1lnPSJ9 x-ctpclassification: CTP_IC x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dts] [PATCH V2 2/2] add test plan vhost_pmd_xstats X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Dec 2016 02:43:01 -0000 Gang, some comments below. > -----Original Message----- > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of xu,gang > Sent: Wednesday, December 28, 2016 10:15 AM > To: dts@dpdk.org > Cc: Xu, GangX > Subject: [dts] [PATCH V2 2/2] add test plan vhost_pmd_xstats >=20 > Signed-off-by: xu,gang > --- > test_plans/vhost_pmd_xstats_test_plan.rst | 137 > ++++++++++++++++++++++++++++++ > 1 file changed, 137 insertions(+) > create mode 100644 test_plans/vhost_pmd_xstats_test_plan.rst >=20 > diff --git a/test_plans/vhost_pmd_xstats_test_plan.rst > b/test_plans/vhost_pmd_xstats_test_plan.rst > new file mode 100644 > index 0000000..7cf20bf > --- /dev/null > +++ b/test_plans/vhost_pmd_xstats_test_plan.rst > @@ -0,0 +1,137 @@ > +.. Copyright (c) <2016>, Intel Corporation > + All rights reserved. > + > + Redistribution and use in source and binary forms, with or without > + modification, are permitted provided that the following conditions > + are met: > + > + - Redistributions of source code must retain the above copyright > + notice, this list of conditions and the following disclaimer. > + > + - Redistributions in binary form must reproduce the above copyright > + notice, this list of conditions and the following disclaimer in > + the documentation and/or other materials provided with the > + distribution. > + > + - Neither the name of Intel Corporation nor the names of its > + contributors may be used to endorse or promote products derived > + from this software without specific prior written permission. > + > + THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS > + "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT > + LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS > + FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE > + COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, > + INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES > + (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR > + SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) > + HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, > + STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) > + ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED > + OF THE POSSIBILITY OF SUCH DAMAGE. > + > +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > +Vhost PMD xstats test plan > +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > + > +This test plan will cover the basic vhost pmd xstats case and will be > worked > +as a regression test plan. In the test plan, we will use vhost as a pmd > port > +in testpmd. > + > +Test Case1: Vhsot PMD xstats based on packet size > +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > =3D=3D=3D=3D=3D=3D > + > +flow: > +TG-->NIC-->>Vhost TX-->Virtio RX-->Virtio TX-->Vhsot RX-->NIC-->TG > + > +1. bind one physical port to igb_uio, then launch the testpmd > + > +2. Launch VM1 with using hugepage, 2048M memory, 2 cores, 1 cockets , > +1 virtio-net-pci > + It's better to add qemu command back, it's good reference for user usage. > +3. On VM1, run testpmd > + > +4. On host, testpmd, set ports to the mac forward mode > + > + testpmd>set fwd mac > + testpmd>start tx_first > + > +5. On VM, testpmd, set port to the mac forward mode > + > + testpmd>set fwd mac > + testpmd>start > + > +6. On host run "show port xstats all" at least twice to check the packet= s > number > + > +7. Let TG generate different size of packets, send 10000 packets for eac= h > packet > +sizes(64,128,255, 512, 1024, 1523), check the statistic number is correc= t > + > +Test Case2: Vhost PMD xstats based on packet types > +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > =3D=3D=3D=3D=3D=3D > + > +Similar as Test Case1, all steps are similar except step6,7: > + > +6. On host run "show port xstats all" at least twice to check the packet= s > type: > + > +7. Let TG generate different type of packets, broadcast, multicast, ucas= t, > check > +the statistic number is correct > + > +Test Case3: clear Vhost PMD xstats > +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > =3D=3D=3D=3D=3D=3D As I recommend before, you can move this case to case1 and case2. There's n= o need to recreate environment and just only verify clear function. And I remember there's one case covered mergeable and no-mergeable path, wh= at's happened? > + > +flow: > +TG-->NIC-->>Vhost TX-->Virtio RX-->Virtio TX-->Vhsot RX-->NIC-->TG > + > +1.bind one physical port to igb_uio, > +then launch the testpmd > + > +2. Launch VM1, with using hugepage, 2048M memory, > +2 cores, 1 cockets ,1 virtio-net-pci > + > +3. On VM1, run testpmd > + > +4. On host, testpmd, set ports to the mac forward mode > + > + testpmd>set fwd mac > + testpmd>start tx_first > + > +5. On VM, testpmd, set port to the mac forward mode > + > + testpmd>set fwd mac > + testpmd>start > + > +6. Let TG generate different size of packets, send 10000 packets for eac= h > +packet sizes(64,128,255, 512, 1024, 1523,3000), check the statistic > number > +is correct > + > +7. On host run "show port xstats all" at least twice to check the packet= s > number > + > +8. On host run "clear port xstats all" , then all the statistic date > should be 0 > + > + > +Test Case4: Long lasting test for Vhsot PMD xstats > +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D Please simplify the case name like "stability case with multiple queues" > +1. no need bind any physical port to igb_uio > + > +2. Launch VM1, set queues=3D2, vectors=3D2xqueues+2, mq=3Don, with using > hugepage, > +2048M memory, 2 cores, 1 cockets ,1 virtio-net-pci > + > +3. On VM1, run testpmd > + > +4. On host, testpmd, set ports to the mac forward mode > + > + testpmd>set fwd io retry > + testpmd>start tx_first 8 > + > +5. On VM, testpmd, set port to the mac forward mode > + > + testpmd>start > + > +6. Send packets for 30 minutes, check the Xstatsa still can work > correctly > + testpmd>show port xstats all > + > + > + > + > + > + > -- > 1.9.3