Re: [dts] [PATCH V1] tests: add test for vhost/virtio loopback performance

["Liu, Yong" <yong.liu@intel.com>]

Thanks, Lei.

> -----Original Message-----
> From: Yao, Lei A
> Sent: Wednesday, December 28, 2016 1:56 PM
> To: Liu, Yong; dts@dpdk.org
> Subject: RE: [dts] [PATCH V1] tests: add test for vhost/virtio loopback
> performance
> 
> Some update. Thanks.
> 
> > -----Original Message-----
> > From: Liu, Yong
> > Sent: Wednesday, December 28, 2016 1:28 PM
> > To: Yao, Lei A <lei.a.yao@intel.com>; dts@dpdk.org
> > Cc: Yao, Lei A <lei.a.yao@intel.com>
> > Subject: RE: [dts] [PATCH V1] tests: add test for vhost/virtio loopback
> > performance
> >
> > Lei, some comments below.
> >
> > > -----Original Message-----
> > > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of lei,yao
> > > Sent: Thursday, December 22, 2016 11:29 AM
> > > To: dts@dpdk.org
> > > Cc: Yao, Lei A
> > > Subject: [dts] [PATCH V1] tests: add test for vhost/virtio loopback
> > > performance
> > >
> > > From: lei yao <lei.a.yao@intel.com>
> > >
> > > +        self.dut.send_expect("killall -s INT vhost-switch", "#")
> > > +        self.dut.send_expect("killall -s INT testpmd", "#")
> >
> > Dpdk application will be automated killed by framework. There's no need
> to
> > kill dpdk application in set_up_all function.
> >
> So both vhost-switch and testpmd will be cleaned by framework, right?
> 

Yes. 

> > > +        self.header_row = ["FrameSize(B)", "Mode", "Throughput(Mpps)",
> > > "Virtio Version"]
> > > +        self.frame_sizes = [64, 128, 260, 520, 1024, 1500]
> > > +        self.test_cycles = {'Mpps': {}, 'pct': {}}
> > > +
> > > +    def set_up(self):
> > > +        """
> > > +        Run before each test case.
> > > +        """
> > > +        self.dut.restore_interfaces()
> > > +        pass
> >
> > This is critical function which will bind all ports to default driver.
> > You can use simple code like "port.bind_driver()" to bind port to
> default
> > driver and "port.bind_driver(driver=self.drivername)" to igb_uio driver.
> > Just in this suite, I can't see any requirement to do this.
> >
> Because this test cases don't need any NIC binned to pmd driver. So I use
> this function
> to clean it.
By now if you do that, all later suites will be failed. I remember that Lijuan is developing one patch for restore all ports before running suite. 
Based on that patch, you can do this function in set_up_all function.
But now I recommend that change drivername to blank and then run this suite.