From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 7A408376C for ; Wed, 28 Dec 2016 08:21:25 +0100 (CET) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga102.fm.intel.com with ESMTP; 27 Dec 2016 23:21:24 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,421,1477983600"; d="scan'208";a="1076928224" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by orsmga001.jf.intel.com with ESMTP; 27 Dec 2016 23:21:24 -0800 Received: from fmsmsx158.amr.corp.intel.com (10.18.116.75) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.248.2; Tue, 27 Dec 2016 23:21:24 -0800 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by fmsmsx158.amr.corp.intel.com (10.18.116.75) with Microsoft SMTP Server (TLS) id 14.3.248.2; Tue, 27 Dec 2016 23:21:24 -0800 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.20]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.177]) with mapi id 14.03.0248.002; Wed, 28 Dec 2016 15:21:22 +0800 From: "Liu, Yong" To: "Yao, Lei A" , "dts@dpdk.org" Thread-Topic: [dts] [PATCH V1] tests: add test for vhost/virtio loopback performance Thread-Index: AQHSXAN06djtt1JaVkmdw1CdC53jEKEc2eDA//+GLgCAAIY8kA== Date: Wed, 28 Dec 2016 07:21:21 +0000 Message-ID: <86228AFD5BCD8E4EBFD2B90117B5E81E62D34366@SHSMSX103.ccr.corp.intel.com> References: <1482377343-9957-1-git-send-email-lei.a.yao@intel.com> <86228AFD5BCD8E4EBFD2B90117B5E81E62D341AA@SHSMSX103.ccr.corp.intel.com> <2DBBFF226F7CF64BAFCA79B681719D953A149C77@shsmsx102.ccr.corp.intel.com> In-Reply-To: <2DBBFF226F7CF64BAFCA79B681719D953A149C77@shsmsx102.ccr.corp.intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMmI3NmYxOGItY2VhNy00ZWY1LWE1OTQtZTQ3YWI0YWEyYmNhIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6Ijgzb1BPemR4SCs1Rm1XcTVDNmh5alA3cE1tNVN6cDhmYnBTTDVCN1JoMWs9In0= x-ctpclassification: CTP_IC x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dts] [PATCH V1] tests: add test for vhost/virtio loopback performance X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Dec 2016 07:21:26 -0000 Thanks, Lei. > -----Original Message----- > From: Yao, Lei A > Sent: Wednesday, December 28, 2016 1:56 PM > To: Liu, Yong; dts@dpdk.org > Subject: RE: [dts] [PATCH V1] tests: add test for vhost/virtio loopback > performance >=20 > Some update. Thanks. >=20 > > -----Original Message----- > > From: Liu, Yong > > Sent: Wednesday, December 28, 2016 1:28 PM > > To: Yao, Lei A ; dts@dpdk.org > > Cc: Yao, Lei A > > Subject: RE: [dts] [PATCH V1] tests: add test for vhost/virtio loopback > > performance > > > > Lei, some comments below. > > > > > -----Original Message----- > > > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of lei,yao > > > Sent: Thursday, December 22, 2016 11:29 AM > > > To: dts@dpdk.org > > > Cc: Yao, Lei A > > > Subject: [dts] [PATCH V1] tests: add test for vhost/virtio loopback > > > performance > > > > > > From: lei yao > > > > > > + self.dut.send_expect("killall -s INT vhost-switch", "#") > > > + self.dut.send_expect("killall -s INT testpmd", "#") > > > > Dpdk application will be automated killed by framework. There's no need > to > > kill dpdk application in set_up_all function. > > > So both vhost-switch and testpmd will be cleaned by framework, right? >=20 Yes.=20 > > > + self.header_row =3D ["FrameSize(B)", "Mode", "Throughput(Mpp= s)", > > > "Virtio Version"] > > > + self.frame_sizes =3D [64, 128, 260, 520, 1024, 1500] > > > + self.test_cycles =3D {'Mpps': {}, 'pct': {}} > > > + > > > + def set_up(self): > > > + """ > > > + Run before each test case. > > > + """ > > > + self.dut.restore_interfaces() > > > + pass > > > > This is critical function which will bind all ports to default driver. > > You can use simple code like "port.bind_driver()" to bind port to > default > > driver and "port.bind_driver(driver=3Dself.drivername)" to igb_uio driv= er. > > Just in this suite, I can't see any requirement to do this. > > > Because this test cases don't need any NIC binned to pmd driver. So I use > this function > to clean it. By now if you do that, all later suites will be failed. I remember that Lij= uan is developing one patch for restore all ports before running suite.=20 Based on that patch, you can do this function in set_up_all function. But now I recommend that change drivername to blank and then run this suite= .