Re: [dts] [PATCH V2] tests: add test for vhost/virtio loopback performance

["Liu, Yong" <yong.liu@intel.com>]

Lei, few comments below.

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of lei,yao
> Sent: Thursday, December 29, 2016 9:26 AM
> To: dts@dpdk.org
> Cc: Yao, Lei A
> Subject: [dts] [PATCH V2] tests: add test for vhost/virtio loopback
> performance
> 
> From: lei yao <lei.a.yao@intel.com>
> 
> This test won't use qemu, but will use two testpmd thread to launch vhost-
> user and
> virtio-user to simulate the qemu user case.
> 
> Signed-off-by: lei yao <lei.a.yao@intel.com>
> ---
>  ...Suite_vhost_loopback_performance_virtio_user.py | 260
> +++++++++++++++++++++
>  1 file changed, 260 insertions(+)
>  create mode 100644
> tests/TestSuite_vhost_loopback_performance_virtio_user.py
> 
> diff --git a/tests/TestSuite_vhost_loopback_performance_virtio_user.py
> b/tests/TestSuite_vhost_loopback_performance_virtio_user.py
> new file mode 100644
> index 0000000..377aa66
> --- /dev/null
> +++ b/tests/TestSuite_vhost_loopback_performance_virtio_user.py
> @@ -0,0 +1,260 @@
> +#
> +# BSD LICENSE
> +#
> +# Copyright(c) 2010-2016 Intel Corporation. All rights reserved.
> +# All rights reserved.
> +#
> +# Redistribution and use in source and binary forms, with or without
> +# modification, are permitted provided that the following conditions
> +# are met:
> +#
> +#   * Redistributions of source code must retain the above copyright
> +#     notice, this list of conditions and the following disclaimer.
> +#   * Redistributions in binary form must reproduce the above copyright
> +#     notice, this list of conditions and the following disclaimer in
> +#     the documentation and/or other materials provided with the
> +#     distribution.
> +#   * Neither the name of Intel Corporation nor the names of its
> +#     contributors may be used to endorse or promote products derived
> +#     from this software without specific prior written permission.
> +#
> +# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
> +# "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
> +# LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
> +# A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
> +# OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
> +# SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
> +# LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
> +# DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
> +# THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
> +# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
> +# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
> +
> +
> +"""
> +DPDK Test suite.
> +Test Vhost loopback performance for Mergeable, normal , vector Path
> +"""
> +import string
> +import utils
> +import time
> +import re
> +from test_case import TestCase
> +
> +
> +class TestVhostLoopback(TestCase):
> +
> +    def set_up_all(self):
> +        """
> +        Run at the start of each test suite.
> +        """
> +        # Clean the execution environment
> +        self.dut.send_expect("rm -rf ./vhost.out", "#")
> +        self.dut.send_expect("rm -rf ./vhost-net*", "#")
> +        self.header_row = ["FrameSize(B)", "Mode", "Throughput(Mpps)",
> "Virtio Version"]
> +        self.frame_sizes = [64, 128, 260, 520, 1024, 1500]
> +        self.test_cycles = {'Mpps': {}, 'pct': {}}
> +        # Don't use any NIC in this test case
> +        port_list = self.dut.get_ports()
> +        for i in port_list:
> +            port = self.dut.ports_info[i]['port']
> +            port.bind_driver()
> +
> +        self.dut.send_expect("sed -i -e 's/#define
> TXONLY_DEF_PACKET_LEN.*$/#define TXONLY_DEF_PACKET_LEN 64/' ./app/test-
> pmd/testpmd.h", "#", 30)
> +

Packet length maybe changed later, we can't assume the value is always 64.
Please capture the value in set_up_all function and restore it back in tear_down_all.

> +
> +    def tear_down(self):
> +        """
> +        Run after each test case.
> +        """
> +        time.sleep(2)
> +
> +    def tear_down_all(self):
> +        """
> +        Run after each test suite.
> +        """
> +        # Recompile the dpdk because we change the source code during the
> test

Need to bind port back to self.drivername.
You can restore TXONLY_DEF_PACKET_LEN value here, it's only need restore the value at the end of this suite execution.

> +        self.dut.build_install_dpdk(self.dut.target)
> --
> 2.7.4