test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Liu, Yong" <yong.liu@intel.com>
To: "dts@dpdk.org" <dts@dpdk.org>
Subject: Re: [dts] [PATCH 1/2] framework settings: add support for global error status
Date: Wed, 4 Jan 2017 03:31:20 +0000	[thread overview]
Message-ID: <86228AFD5BCD8E4EBFD2B90117B5E81E62D38E7F@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <1482998987-21640-1-git-send-email-yong.liu@intel.com>

Applied into master branch.

-----Original Message-----
From: Liu, Yong 
Sent: Thursday, December 29, 2016 4:10 PM
To: dts@dpdk.org
Cc: Liu, Yong <yong.liu@intel.com>
Subject: [dts][PATCH 1/2] framework settings: add support for global error status

Record error information in system environment variable. And changed system exit value according to what's kind of error met in execution process.

Signed-off-by: Marvin Liu <yong.liu@intel.com>

diff --git a/framework/settings.py b/framework/settings.py index e232364..df2a491 100644
--- a/framework/settings.py
+++ b/framework/settings.py
@@ -32,6 +32,7 @@
 Folders for framework running enviornment.
 """
 import os
+import sys
 import re
 import socket
 
@@ -194,7 +195,19 @@ HOST_NIC_SETTING = "DTS_HOST_NIC"
 DEBUG_SETTING = "DTS_DEBUG_ENABLE"
 DEBUG_CASE_SETTING = "DTS_DEBUGCASE_ENABLE"
 DPDK_RXMODE_SETTING = "DTS_DPDK_RXMODE"
+DTS_ERROR_ENV = "DTS_RUNNING_ERROR"
 
+"""
+DTS global error table
+"""
+DTS_ERR_TBL = {
+    "GENERIC_ERR": 1,
+    "DPDK_BUILD_ERR" : 2,
+    "DUT_SETUP_ERR" : 3,
+    "TESTER_SETUP_ERR" : 4,
+    "SUITE_SETUP_ERR": 5,
+    "SUITE_EXECUTE_ERR": 6,
+}
 
 def get_nic_name(type):
     """
@@ -271,6 +284,27 @@ def load_global_setting(key):
         return ''
 
 
+def report_error(error):
+    """
+    Report error when error occurred
+    """
+    if error in DTS_ERR_TBL.keys():
+        os.environ[DTS_ERROR_ENV] = error
+    else:
+        os.environ[DTS_ERROR_ENV] = "GENERIC_ERR"
+
+
+def exit_error():
+    """
+    Set system exit value when error occurred
+    """
+    if DTS_ERROR_ENV in os.environ.keys():
+        ret_val = DTS_ERR_TBL[os.environ[DTS_ERROR_ENV]]
+        sys.exit(ret_val)
+    else:
+        sys.exit(0)
+
+
 def accepted_nic(pci_id):
     """
     Return True if the pci_id is a known NIC card in the settings file and if
--
1.9.3

      parent reply	other threads:[~2017-01-04  3:31 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-29  8:09 Marvin Liu
2016-12-29  8:09 ` [dts] [PATCH 2/2] framework dts: report error in execution process Marvin Liu
2017-01-04  3:31 ` Liu, Yong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86228AFD5BCD8E4EBFD2B90117B5E81E62D38E7F@SHSMSX103.ccr.corp.intel.com \
    --to=yong.liu@intel.com \
    --cc=dts@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).