From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 6CD43D592 for ; Thu, 12 Jan 2017 02:20:12 +0100 (CET) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga101.jf.intel.com with ESMTP; 11 Jan 2017 17:20:11 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,347,1477983600"; d="scan'208";a="1092976589" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga001.fm.intel.com with ESMTP; 11 Jan 2017 17:20:11 -0800 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 11 Jan 2017 17:20:10 -0800 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.20]) by shsmsx102.ccr.corp.intel.com ([169.254.2.88]) with mapi id 14.03.0248.002; Thu, 12 Jan 2017 09:20:06 +0800 From: "Liu, Yong" To: "Xu, HuilongX" , "dts@dpdk.org" CC: "Xu, HuilongX" Thread-Topic: [dts] [patch V1 2/2] update shutdown_api and jumboframes check tx-packets code Thread-Index: AQHSaw9F+ZzlFzLsZkuz48ShTCYZVqE0C2gA Date: Thu, 12 Jan 2017 01:20:06 +0000 Message-ID: <86228AFD5BCD8E4EBFD2B90117B5E81E62D4137C@SHSMSX103.ccr.corp.intel.com> References: <1484031290-35715-1-git-send-email-huilongx.xu@intel.com> <1484031290-35715-2-git-send-email-huilongx.xu@intel.com> In-Reply-To: <1484031290-35715-2-git-send-email-huilongx.xu@intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dts] [patch V1 2/2] update shutdown_api and jumboframes check tx-packets code X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Jan 2017 01:20:13 -0000 Huilong,=20 There're lots of function may affected if we can't avoid LLDP packets sendi= ng out from dpdk drive Fortville port. We need a list about which case will be affected by this issue. And we nee= d to abstract one function to check packet size. Function input will be expected received or transmitted size and return val= ue is just meet the expectation or not. Regards, Marvin > -----Original Message----- > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of xu,huilong > Sent: Tuesday, January 10, 2017 2:55 PM > To: dts@dpdk.org > Cc: Xu, HuilongX > Subject: [dts] [patch V1 2/2] update shutdown_api and jumboframes check t= x- > packets code >=20 > fotville nic will send lldp packet when port setup by dpdk testpmd. > so we need update check tx-packets code. > used (tx-packets - forward packet size) % lldp packet size replace tx-pa= ckets =3D=3D > forward packets size >=20 > Signed-off-by: "xu,huilong" > --- > tests/TestSuite_jumboframes.py | 5 ++++- tests/TestSuite_shutdown_api= .py | > 16 ++++++++++------ > 2 files changed, 14 insertions(+), 7 deletions(-) >=20 > diff --git a/tests/TestSuite_jumboframes.py b/tests/TestSuite_jumboframes= .py > index 58f2e17..bebee59 100644 > --- a/tests/TestSuite_jumboframes.py > +++ b/tests/TestSuite_jumboframes.py > @@ -39,6 +39,7 @@ import re > from time import sleep > from test_case import TestCase > from pmd_output import PmdOutput > +from settings import PROTOCOL_PACKET_SIZE >=20 > ETHER_HEADER_LEN =3D 18 > IP_HEADER_LEN =3D 20 > @@ -93,7 +94,9 @@ class TestJumboframes(TestCase): > rx_err -=3D rx_err_ori >=20 > if received: > - self.verify((tx_pkts =3D=3D rx_pkts) and ((tx_bytes + 4) =3D= =3D pktsize) and > ((rx_bytes + 4) =3D=3D pktsize), > + self.verify((tx_pkts - rx_pkts % PROTOCOL_PACKET_SIZE['lldp'= ] =3D=3D 0) > + and ( (tx_bytes + 4 - pktsize ) % PROTOCOL_PACK= ET_SIZE['lldp'] > =3D=3D 0) > + and ((rx_bytes + 4) =3D=3D pktsize), > "packet pass assert error") > else: > #self.verify(p0tx_pkts =3D=3D p1rx_pkts and (p1rx_err =3D=3D= 1 or p1rx_pkts =3D=3D 0), > diff --git a/tests/TestSuite_shutdown_api.py b/tests/TestSuite_shutdown_a= pi.py > index 3dbacf2..5e67bf5 100644 > --- a/tests/TestSuite_shutdown_api.py > +++ b/tests/TestSuite_shutdown_api.py > @@ -42,7 +42,7 @@ import re > import os > from test_case import TestCase > from pmd_output import PmdOutput > -from settings import HEADER_SIZE > +from settings import HEADER_SIZE, PROTOCOL_PACKET_SIZE > from exception import VerifyFailure >=20 > # > @@ -149,14 +149,18 @@ class TestShutdownApi(TestCase): > if vlan is True: > # vlan strip default is on > tx_bytes_exp -=3D 4 > - > + > + # fortville nic enable send lldp packet function when port setup > + # now the tx-packets size is lldp_size(110) * n + forward packe = size > + # so use (tx-packets - forward packet size) % lldp_size, if it > + is 0, it means forward packet size right > + > if received: > - self.verify(p0tx_pkts =3D=3D p1rx_pkts, "Wrong TX pkts p0_tx= =3D%d, > p1_rx=3D%d" % (p0tx_pkts, p1rx_pkts)) > + self.verify((p0tx_pkts - p1rx_pkts) % > + PROTOCOL_PACKET_SIZE['lldp'] =3D=3D 0, "Wrong TX pkts p0_tx=3D%d, p1_rx= =3D%d" > + % (p0tx_pkts, p1rx_pkts)) > self.verify(p1rx_bytes =3D=3D rx_bytes_exp, "Wrong Rx bytes = p1_rx=3D%d, > expect=3D%d" % (p1rx_bytes, rx_bytes_exp)) > - self.verify(p0tx_bytes =3D=3D tx_bytes_exp, "Wrong Tx bytes = p0_tx=3D%d, > expect=3D%d" % (p0tx_bytes, tx_bytes_exp)) > + self.verify((p0tx_bytes - tx_bytes_exp) % > + PROTOCOL_PACKET_SIZE['lldp'] =3D=3D 0, "Wrong Tx bytes p0_tx=3D%d, > + expect=3D%d" % (p0tx_bytes, tx_bytes_exp)) > else: > - self.verify(p0tx_pkts =3D=3D 0, "Packet not dropped p0tx_pkt= s=3D%d" % > p0tx_pkts) > - self.verify(p0tx_bytes =3D=3D 0, "Packet not dropped p0tx_by= tes=3D%d" % > p0tx_bytes) > + self.verify(p0tx_pkts % PROTOCOL_PACKET_SIZE['lldp'] =3D=3D = 0, "Packet not > dropped p0tx_pkts=3D%d" % p0tx_pkts) > + self.verify(p0tx_bytes % PROTOCOL_PACKET_SIZE['lldp'] =3D=3D= 0, > + "Packet not dropped p0tx_bytes=3D%d" % p0tx_bytes) >=20 > def check_ports(self, status=3DTrue): > """ > -- > 1.9.3