From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 07D2E3777 for ; Wed, 18 Jan 2017 09:03:21 +0100 (CET) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga103.jf.intel.com with ESMTP; 18 Jan 2017 00:03:20 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,248,1477983600"; d="scan'208";a="810245742" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by FMSMGA003.fm.intel.com with ESMTP; 18 Jan 2017 00:03:20 -0800 Received: from fmsmsx157.amr.corp.intel.com (10.18.116.73) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 18 Jan 2017 00:03:20 -0800 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by FMSMSX157.amr.corp.intel.com (10.18.116.73) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 18 Jan 2017 00:03:20 -0800 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.20]) by SHSMSX104.ccr.corp.intel.com ([10.239.4.70]) with mapi id 14.03.0248.002; Wed, 18 Jan 2017 16:03:18 +0800 From: "Liu, Yong" To: "Tu, LijuanX A" , "dts@dpdk.org" Thread-Topic: [dts] [PATCH V1]framework/dut: fix parameter error on some OS Thread-Index: AQHScJCGmY46n+aZDEyxHpINtz6VAaE9h0hQgAAAv4CAAFiwcA== Date: Wed, 18 Jan 2017 08:03:17 +0000 Message-ID: <86228AFD5BCD8E4EBFD2B90117B5E81E62D4C4CA@SHSMSX103.ccr.corp.intel.com> References: <1484636922-47775-1-git-send-email-lijuanx.a.tu@intel.com> <86228AFD5BCD8E4EBFD2B90117B5E81E62D4ADF1@SHSMSX103.ccr.corp.intel.com> <38D041F150D4184C8114E499040E62343D1E2D2D@shsmsx102.ccr.corp.intel.com> In-Reply-To: <38D041F150D4184C8114E499040E62343D1E2D2D@shsmsx102.ccr.corp.intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dts] [PATCH V1]framework/dut: fix parameter error on some OS X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Jan 2017 08:03:22 -0000 Hi Lijuan, Function destroy_all_sriov_vfs should be workable on different OSs.=20 If FreeBSD not support virtualization cases, we can just add one blank func= tion for FreeBSD OS to work around this issue. Thanks, Marvin > -----Original Message----- > From: Tu, LijuanX A > Sent: Wednesday, January 18, 2017 10:49 AM > To: Liu, Yong ; dts@dpdk.org > Subject: RE: [dts] [PATCH V1]framework/dut: fix parameter error on some O= S >=20 > Hi yong, > We have function "get_sriov_vfs_pci_linux" > but not have function "get_sriov_vfs_pci_freebsd" > in framework. > So I think we don't support on FreeBSD now. >=20 > > -----Original Message----- > > From: Liu, Yong > > Sent: Wednesday, January 18, 2017 10:41 AM > To: Tu, LijuanX A; > dts@dpdk.org > Cc: Tu, LijuanX A > Subject: RE: [dts] [PATCH > V1]framework/dut: fix parameter error on some OS > > Hi Lijuan, > > Virtualization case may not support on FreeBSD, but I think > > destroy_all_sriov_vfs this function should has FreeBSD and Linux version. > > > > > -----Original Message----- > > > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Lijuan Tu > > = Sent: > Tuesday, January 17, 2017 3:09 PM > > To: dts@dpdk.org > > Cc: Tu, Liju= anX A > > > Subject: [dts] [PATCH V1]framework/dut: fix > parameter error on some OS > > > > Virtual test is only support linux n= ow. > > > Framework not support freebsd > > > > > > Signed-off-by: Lijuan Tu > > --- > > > framework/dut.py | 3 +++ > > 1 file changed, 3 insertions(+) > > > > = diff --git > a/framework/dut.py b/framework/dut.py index 9cbdaf7..0cc45dd > > > 100644 > > --- a/framework/dut.py > > +++ b/framework/dut.py > > @@ - > 820,6 +820,9 @@ class Dut(Crb): > > > > > > def destroy_all_sriov_vfs(self): > > > > > > + # virtual test is only support linux now. > > > + if self.get_os_type() !=3D "linux": > > > + > > > if self.ports_info =3D=3D None: > > > return > > > for port_id in range(len(self.ports_info)): > > > -- > > > 1.9.3