* [dts] [PATCH V1]framework/dut: fix parameter error on some OS @ 2017-01-17 7:08 Lijuan Tu 2017-01-18 2:41 ` Liu, Yong 0 siblings, 1 reply; 5+ messages in thread From: Lijuan Tu @ 2017-01-17 7:08 UTC (permalink / raw) To: dts; +Cc: Lijuan Tu Virtual test is only support linux now. Framework not support freebsd Signed-off-by: Lijuan Tu <lijuanx.a.tu@intel.com> --- framework/dut.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/framework/dut.py b/framework/dut.py index 9cbdaf7..0cc45dd 100644 --- a/framework/dut.py +++ b/framework/dut.py @@ -820,6 +820,9 @@ class Dut(Crb): def destroy_all_sriov_vfs(self): + # virtual test is only support linux now. + if self.get_os_type() != "linux": + if self.ports_info == None: return for port_id in range(len(self.ports_info)): -- 1.9.3 ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dts] [PATCH V1]framework/dut: fix parameter error on some OS 2017-01-17 7:08 [dts] [PATCH V1]framework/dut: fix parameter error on some OS Lijuan Tu @ 2017-01-18 2:41 ` Liu, Yong 2017-01-18 2:49 ` Tu, LijuanX A 0 siblings, 1 reply; 5+ messages in thread From: Liu, Yong @ 2017-01-18 2:41 UTC (permalink / raw) To: Tu, LijuanX A, dts; +Cc: Tu, LijuanX A Hi Lijuan, Virtualization case may not support on FreeBSD, but I think destroy_all_sriov_vfs this function should has FreeBSD and Linux version. > -----Original Message----- > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Lijuan Tu > Sent: Tuesday, January 17, 2017 3:09 PM > To: dts@dpdk.org > Cc: Tu, LijuanX A <lijuanx.a.tu@intel.com> > Subject: [dts] [PATCH V1]framework/dut: fix parameter error on some OS > > Virtual test is only support linux now. > Framework not support freebsd > > Signed-off-by: Lijuan Tu <lijuanx.a.tu@intel.com> > --- > framework/dut.py | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/framework/dut.py b/framework/dut.py index 9cbdaf7..0cc45dd > 100644 > --- a/framework/dut.py > +++ b/framework/dut.py > @@ -820,6 +820,9 @@ class Dut(Crb): > > def destroy_all_sriov_vfs(self): > > + # virtual test is only support linux now. > + if self.get_os_type() != "linux": > + > if self.ports_info == None: > return > for port_id in range(len(self.ports_info)): > -- > 1.9.3 ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dts] [PATCH V1]framework/dut: fix parameter error on some OS 2017-01-18 2:41 ` Liu, Yong @ 2017-01-18 2:49 ` Tu, LijuanX A 2017-01-18 8:03 ` Liu, Yong 0 siblings, 1 reply; 5+ messages in thread From: Tu, LijuanX A @ 2017-01-18 2:49 UTC (permalink / raw) To: Liu, Yong, dts Hi yong, We have function "get_sriov_vfs_pci_linux" but not have function "get_sriov_vfs_pci_freebsd" in framework. So I think we don't support on FreeBSD now. > -----Original Message----- > From: Liu, Yong > Sent: Wednesday, January 18, 2017 10:41 AM > To: Tu, LijuanX A; dts@dpdk.org > Cc: Tu, LijuanX A > Subject: RE: [dts] [PATCH V1]framework/dut: fix parameter error on some OS > > Hi Lijuan, > Virtualization case may not support on FreeBSD, but I think > destroy_all_sriov_vfs this function should has FreeBSD and Linux version. > > > -----Original Message----- > > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Lijuan Tu > > Sent: Tuesday, January 17, 2017 3:09 PM > > To: dts@dpdk.org > > Cc: Tu, LijuanX A <lijuanx.a.tu@intel.com> > > Subject: [dts] [PATCH V1]framework/dut: fix parameter error on some OS > > > > Virtual test is only support linux now. > > Framework not support freebsd > > > > Signed-off-by: Lijuan Tu <lijuanx.a.tu@intel.com> > > --- > > framework/dut.py | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/framework/dut.py b/framework/dut.py index 9cbdaf7..0cc45dd > > 100644 > > --- a/framework/dut.py > > +++ b/framework/dut.py > > @@ -820,6 +820,9 @@ class Dut(Crb): > > > > def destroy_all_sriov_vfs(self): > > > > + # virtual test is only support linux now. > > + if self.get_os_type() != "linux": > > + > > if self.ports_info == None: > > return > > for port_id in range(len(self.ports_info)): > > -- > > 1.9.3 ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dts] [PATCH V1]framework/dut: fix parameter error on some OS 2017-01-18 2:49 ` Tu, LijuanX A @ 2017-01-18 8:03 ` Liu, Yong 2017-01-18 8:38 ` Tu, LijuanX A 0 siblings, 1 reply; 5+ messages in thread From: Liu, Yong @ 2017-01-18 8:03 UTC (permalink / raw) To: Tu, LijuanX A, dts Hi Lijuan, Function destroy_all_sriov_vfs should be workable on different OSs. If FreeBSD not support virtualization cases, we can just add one blank function for FreeBSD OS to work around this issue. Thanks, Marvin > -----Original Message----- > From: Tu, LijuanX A > Sent: Wednesday, January 18, 2017 10:49 AM > To: Liu, Yong <yong.liu@intel.com>; dts@dpdk.org > Subject: RE: [dts] [PATCH V1]framework/dut: fix parameter error on some OS > > Hi yong, > We have function "get_sriov_vfs_pci_linux" > but not have function "get_sriov_vfs_pci_freebsd" > in framework. > So I think we don't support on FreeBSD now. > > > -----Original Message----- > > From: Liu, Yong > > Sent: Wednesday, January 18, 2017 10:41 AM > To: Tu, LijuanX A; > dts@dpdk.org > Cc: Tu, LijuanX A > Subject: RE: [dts] [PATCH > V1]framework/dut: fix parameter error on some OS > > Hi Lijuan, > > Virtualization case may not support on FreeBSD, but I think > > destroy_all_sriov_vfs this function should has FreeBSD and Linux version. > > > > > -----Original Message----- > > > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Lijuan Tu > > Sent: > Tuesday, January 17, 2017 3:09 PM > > To: dts@dpdk.org > > Cc: Tu, LijuanX A > <lijuanx.a.tu@intel.com> > > Subject: [dts] [PATCH V1]framework/dut: fix > parameter error on some OS > > > > Virtual test is only support linux now. > > > Framework not support freebsd > > > > > > Signed-off-by: Lijuan Tu <lijuanx.a.tu@intel.com> > > --- > > > framework/dut.py | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git > a/framework/dut.py b/framework/dut.py index 9cbdaf7..0cc45dd > > > 100644 > > --- a/framework/dut.py > > +++ b/framework/dut.py > > @@ - > 820,6 +820,9 @@ class Dut(Crb): > > > > > > def destroy_all_sriov_vfs(self): > > > > > > + # virtual test is only support linux now. > > > + if self.get_os_type() != "linux": > > > + > > > if self.ports_info == None: > > > return > > > for port_id in range(len(self.ports_info)): > > > -- > > > 1.9.3 ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dts] [PATCH V1]framework/dut: fix parameter error on some OS 2017-01-18 8:03 ` Liu, Yong @ 2017-01-18 8:38 ` Tu, LijuanX A 0 siblings, 0 replies; 5+ messages in thread From: Tu, LijuanX A @ 2017-01-18 8:38 UTC (permalink / raw) To: Liu, Yong, dts Hi yong, I will change it ,and sent patch later. > -----Original Message----- > From: Liu, Yong > Sent: Wednesday, January 18, 2017 4:03 PM > To: Tu, LijuanX A; dts@dpdk.org > Subject: RE: [dts] [PATCH V1]framework/dut: fix parameter error on some OS > > Hi Lijuan, > Function destroy_all_sriov_vfs should be workable on different OSs. > If FreeBSD not support virtualization cases, we can just add one blank > function for FreeBSD OS to work around this issue. > > Thanks, > Marvin > > -----Original Message----- > > From: Tu, LijuanX A > > Sent: Wednesday, January 18, 2017 10:49 AM > > To: Liu, Yong <yong.liu@intel.com>; dts@dpdk.org > > Subject: RE: [dts] [PATCH V1]framework/dut: fix parameter error on > > some OS > > > > Hi yong, > > We have function "get_sriov_vfs_pci_linux" > > but not have function "get_sriov_vfs_pci_freebsd" > > in framework. > > So I think we don't support on FreeBSD now. > > > > > -----Original Message----- > > > From: Liu, Yong > > > Sent: Wednesday, January 18, 2017 10:41 AM > To: Tu, LijuanX A; > > dts@dpdk.org > Cc: Tu, LijuanX A > Subject: RE: [dts] [PATCH > > V1]framework/dut: fix parameter error on some OS > > Hi Lijuan, > > > Virtualization case may not support on FreeBSD, but I think > > > destroy_all_sriov_vfs this function should has FreeBSD and Linux version. > > > > > > > -----Original Message----- > > > > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Lijuan Tu > > > Sent: > > Tuesday, January 17, 2017 3:09 PM > > To: dts@dpdk.org > > Cc: Tu, > > LijuanX A <lijuanx.a.tu@intel.com> > > Subject: [dts] [PATCH > > V1]framework/dut: fix parameter error on some OS > > > > Virtual test is > only support linux now. > > > > Framework not support freebsd > > > > > > > > Signed-off-by: Lijuan Tu <lijuanx.a.tu@intel.com> > > --- > > > > framework/dut.py | 3 +++ > > 1 file changed, 3 insertions(+) > > > > > > diff --git a/framework/dut.py b/framework/dut.py index > > 9cbdaf7..0cc45dd > > > > 100644 > > --- a/framework/dut.py > > +++ b/framework/dut.py > > @@ > > - > > 820,6 +820,9 @@ class Dut(Crb): > > > > > > > > def destroy_all_sriov_vfs(self): > > > > > > > > + # virtual test is only support linux now. > > > > + if self.get_os_type() != "linux": > > > > + > > > > if self.ports_info == None: > > > > return > > > > for port_id in range(len(self.ports_info)): > > > > -- > > > > 1.9.3 ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-01-18 8:39 UTC | newest] Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2017-01-17 7:08 [dts] [PATCH V1]framework/dut: fix parameter error on some OS Lijuan Tu 2017-01-18 2:41 ` Liu, Yong 2017-01-18 2:49 ` Tu, LijuanX A 2017-01-18 8:03 ` Liu, Yong 2017-01-18 8:38 ` Tu, LijuanX A
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).