test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts] [DTS][PATCH V1] tests fortville_rss_granularity_config: fix format error
@ 2017-01-19  5:35 Yong Liu
  2017-01-19  5:42 ` Liu, Yong
  0 siblings, 1 reply; 2+ messages in thread
From: Yong Liu @ 2017-01-19  5:35 UTC (permalink / raw)
  To: dts; +Cc: wei,fangfang

From: "wei,fangfang" <fangfangx.wei@intel.com>

fix some unexpected indent in fortville_rss_granularity_config suite.

Signed-off-by: wei,fangfang <fangfangx.wei@intel.com>
---
 tests/TestSuite_fortville_rss_granularity_config.py | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/tests/TestSuite_fortville_rss_granularity_config.py b/tests/TestSuite_fortville_rss_granularity_config.py
index dd06f06..3e99055 100644
--- a/tests/TestSuite_fortville_rss_granularity_config.py
+++ b/tests/TestSuite_fortville_rss_granularity_config.py
@@ -239,7 +239,7 @@ class TestFortvilleRssGranularityConfig(TestCase):
 
         self.dut.send_expect("quit", "# ", 30)
 	self.result_table_print()
-    result_rows = self.result_table_getrows()
+        result_rows = self.result_table_getrows()
 	self.verify(len(result_rows) > 1, "There is no data in the table, testcase failed!")
 
 	
@@ -589,16 +589,16 @@ class TestFortvilleRssGranularityConfig(TestCase):
             #set hash input set by testpmd on dut, enable src-ipv4 & dst-ipv4
             self.dut.send_expect("set_hash_input_set 0 ipv4-other src-ipv4 add", "testpmd> ")
             self.dut.send_expect("set_hash_input_set 0 ipv4-other dst-ipv4 add", "testpmd> ")
-	        self.send_packet(itf, "ipv4-other")
+	    self.send_packet(itf, "ipv4-other")
 
             #set hash input set by testpmd on dut, enable src-ipv4, dst-ipv4, gre-key-len 3
             self.dut.send_expect("global_config 0 gre-key-len 3", "testpmd> ")
-	        self.dut.send_expect("set_hash_input_set 0 ipv4-other gre-key add", "testpmd> ")
+	    self.dut.send_expect("set_hash_input_set 0 ipv4-other gre-key add", "testpmd> ")
             self.send_packet(itf, "ipv4-other")
 
 	        #set hash input set by testpmd on dut, enable src-ipv4, dst-ipv4, gre-key-len 4
             self.dut.send_expect("global_config 0 gre-key-len 4", "testpmd> ")
-	        self.send_packet(itf, "ipv4-other")
+	    self.send_packet(itf, "ipv4-other")
 
         self.dut.send_expect("quit", "# ", 30)
         self.result_table_print()
-- 
2.7.4

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dts] [DTS][PATCH V1] tests fortville_rss_granularity_config: fix format error
  2017-01-19  5:35 [dts] [DTS][PATCH V1] tests fortville_rss_granularity_config: fix format error Yong Liu
@ 2017-01-19  5:42 ` Liu, Yong
  0 siblings, 0 replies; 2+ messages in thread
From: Liu, Yong @ 2017-01-19  5:42 UTC (permalink / raw)
  To: Wei, FangfangX, dts

Hi Fangfang,
Just by review the patch, there're still some codes not aligned in the suite. Please double check it. 
Please check your git configuration first, do not use others' email :)

Thanks,
Marvin

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Yong Liu
> Sent: Thursday, January 19, 2017 1:36 PM
> To: dts@dpdk.org
> Cc: Wei, FangfangX <fangfangx.wei@intel.com>
> Subject: [dts] [DTS][PATCH V1] tests fortville_rss_granularity_config: fix format
> error
> 
> From: "wei,fangfang" <fangfangx.wei@intel.com>
> 
> fix some unexpected indent in fortville_rss_granularity_config suite.
> 
> Signed-off-by: wei,fangfang <fangfangx.wei@intel.com>
> ---
>  tests/TestSuite_fortville_rss_granularity_config.py | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/tests/TestSuite_fortville_rss_granularity_config.py
> b/tests/TestSuite_fortville_rss_granularity_config.py
> index dd06f06..3e99055 100644
> --- a/tests/TestSuite_fortville_rss_granularity_config.py
> +++ b/tests/TestSuite_fortville_rss_granularity_config.py
> @@ -239,7 +239,7 @@ class TestFortvilleRssGranularityConfig(TestCase):
> 
>          self.dut.send_expect("quit", "# ", 30)
>  	self.result_table_print()
> -    result_rows = self.result_table_getrows()
> +        result_rows = self.result_table_getrows()
>  	self.verify(len(result_rows) > 1, "There is no data in the table, testcase
> failed!")
> 
> 
> @@ -589,16 +589,16 @@ class TestFortvilleRssGranularityConfig(TestCase):
>              #set hash input set by testpmd on dut, enable src-ipv4 & dst-ipv4
>              self.dut.send_expect("set_hash_input_set 0 ipv4-other src-ipv4 add",
> "testpmd> ")
>              self.dut.send_expect("set_hash_input_set 0 ipv4-other dst-ipv4 add",
> "testpmd> ")
> -	        self.send_packet(itf, "ipv4-other")
> +	    self.send_packet(itf, "ipv4-other")
> 
>              #set hash input set by testpmd on dut, enable src-ipv4, dst-ipv4, gre-key-
> len 3
>              self.dut.send_expect("global_config 0 gre-key-len 3", "testpmd> ")
> -	        self.dut.send_expect("set_hash_input_set 0 ipv4-other gre-key add",
> "testpmd> ")
> +	    self.dut.send_expect("set_hash_input_set 0 ipv4-other gre-key add",
> "testpmd> ")
>              self.send_packet(itf, "ipv4-other")
> 
>  	        #set hash input set by testpmd on dut, enable src-ipv4, dst-ipv4,
> gre-key-len 4
>              self.dut.send_expect("global_config 0 gre-key-len 4", "testpmd> ")
> -	        self.send_packet(itf, "ipv4-other")
> +	    self.send_packet(itf, "ipv4-other")
> 
>          self.dut.send_expect("quit", "# ", 30)
>          self.result_table_print()
> --
> 2.7.4

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-01-19  5:42 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-01-19  5:35 [dts] [DTS][PATCH V1] tests fortville_rss_granularity_config: fix format error Yong Liu
2017-01-19  5:42 ` Liu, Yong

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).