test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts] [PATCH V1 1/2] add dyanmic config bonding rss hash test plan
@ 2017-03-01  8:36 xu,huilong
  2017-03-01 13:24 ` Liu, Yong
  0 siblings, 1 reply; 3+ messages in thread
From: xu,huilong @ 2017-03-01  8:36 UTC (permalink / raw)
  To: dts; +Cc: xu,huilong

Signed-off-by: xu,huilong <huilongx.xu@intel.com>
---
 test_plans/pmdrss_hash_test_plan.rst | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/test_plans/pmdrss_hash_test_plan.rst b/test_plans/pmdrss_hash_test_plan.rst
index 4922d3b..15e6b3b 100644
--- a/test_plans/pmdrss_hash_test_plan.rst
+++ b/test_plans/pmdrss_hash_test_plan.rst
@@ -150,3 +150,27 @@ Test Case:  test_simple_symmetric
 The same as the above two test cases. Just pay attention to set the hash function to "simple xor"
 
 
+Test Case:  test_dyanmic_rss_bond_config
+=================================
+This case test bond slaves will auto sync rss hash config, so it only support fortville nic.
+
+#1. set up testpmd woth fortville NICs::
+./testpmd -c f -n 4 -- -i --portmask 0x3 --txqflags=0
+
+#2 creat bond device with mode 3::
+ create bonded device 3 0
+#3 add slave to bond device::
+ add bonding slave 0 2
+ add bonding slave 1 2
+#4 get default hash algorithm on slave::
+ get_hash_global_config 0
+ get_hash_global_config 1
+#5 set hash algorithm on slave 0::
+ set_hash_global_config 0 simple_xor ipv4-other  enable
+#6 get hash algorithm on slave 0 and 1::
+ get_hash_global_config 0
+ get_hash_global_config 1
+#7 check slave 0 and 1 use same hash algorithm
+
+
+
-- 
1.9.3

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dts] [PATCH V1 1/2] add dyanmic config bonding rss hash test plan
  2017-03-01  8:36 [dts] [PATCH V1 1/2] add dyanmic config bonding rss hash test plan xu,huilong
@ 2017-03-01 13:24 ` Liu, Yong
  2017-03-02  8:28   ` Xu, HuilongX
  0 siblings, 1 reply; 3+ messages in thread
From: Liu, Yong @ 2017-03-01 13:24 UTC (permalink / raw)
  To: Xu, HuilongX, dts; +Cc: Xu, HuilongX

Huilong,
Some comments below.

Thanks,
Marvin

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of xu,huilong
> Sent: Wednesday, March 01, 2017 4:37 PM
> To: dts@dpdk.org
> Cc: Xu, HuilongX <huilongx.xu@intel.com>
> Subject: [dts] [PATCH V1 1/2] add dyanmic config bonding rss hash test
> plan
> 
> Signed-off-by: xu,huilong <huilongx.xu@intel.com>
> ---
>  test_plans/pmdrss_hash_test_plan.rst | 24 ++++++++++++++++++++++++
>  1 file changed, 24 insertions(+)
> 
> diff --git a/test_plans/pmdrss_hash_test_plan.rst
> b/test_plans/pmdrss_hash_test_plan.rst
> index 4922d3b..15e6b3b 100644
> --- a/test_plans/pmdrss_hash_test_plan.rst
> +++ b/test_plans/pmdrss_hash_test_plan.rst
> @@ -150,3 +150,27 @@ Test Case:  test_simple_symmetric
>  The same as the above two test cases. Just pay attention to set the hash
> function to "simple xor"
> 
> 
> +Test Case:  test_dyanmic_rss_bond_config
> +=================================

Typo: should be dynamic_rss_bond_config

> +This case test bond slaves will auto sync rss hash config, so it only
> support fortville nic.
> +
> +#1. set up testpmd woth fortville NICs::
> +./testpmd -c f -n 4 -- -i --portmask 0x3 --txqflags=0
> +
> +#2 creat bond device with mode 3::
> + create bonded device 3 0
> +#3 add slave to bond device::
> + add bonding slave 0 2
> + add bonding slave 1 2
> +#4 get default hash algorithm on slave::
> + get_hash_global_config 0
> + get_hash_global_config 1
> +#5 set hash algorithm on slave 0::
> + set_hash_global_config 0 simple_xor ipv4-other  enable

Fortville not only support simple_xor, suggest test all kinds of hash algorithm supported by Fortville.
> +#6 get hash algorithm on slave 0 and 1::
> + get_hash_global_config 0
> + get_hash_global_config 1
> +#7 check slave 0 and 1 use same hash algorithm
> +
> +
> +
> --
> 1.9.3

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dts] [PATCH V1 1/2] add dyanmic config bonding rss hash test plan
  2017-03-01 13:24 ` Liu, Yong
@ 2017-03-02  8:28   ` Xu, HuilongX
  0 siblings, 0 replies; 3+ messages in thread
From: Xu, HuilongX @ 2017-03-02  8:28 UTC (permalink / raw)
  To: Liu, Yong, dts

Hi yong,
Some comments below

> -----Original Message-----
> From: Liu, Yong
> Sent: Wednesday, March 01, 2017 9:24 PM
> To: Xu, HuilongX; dts@dpdk.org
> Cc: Xu, HuilongX
> Subject: RE: [dts] [PATCH V1 1/2] add dyanmic config bonding rss hash test
> plan
> 
> Huilong,
> Some comments below.
> 
> Thanks,
> Marvin
> 
> > -----Original Message-----
> > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of xu,huilong
> > Sent: Wednesday, March 01, 2017 4:37 PM
> > To: dts@dpdk.org
> > Cc: Xu, HuilongX <huilongx.xu@intel.com>
> > Subject: [dts] [PATCH V1 1/2] add dyanmic config bonding rss hash test
> > plan
> >
> > Signed-off-by: xu,huilong <huilongx.xu@intel.com>
> > ---
> >  test_plans/pmdrss_hash_test_plan.rst | 24
> ++++++++++++++++++++++++
> >  1 file changed, 24 insertions(+)
> >
> > diff --git a/test_plans/pmdrss_hash_test_plan.rst
> > b/test_plans/pmdrss_hash_test_plan.rst
> > index 4922d3b..15e6b3b 100644
> > --- a/test_plans/pmdrss_hash_test_plan.rst
> > +++ b/test_plans/pmdrss_hash_test_plan.rst
> > @@ -150,3 +150,27 @@ Test Case:  test_simple_symmetric  The same as
> > the above two test cases. Just pay attention to set the hash function
> > to "simple xor"
> >
> >
> > +Test Case:  test_dyanmic_rss_bond_config
> > +=================================
> 
> Typo: should be dynamic_rss_bond_configt
Thanks  a lot, I will send V2 patch and fix it
> 
> > +This case test bond slaves will auto sync rss hash config, so it only
> > support fortville nic.
> > +
> > +#1. set up testpmd woth fortville NICs::
> > +./testpmd -c f -n 4 -- -i --portmask 0x3 --txqflags=0
> > +
> > +#2 creat bond device with mode 3::
> > + create bonded device 3 0
> > +#3 add slave to bond device::
> > + add bonding slave 0 2
> > + add bonding slave 1 2
> > +#4 get default hash algorithm on slave::
> > + get_hash_global_config 0
> > + get_hash_global_config 1
> > +#5 set hash algorithm on slave 0::
> > + set_hash_global_config 0 simple_xor ipv4-other  enable
> 
> Fortville not only support simple_xor, suggest test all kinds of hash algorithm
> supported by Fortville.
This case only test slave 1 will auto sync slave 0 hash function, and slave 0 and slave1 default hash function is  Toeplitz. So only change slave 0 used simple_xor, then slave 1 will
auto use simple_xor hash function replace Toeplitz hash function.
all hash algorithm and config will test in pmd_rsshash test suite. And 
It include simple_xor/simple_xor symmetry/ Toeplitz/ Toeplitz symmetry and different hash key. So not need test in this case.
> > +#6 get hash algorithm on slave 0 and 1::
> > + get_hash_global_config 0
> > + get_hash_global_config 1
> > +#7 check slave 0 and 1 use same hash algorithm
> > +
> > +
> > +
> > --
> > 1.9.3

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2017-03-02  8:28 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-03-01  8:36 [dts] [PATCH V1 1/2] add dyanmic config bonding rss hash test plan xu,huilong
2017-03-01 13:24 ` Liu, Yong
2017-03-02  8:28   ` Xu, HuilongX

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).