test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Liu, Yong" <yong.liu@intel.com>
To: "Xu, HuilongX" <huilongx.xu@intel.com>, "dts@dpdk.org" <dts@dpdk.org>
Cc: "Xu, HuilongX" <huilongx.xu@intel.com>
Subject: Re: [dts] [PATCH V1] fix ring dump case failed
Date: Thu, 2 Mar 2017 08:55:11 +0000	[thread overview]
Message-ID: <86228AFD5BCD8E4EBFD2B90117B5E81E62D6E514@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <1488441904-2699-1-git-send-email-huilongx.xu@intel.com>

Huilong,

Just check source code and Fortville driver will create Ethernet_type/Fdir/Tunnel ring besides default ring. Ixgbe will create Fdir/L2_tn ring.
Dump sequence maybe different between different drivers. Suggest change your comment, this is not cause by igb_uio.

Thanks,
Marvin

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of xu,huilong
> Sent: Thursday, March 02, 2017 4:05 PM
> To: dts@dpdk.org
> Cc: Xu, HuilongX <huilongx.xu@intel.com>
> Subject: [dts] [PATCH V1] fix ring dump case failed
> 
> when bind igb_uio on NIC. Newest testpmd will creat many ring.
> 
> Signed-off-by: xu,huilong <huilongx.xu@intel.com>
> ---
>  tests/TestSuite_unit_tests_dump.py | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/TestSuite_unit_tests_dump.py
> b/tests/TestSuite_unit_tests_dump.py
> index a39fcd1..c3515da 100644
> --- a/tests/TestSuite_unit_tests_dump.py
> +++ b/tests/TestSuite_unit_tests_dump.py
> @@ -92,8 +92,9 @@ class TestUnitTestsDump(TestCase):
>          m = re.compile(r"%s" % match_regex, re.S)
>          result = m.findall(out)
> 
> -
> -        self.verify(result[0][0] == 'MP_mbuf_pool_socket_0', "dump ring
> name failed")
> +        #when we bind some nic with igb_uio. testpmd init will create
> 3N+1 ring, and the last ring name is MP_mbuf_pool_socket_0
> +        #other ring name about nic bus ID and ring type, so will not
> check. we only check ring_dump function work ok
> +        self.verify( 'MP_mbuf_pool_socket_0' in result[0][-1], "dump ring
> name failed")
> 
>      def test_mempool_dump(self):
>          """
> --
> 1.9.3

  reply	other threads:[~2017-03-02  8:55 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-02  8:05 xu,huilong
2017-03-02  8:55 ` Liu, Yong [this message]
2017-03-02  9:04   ` Xu, HuilongX

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86228AFD5BCD8E4EBFD2B90117B5E81E62D6E514@SHSMSX103.ccr.corp.intel.com \
    --to=yong.liu@intel.com \
    --cc=dts@dpdk.org \
    --cc=huilongx.xu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).