* [dts] [PATCH V1] fix ring dump case failed
@ 2017-03-02 8:05 xu,huilong
2017-03-02 8:55 ` Liu, Yong
0 siblings, 1 reply; 3+ messages in thread
From: xu,huilong @ 2017-03-02 8:05 UTC (permalink / raw)
To: dts; +Cc: xu,huilong
when bind igb_uio on NIC. Newest testpmd will creat many ring.
Signed-off-by: xu,huilong <huilongx.xu@intel.com>
---
tests/TestSuite_unit_tests_dump.py | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/tests/TestSuite_unit_tests_dump.py b/tests/TestSuite_unit_tests_dump.py
index a39fcd1..c3515da 100644
--- a/tests/TestSuite_unit_tests_dump.py
+++ b/tests/TestSuite_unit_tests_dump.py
@@ -92,8 +92,9 @@ class TestUnitTestsDump(TestCase):
m = re.compile(r"%s" % match_regex, re.S)
result = m.findall(out)
-
- self.verify(result[0][0] == 'MP_mbuf_pool_socket_0', "dump ring name failed")
+ #when we bind some nic with igb_uio. testpmd init will create 3N+1 ring, and the last ring name is MP_mbuf_pool_socket_0
+ #other ring name about nic bus ID and ring type, so will not check. we only check ring_dump function work ok
+ self.verify( 'MP_mbuf_pool_socket_0' in result[0][-1], "dump ring name failed")
def test_mempool_dump(self):
"""
--
1.9.3
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dts] [PATCH V1] fix ring dump case failed
2017-03-02 8:05 [dts] [PATCH V1] fix ring dump case failed xu,huilong
@ 2017-03-02 8:55 ` Liu, Yong
2017-03-02 9:04 ` Xu, HuilongX
0 siblings, 1 reply; 3+ messages in thread
From: Liu, Yong @ 2017-03-02 8:55 UTC (permalink / raw)
To: Xu, HuilongX, dts; +Cc: Xu, HuilongX
Huilong,
Just check source code and Fortville driver will create Ethernet_type/Fdir/Tunnel ring besides default ring. Ixgbe will create Fdir/L2_tn ring.
Dump sequence maybe different between different drivers. Suggest change your comment, this is not cause by igb_uio.
Thanks,
Marvin
> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of xu,huilong
> Sent: Thursday, March 02, 2017 4:05 PM
> To: dts@dpdk.org
> Cc: Xu, HuilongX <huilongx.xu@intel.com>
> Subject: [dts] [PATCH V1] fix ring dump case failed
>
> when bind igb_uio on NIC. Newest testpmd will creat many ring.
>
> Signed-off-by: xu,huilong <huilongx.xu@intel.com>
> ---
> tests/TestSuite_unit_tests_dump.py | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/tests/TestSuite_unit_tests_dump.py
> b/tests/TestSuite_unit_tests_dump.py
> index a39fcd1..c3515da 100644
> --- a/tests/TestSuite_unit_tests_dump.py
> +++ b/tests/TestSuite_unit_tests_dump.py
> @@ -92,8 +92,9 @@ class TestUnitTestsDump(TestCase):
> m = re.compile(r"%s" % match_regex, re.S)
> result = m.findall(out)
>
> -
> - self.verify(result[0][0] == 'MP_mbuf_pool_socket_0', "dump ring
> name failed")
> + #when we bind some nic with igb_uio. testpmd init will create
> 3N+1 ring, and the last ring name is MP_mbuf_pool_socket_0
> + #other ring name about nic bus ID and ring type, so will not
> check. we only check ring_dump function work ok
> + self.verify( 'MP_mbuf_pool_socket_0' in result[0][-1], "dump ring
> name failed")
>
> def test_mempool_dump(self):
> """
> --
> 1.9.3
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dts] [PATCH V1] fix ring dump case failed
2017-03-02 8:55 ` Liu, Yong
@ 2017-03-02 9:04 ` Xu, HuilongX
0 siblings, 0 replies; 3+ messages in thread
From: Xu, HuilongX @ 2017-03-02 9:04 UTC (permalink / raw)
To: Liu, Yong, dts
Ok, I will chang my comment in test case and send V2 patch
> -----Original Message-----
> From: Liu, Yong
> Sent: Thursday, March 02, 2017 4:55 PM
> To: Xu, HuilongX; dts@dpdk.org
> Cc: Xu, HuilongX
> Subject: RE: [dts] [PATCH V1] fix ring dump case failed
>
> Huilong,
>
> Just check source code and Fortville driver will create
> Ethernet_type/Fdir/Tunnel ring besides default ring. Ixgbe will create
> Fdir/L2_tn ring.
> Dump sequence maybe different between different drivers. Suggest change
> your comment, this is not cause by igb_uio.
>
> Thanks,
> Marvin
>
> > -----Original Message-----
> > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of xu,huilong
> > Sent: Thursday, March 02, 2017 4:05 PM
> > To: dts@dpdk.org
> > Cc: Xu, HuilongX <huilongx.xu@intel.com>
> > Subject: [dts] [PATCH V1] fix ring dump case failed
> >
> > when bind igb_uio on NIC. Newest testpmd will creat many ring.
> >
> > Signed-off-by: xu,huilong <huilongx.xu@intel.com>
> > ---
> > tests/TestSuite_unit_tests_dump.py | 5 +++--
> > 1 file changed, 3 insertions(+), 2 deletions(-)
> >
> > diff --git a/tests/TestSuite_unit_tests_dump.py
> > b/tests/TestSuite_unit_tests_dump.py
> > index a39fcd1..c3515da 100644
> > --- a/tests/TestSuite_unit_tests_dump.py
> > +++ b/tests/TestSuite_unit_tests_dump.py
> > @@ -92,8 +92,9 @@ class TestUnitTestsDump(TestCase):
> > m = re.compile(r"%s" % match_regex, re.S)
> > result = m.findall(out)
> >
> > -
> > - self.verify(result[0][0] == 'MP_mbuf_pool_socket_0', "dump ring
> > name failed")
> > + #when we bind some nic with igb_uio. testpmd init will create
> > 3N+1 ring, and the last ring name is MP_mbuf_pool_socket_0
> > + #other ring name about nic bus ID and ring type, so will not
> > check. we only check ring_dump function work ok
> > + self.verify( 'MP_mbuf_pool_socket_0' in result[0][-1], "dump ring
> > name failed")
> >
> > def test_mempool_dump(self):
> > """
> > --
> > 1.9.3
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-03-02 9:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-03-02 8:05 [dts] [PATCH V1] fix ring dump case failed xu,huilong
2017-03-02 8:55 ` Liu, Yong
2017-03-02 9:04 ` Xu, HuilongX
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).