test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Liu, Yong" <yong.liu@intel.com>
To: "Chen, Zhaoyan" <zhaoyan.chen@intel.com>, "dts@dpdk.org" <dts@dpdk.org>
Subject: Re: [dts] [PATCH v3] Add Cryptodev Unit Tests Cases
Date: Wed, 8 Mar 2017 07:43:22 +0000	[thread overview]
Message-ID: <86228AFD5BCD8E4EBFD2B90117B5E81E62D758E6@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <9DEEADBC57E43F4DA73B571777FECECA3C82D2F6@shsmsx102.ccr.corp.intel.com>

Zhaoyan,
I guess the reason why Kill this applcation is for next around. Am I right?
We used to handle this kind of action in tear_down function.
For exception handler, there's no need to dump exception for the only one reason is timeout.
In general, let framework handle those kind exceptions and keep suite clean. 

Thanks,
Marvin

> -----Original Message-----
> From: Chen, Zhaoyan
> Sent: Wednesday, March 08, 2017 3:32 PM
> To: Liu, Yong <yong.liu@intel.com>; dts@dpdk.org
> Subject: RE: [dts] [PATCH v3] Add Cryptodev Unit Tests Cases
> 
> I do not recover the application, just error handling.
> Since QAT HW unstable sometime.
> 
> Since just function test, (not stable test),
> So, for each test case will launch a separated test application.
> 
> But, there is another idea that run different unit tests by
> a defined scenario. Actually, there is 1 DPDK-AE bug find by this mode.
> 
> Anyway, for the unit test, I just want to de-couple the completed factors.
> So each test app launching  for each unit test suite.
> 
> Next step is that design some combined tests by requirements.
> 
> Thanks.
> 
> Regards,
> Zhaoyan Chen
> 
> > -----Original Message-----
> > From: Liu, Yong
> > Sent: Wednesday, March 8, 2017 3:05 PM
> > To: Chen, Zhaoyan <zhaoyan.chen@intel.com>; dts@dpdk.org
> > Subject: Re: [dts] [PATCH v3] Add Cryptodev Unit Tests Cases
> >
> > Zhaoyan,
> > Why try to recover test application when there's no response? Is that
> > application not stable after run crypto unit test?
> > If there's one need to do that, please do it in tear_down function.
> >
> > Thanks,
> > Marvin
> >
> > On 03/08/2017 01:01 PM, Chen, Zhaoyan wrote:
> > > +        try:
> > > +            out = self.dut.send_expect(testsuite, "RTE>>", timeout)
> > > +            self.dut.send_expect("quit", "# ", 30)
> > > +        except Exception, ex:
> > > +            print ex
> > > +            print "run cryptodev_unit_tests process coredump"
> > > +            self.dut.alt_session.send_expect("killall test", "# ", 30)
> > > +            dmesg = self.dut.alt_session.send_expect("dmesg", "# ",
> 30)
> > > +            print dmesg
> > > +        print out

      reply	other threads:[~2017-03-08  7:43 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-08  5:01 Chen, Zhaoyan
2017-03-08  7:04 ` Liu, Yong
2017-03-08  7:32   ` Chen, Zhaoyan
2017-03-08  7:43     ` Liu, Yong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86228AFD5BCD8E4EBFD2B90117B5E81E62D758E6@SHSMSX103.ccr.corp.intel.com \
    --to=yong.liu@intel.com \
    --cc=dts@dpdk.org \
    --cc=zhaoyan.chen@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).