Re: [dts] [PATCH v2] add crc-strip param to start i40evf driver testpmd

["Liu, Yong" <yong.liu@intel.com>]

Xueqin,
Please check the comments.

Thanks,
Marvin

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Xueqin Lin
> Sent: Wednesday, March 08, 2017 11:15 AM
> To: dts@dpdk.org
> Cc: Lin, Xueqin <xueqin.lin@intel.com>
> Subject: [dts] [PATCH v2] add crc-strip param to start i40evf driver
> testpmd
> 
> ---
>  framework/pmd_output.py | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
> 
> diff --git a/framework/pmd_output.py b/framework/pmd_output.py
> index 13dcaef..1761595 100644
> --- a/framework/pmd_output.py
> +++ b/framework/pmd_output.py
> @@ -31,6 +31,7 @@
> 
>  import os
>  import re
> +import settings
>  from settings import TIMEOUT,PROTOCOL_PACKET_SIZE
>  from utils import create_mask
> 
> @@ -43,6 +44,7 @@ class PmdOutput():
> 
>      def __init__(self, dut):
>          self.dut = dut
> +        self.NAME = '%s' % dut
>          self.dut.testpmd = self
>          self.rx_pkts_prefix = "RX-packets:"
>          self.rx_missed_prefix = "RX-missed:"
> @@ -100,6 +102,18 @@ class PmdOutput():
>          return self.command
> 
>      def start_testpmd(self, cores, param='', eal_param='', socket=0):
> +        """
> +        add --crc-strip param to start i40evf driver testpmd in VM, which
> +        fix bug introduced in commit "1bbcc5d2" as workaround.
> +        """
> +        if "virt_dut" in self.NAME:

Not only virt_dut need this parameter, if run i40evf on host still need this. 

> +            for (pci_bus, pci_id) in self.dut.pci_devices_info:
> +                if pci_id != "8086:100e":
> +                    driver = settings.get_nic_driver(pci_id)
> +            if driver == "i40evf":
> +                if "--crc-strip" not in param:
> +                    param += " --crc-strip"
Look like indent missing in the loop :)

> +
>          # in dpdk2.0 need used --txqflags param to open hardware features
>          if "--txqflags" not in param:
>              param += " --txqflags=0"
> --
> 2.5.5