From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 0779237A4 for ; Wed, 8 Mar 2017 10:25:50 +0100 (CET) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Mar 2017 01:25:49 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,262,1486454400"; d="scan'208";a="74149113" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by fmsmga006.fm.intel.com with ESMTP; 08 Mar 2017 01:25:49 -0800 Received: from fmsmsx123.amr.corp.intel.com (10.18.125.38) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 8 Mar 2017 01:25:49 -0800 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by fmsmsx123.amr.corp.intel.com (10.18.125.38) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 8 Mar 2017 01:25:49 -0800 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.20]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.132]) with mapi id 14.03.0248.002; Wed, 8 Mar 2017 17:25:47 +0800 From: "Liu, Yong" To: "Lin, Xueqin" , "dts@dpdk.org" CC: "Lin, Xueqin" Thread-Topic: [dts] [PATCH v2] add crc-strip param to start i40evf driver testpmd Thread-Index: AQHSl+0cQ8OJu5W2y0O0AlM3K1/Tk6GKq4vw Date: Wed, 8 Mar 2017 09:25:46 +0000 Message-ID: <86228AFD5BCD8E4EBFD2B90117B5E81E62D75C0A@SHSMSX103.ccr.corp.intel.com> References: <1488942915-8580-1-git-send-email-xueqin.lin@intel.com> In-Reply-To: <1488942915-8580-1-git-send-email-xueqin.lin@intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dts] [PATCH v2] add crc-strip param to start i40evf driver testpmd X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Mar 2017 09:25:51 -0000 Xueqin, Please check the comments. Thanks, Marvin > -----Original Message----- > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Xueqin Lin > Sent: Wednesday, March 08, 2017 11:15 AM > To: dts@dpdk.org > Cc: Lin, Xueqin > Subject: [dts] [PATCH v2] add crc-strip param to start i40evf driver > testpmd >=20 > --- > framework/pmd_output.py | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) >=20 > diff --git a/framework/pmd_output.py b/framework/pmd_output.py > index 13dcaef..1761595 100644 > --- a/framework/pmd_output.py > +++ b/framework/pmd_output.py > @@ -31,6 +31,7 @@ >=20 > import os > import re > +import settings > from settings import TIMEOUT,PROTOCOL_PACKET_SIZE > from utils import create_mask >=20 > @@ -43,6 +44,7 @@ class PmdOutput(): >=20 > def __init__(self, dut): > self.dut =3D dut > + self.NAME =3D '%s' % dut > self.dut.testpmd =3D self > self.rx_pkts_prefix =3D "RX-packets:" > self.rx_missed_prefix =3D "RX-missed:" > @@ -100,6 +102,18 @@ class PmdOutput(): > return self.command >=20 > def start_testpmd(self, cores, param=3D'', eal_param=3D'', socket=3D= 0): > + """ > + add --crc-strip param to start i40evf driver testpmd in VM, whic= h > + fix bug introduced in commit "1bbcc5d2" as workaround. > + """ > + if "virt_dut" in self.NAME: Not only virt_dut need this parameter, if run i40evf on host still need thi= s.=20 > + for (pci_bus, pci_id) in self.dut.pci_devices_info: > + if pci_id !=3D "8086:100e": > + driver =3D settings.get_nic_driver(pci_id) > + if driver =3D=3D "i40evf": > + if "--crc-strip" not in param: > + param +=3D " --crc-strip" Look like indent missing in the loop :) > + > # in dpdk2.0 need used --txqflags param to open hardware feature= s > if "--txqflags" not in param: > param +=3D " --txqflags=3D0" > -- > 2.5.5