test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Liu, Yong" <yong.liu@intel.com>
To: "Xu, HuilongX" <huilongx.xu@intel.com>, "dts@dpdk.org" <dts@dpdk.org>
Cc: "Xu, HuilongX" <huilongx.xu@intel.com>
Subject: Re: [dts] [PATCH 0/4] compile dpdk different config with different test	suite by dts framework befor run test suite
Date: Sat, 1 Apr 2017 08:20:42 +0000	[thread overview]
Message-ID: <86228AFD5BCD8E4EBFD2B90117B5E81E62DA35F7@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <1491032552-118473-1-git-send-email-huilongx.xu@intel.com>

Thanks huilong. The overall idea look good for me. Just some comments as below:

1. Configuration dependency should be based on test case not suite. Configuration requirements maybe changed even in one suite.
2. No need to compile all compile sessions. If cases not in execution list, we can skip it. It will save more time :)
3. Assume that suite can remove all dpdk build related code, cause of framework can make case not aware of configuration dependencies. 

Thanks,
Marvin

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of xu,huilong
> Sent: Saturday, April 01, 2017 3:42 PM
> To: dts@dpdk.org
> Cc: Xu, HuilongX <huilongx.xu@intel.com>
> Subject: [dts] [PATCH 0/4] compile dpdk different config with different
> test suite by dts framework befor run test suite
> 
> we should compile dpdk many times for different test suite.
> if we exec a test suite must update dpdk compile suite or change dpdk code,
> we must cpmpile dpdk two times at least.
> So this change for read exec test_suite list and compile dpdk befor run
> test suite.
> 
> update list:
>  1. conf/common_base
>     this is dpdk all compile switch from dpdk source code. it for check
> compile.cfg switch vaild.
>  2. conf/compile.cfg
>     compile config template, detaile config please see comments in file
>  3. framework/config.py
>     parse compile.cfg, detaile info please see comments in commit
>  4. framework/project_dpdk.py
>     a)define interface for test suit:
>       reset_compile_target()
>     b) read compile conf and get test suite list, then update compile
> switch and compile dpdk
>  5. framework/dts.py
>     set test suite list
>  6. tests/TestSuite_coremask.py and tests/TestSuite_queue_start_stop.py
>     example for use compile config.
> Now old interface for compile dpdk is vaild, so other case will also run
> pass.
> 
> xu,huilong (4):
>   add dpdk all compile switch
>   add compile config file template and parse compile config class
>   read compile switch config and compile dpdk before test
>   add example for test suite
> 
>  conf/common_base                    | 632
> ++++++++++++++++++++++++++++++++++++
>  conf/compile.cfg                    |  30 ++
>  framework/config.py                 |  21 +-
>  framework/dts.py                    |   2 +-
>  framework/project_dpdk.py           | 103 +++++-
>  tests/TestSuite_coremask.py         |  12 +-
>  tests/TestSuite_queue_start_stop.py |  28 +-
>  7 files changed, 789 insertions(+), 39 deletions(-)
>  create mode 100644 conf/common_base
>  create mode 100644 conf/compile.cfg
> 
> --
> 1.9.3

  parent reply	other threads:[~2017-04-01  8:20 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-01  7:42 xu,huilong
2017-04-01  7:42 ` [dts] [PATCH 1/4] add dpdk all compile switch xu,huilong
2017-04-01  8:02   ` Liu, Yong
2017-04-01  7:42 ` [dts] [PATCH 2/4] add compile config file template and parse compile config class xu,huilong
2017-04-01  7:42 ` [dts] [PATCH 3/4] read compile switch config and compile dpdk before test xu,huilong
2017-04-01  7:42 ` [dts] [PATCH 4/4] add example for test suite xu,huilong
2017-04-01  8:20 ` Liu, Yong [this message]
2017-04-01  8:31   ` [dts] [PATCH 0/4] compile dpdk different config with different test suite by dts framework befor run " Xu, HuilongX
2017-04-01  8:54     ` Liu, Yong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86228AFD5BCD8E4EBFD2B90117B5E81E62DA35F7@SHSMSX103.ccr.corp.intel.com \
    --to=yong.liu@intel.com \
    --cc=dts@dpdk.org \
    --cc=huilongx.xu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).