From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 8C8CC2B92 for ; Sat, 1 Apr 2017 10:20:46 +0200 (CEST) Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga105.jf.intel.com with ESMTP; 01 Apr 2017 01:20:45 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,256,1486454400"; d="scan'208";a="72476534" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga004.jf.intel.com with ESMTP; 01 Apr 2017 01:20:45 -0700 Received: from fmsmsx111.amr.corp.intel.com (10.18.116.5) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sat, 1 Apr 2017 01:20:44 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by fmsmsx111.amr.corp.intel.com (10.18.116.5) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sat, 1 Apr 2017 01:20:44 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.253]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.224]) with mapi id 14.03.0248.002; Sat, 1 Apr 2017 16:20:42 +0800 From: "Liu, Yong" To: "Xu, HuilongX" , "dts@dpdk.org" CC: "Xu, HuilongX" Thread-Topic: [dts] [PATCH 0/4] compile dpdk different config with different test suite by dts framework befor run test suite Thread-Index: AQHSqrtcrabPcfswkUisBbFQMZk9FaGwKepw Date: Sat, 1 Apr 2017 08:20:42 +0000 Message-ID: <86228AFD5BCD8E4EBFD2B90117B5E81E62DA35F7@SHSMSX103.ccr.corp.intel.com> References: <1491032552-118473-1-git-send-email-huilongx.xu@intel.com> In-Reply-To: <1491032552-118473-1-git-send-email-huilongx.xu@intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dts] [PATCH 0/4] compile dpdk different config with different test suite by dts framework befor run test suite X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 01 Apr 2017 08:20:47 -0000 Thanks huilong. The overall idea look good for me. Just some comments as be= low: 1. Configuration dependency should be based on test case not suite. Configu= ration requirements maybe changed even in one suite. 2. No need to compile all compile sessions. If cases not in execution list,= we can skip it. It will save more time :) 3. Assume that suite can remove all dpdk build related code, cause of frame= work can make case not aware of configuration dependencies.=20 Thanks, Marvin > -----Original Message----- > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of xu,huilong > Sent: Saturday, April 01, 2017 3:42 PM > To: dts@dpdk.org > Cc: Xu, HuilongX > Subject: [dts] [PATCH 0/4] compile dpdk different config with different > test suite by dts framework befor run test suite >=20 > we should compile dpdk many times for different test suite. > if we exec a test suite must update dpdk compile suite or change dpdk cod= e, > we must cpmpile dpdk two times at least. > So this change for read exec test_suite list and compile dpdk befor run > test suite. >=20 > update list: > 1. conf/common_base > this is dpdk all compile switch from dpdk source code. it for check > compile.cfg switch vaild. > 2. conf/compile.cfg > compile config template, detaile config please see comments in file > 3. framework/config.py > parse compile.cfg, detaile info please see comments in commit > 4. framework/project_dpdk.py > a)define interface for test suit: > reset_compile_target() > b) read compile conf and get test suite list, then update compile > switch and compile dpdk > 5. framework/dts.py > set test suite list > 6. tests/TestSuite_coremask.py and tests/TestSuite_queue_start_stop.py > example for use compile config. > Now old interface for compile dpdk is vaild, so other case will also run > pass. >=20 > xu,huilong (4): > add dpdk all compile switch > add compile config file template and parse compile config class > read compile switch config and compile dpdk before test > add example for test suite >=20 > conf/common_base | 632 > ++++++++++++++++++++++++++++++++++++ > conf/compile.cfg | 30 ++ > framework/config.py | 21 +- > framework/dts.py | 2 +- > framework/project_dpdk.py | 103 +++++- > tests/TestSuite_coremask.py | 12 +- > tests/TestSuite_queue_start_stop.py | 28 +- > 7 files changed, 789 insertions(+), 39 deletions(-) > create mode 100644 conf/common_base > create mode 100644 conf/compile.cfg >=20 > -- > 1.9.3