From: "Liu, Yong" <yong.liu@intel.com>
To: "Lin, Xueqin" <xueqin.lin@intel.com>, "dts@dpdk.org" <dts@dpdk.org>
Cc: "Lin, Xueqin" <xueqin.lin@intel.com>
Subject: Re: [dts] [PATCH] Remove crc-strip parameter when launching i40e VF testpmd 60da774e6e59ea1d4eee324920c1fb56af00d17e this patch has been fixed as default to enable HW CRC strip to let VF launch successfully.
Date: Fri, 21 Apr 2017 07:16:35 +0000 [thread overview]
Message-ID: <86228AFD5BCD8E4EBFD2B90117B5E81E62DC35AB@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <1492736790-8092-1-git-send-email-xueqin.lin@intel.com>
Hi Xueqin,
Please remove detail information from patch subject to patch commit log. Subject should be more abstract and just let audients known what happened.
Thanks,
Marvin
> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Xueqin Lin
> Sent: Friday, April 21, 2017 9:07 AM
> To: dts@dpdk.org
> Cc: Lin, Xueqin <xueqin.lin@intel.com>
> Subject: [dts] [PATCH] Remove crc-strip parameter when launching i40e VF
> testpmd 60da774e6e59ea1d4eee324920c1fb56af00d17e this patch has been fixed
> as default to enable HW CRC strip to let VF launch successfully.
>
> ---
> framework/pmd_output.py | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/framework/pmd_output.py b/framework/pmd_output.py
> index f52332b..ca361a7 100644
> --- a/framework/pmd_output.py
> +++ b/framework/pmd_output.py
> @@ -101,12 +101,6 @@ class PmdOutput():
>
> def start_testpmd(self, cores, param='', eal_param='', socket=0):
> # in dpdk2.0 need used --txqflags param to open hardware features
> - default_param = {'i40evf': ' --crc-strip'}
> - for (pci_bus, pci_id) in self.dut.pci_devices_info:
> - driver = get_nic_driver(pci_id)
> - if default_param.has_key(driver):
> - if default_param[driver] not in param:
> - param += default_param[driver]
> if "--txqflags" not in param:
> param += " --txqflags=0"
>
> --
> 2.5.5
prev parent reply other threads:[~2017-04-21 7:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-21 1:06 Xueqin Lin
2017-04-21 7:16 ` Liu, Yong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86228AFD5BCD8E4EBFD2B90117B5E81E62DC35AB@SHSMSX103.ccr.corp.intel.com \
--to=yong.liu@intel.com \
--cc=dts@dpdk.org \
--cc=xueqin.lin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).