[dts] [PATCH] Remove crc-strip parameter when launching i40e VF testpmd 60da774e6e59ea1d4eee324920c1fb56af00d17e this patch has been fixed as default to enable HW CRC strip to let VF launch successfully.

[dts] [PATCH] Remove crc-strip parameter when launching i40e VF testpmd 60da774e6e59ea1d4eee324920c1fb56af00d17e this patch has been fixed as default to enable HW CRC strip to let VF launch successfully.

[Xueqin Lin]

---
 framework/pmd_output.py | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/framework/pmd_output.py b/framework/pmd_output.py
index f52332b..ca361a7 100644
--- a/framework/pmd_output.py
+++ b/framework/pmd_output.py
@@ -101,12 +101,6 @@ class PmdOutput():
 
     def start_testpmd(self, cores, param='', eal_param='', socket=0):
         # in dpdk2.0 need used --txqflags param to open hardware features
-        default_param = {'i40evf': ' --crc-strip'}
-        for (pci_bus, pci_id) in self.dut.pci_devices_info:
-            driver = get_nic_driver(pci_id)
-            if default_param.has_key(driver):
-                if default_param[driver] not in param:
-                    param += default_param[driver]
         if "--txqflags" not in param:
             param += " --txqflags=0"
 
-- 
2.5.5

Re: [dts] [PATCH] Remove crc-strip parameter when launching i40e VF testpmd 60da774e6e59ea1d4eee324920c1fb56af00d17e this patch has been fixed as default to enable HW CRC strip to let VF launch successfully.

[Liu, Yong]

Hi Xueqin,
Please remove detail information from patch subject to patch commit log. Subject should be more abstract and just let audients known what happened.

Thanks,
Marvin

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Xueqin Lin
> Sent: Friday, April 21, 2017 9:07 AM
> To: dts@dpdk.org
> Cc: Lin, Xueqin <xueqin.lin@intel.com>
> Subject: [dts] [PATCH] Remove crc-strip parameter when launching i40e VF
> testpmd 60da774e6e59ea1d4eee324920c1fb56af00d17e this patch has been fixed
> as default to enable HW CRC strip to let VF launch successfully.
> 
> ---
>  framework/pmd_output.py | 6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/framework/pmd_output.py b/framework/pmd_output.py
> index f52332b..ca361a7 100644
> --- a/framework/pmd_output.py
> +++ b/framework/pmd_output.py
> @@ -101,12 +101,6 @@ class PmdOutput():
> 
>      def start_testpmd(self, cores, param='', eal_param='', socket=0):
>          # in dpdk2.0 need used --txqflags param to open hardware features
> -        default_param = {'i40evf': ' --crc-strip'}
> -        for (pci_bus, pci_id) in self.dut.pci_devices_info:
> -            driver = get_nic_driver(pci_id)
> -            if default_param.has_key(driver):
> -                if default_param[driver] not in param:
> -                    param += default_param[driver]
>          if "--txqflags" not in param:
>              param += " --txqflags=0"
> 
> --
> 2.5.5