From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 936952BAE for ; Fri, 21 Apr 2017 09:16:41 +0200 (CEST) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga104.jf.intel.com with ESMTP; 21 Apr 2017 00:16:40 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.37,229,1488873600"; d="scan'208";a="959490776" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga003.jf.intel.com with ESMTP; 21 Apr 2017 00:16:40 -0700 Received: from fmsmsx126.amr.corp.intel.com (10.18.125.43) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 21 Apr 2017 00:16:39 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by FMSMSX126.amr.corp.intel.com (10.18.125.43) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 21 Apr 2017 00:16:39 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.117]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.224]) with mapi id 14.03.0319.002; Fri, 21 Apr 2017 15:16:36 +0800 From: "Liu, Yong" To: "Lin, Xueqin" , "dts@dpdk.org" CC: "Lin, Xueqin" Thread-Topic: [dts] [PATCH] Remove crc-strip parameter when launching i40e VF testpmd 60da774e6e59ea1d4eee324920c1fb56af00d17e this patch has been fixed as default to enable HW CRC strip to let VF launch successfully. Thread-Index: AQHSum5v+FHElZiCjkyIzSvCK7xx9KHPaNEQ Date: Fri, 21 Apr 2017 07:16:35 +0000 Message-ID: <86228AFD5BCD8E4EBFD2B90117B5E81E62DC35AB@SHSMSX103.ccr.corp.intel.com> References: <1492736790-8092-1-git-send-email-xueqin.lin@intel.com> In-Reply-To: <1492736790-8092-1-git-send-email-xueqin.lin@intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 10.0.102.7 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dts] [PATCH] Remove crc-strip parameter when launching i40e VF testpmd 60da774e6e59ea1d4eee324920c1fb56af00d17e this patch has been fixed as default to enable HW CRC strip to let VF launch successfully. X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Apr 2017 07:16:42 -0000 Hi Xueqin, Please remove detail information from patch subject to patch commit log. Su= bject should be more abstract and just let audients known what happened. Thanks, Marvin > -----Original Message----- > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Xueqin Lin > Sent: Friday, April 21, 2017 9:07 AM > To: dts@dpdk.org > Cc: Lin, Xueqin > Subject: [dts] [PATCH] Remove crc-strip parameter when launching i40e VF > testpmd 60da774e6e59ea1d4eee324920c1fb56af00d17e this patch has been fixe= d > as default to enable HW CRC strip to let VF launch successfully. >=20 > --- > framework/pmd_output.py | 6 ------ > 1 file changed, 6 deletions(-) >=20 > diff --git a/framework/pmd_output.py b/framework/pmd_output.py > index f52332b..ca361a7 100644 > --- a/framework/pmd_output.py > +++ b/framework/pmd_output.py > @@ -101,12 +101,6 @@ class PmdOutput(): >=20 > def start_testpmd(self, cores, param=3D'', eal_param=3D'', socket=3D= 0): > # in dpdk2.0 need used --txqflags param to open hardware feature= s > - default_param =3D {'i40evf': ' --crc-strip'} > - for (pci_bus, pci_id) in self.dut.pci_devices_info: > - driver =3D get_nic_driver(pci_id) > - if default_param.has_key(driver): > - if default_param[driver] not in param: > - param +=3D default_param[driver] > if "--txqflags" not in param: > param +=3D " --txqflags=3D0" >=20 > -- > 2.5.5