test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts] [PATCH V1] fix dump failed case list
@ 2017-07-31  7:44 xu,huilong
  2017-07-31  7:44 ` [dts] [PATCH V1] remove pci unit test case xu,huilong
  0 siblings, 1 reply; 3+ messages in thread
From: xu,huilong @ 2017-07-31  7:44 UTC (permalink / raw)
  To: dts; +Cc: xu,huilong

update list:
fix dump info style for pci and mempool info
---
 tests/TestSuite_unit_tests_dump.py | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/tests/TestSuite_unit_tests_dump.py b/tests/TestSuite_unit_tests_dump.py
index 0ec8d78..03c9554 100644
--- a/tests/TestSuite_unit_tests_dump.py
+++ b/tests/TestSuite_unit_tests_dump.py
@@ -94,7 +94,7 @@ class TestUnitTestsDump(TestCase):
         
         # Nic driver will create multiple rings.
         # Only check the last one to make sure ring_dump function work.
-        self.verify( 'MP_mbuf_pool_socket_0' in result[0][-1], "dump ring name failed")
+        self.verify( 'MP_mbuf_pool_socket_0' in result[0], "dump ring name failed")
 
     def test_mempool_dump(self):
         """
@@ -107,7 +107,7 @@ class TestUnitTestsDump(TestCase):
         m = re.compile(r"%s" % match_regex, re.S)
         result = m.findall(out)
 
-        self.verify(result[0][0] == 'mbuf_pool_socket_0', "dump mempool name failed")
+        self.verify(result[0][0] == 'MP_mbuf_pool_socket_0', "dump mempool name failed")
 
     def test_physmem_dump(self):
         """
@@ -178,7 +178,7 @@ class TestUnitTestsDump(TestCase):
                              % (self.target, pci_address), "R.*T.*E.*>.*>", self.start_test_time)
         out = self.dut.send_expect("dump_devargs", "RTE>>", self.run_cmd_time * 2)
         self.dut.send_expect("quit", "# ")
-        black_str = "PCI blacklist %s" % pci_address
+        black_str = " %s" % pci_address
         self.verify(black_str in out, "Dump black list failed")
 
         self.dut.send_expect("./%s/app/test -n 1 -c f -w %s"
@@ -186,7 +186,7 @@ class TestUnitTestsDump(TestCase):
         out = self.dut.send_expect("dump_devargs", "RTE>>", self.run_cmd_time * 2)
         self.dut.send_expect("quit", "# ")
 
-        white_str = "PCI whitelist %s" % pci_address
+        white_str = "[pci]: %s" % pci_address
         self.verify(white_str in out, "Dump white list failed")
 
     def tear_down(self):
-- 
1.9.3

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [dts] [PATCH V1] remove pci unit test case
  2017-07-31  7:44 [dts] [PATCH V1] fix dump failed case list xu,huilong
@ 2017-07-31  7:44 ` xu,huilong
  2017-07-31  7:54   ` Liu, Yong
  0 siblings, 1 reply; 3+ messages in thread
From: xu,huilong @ 2017-07-31  7:44 UTC (permalink / raw)
  To: dts; +Cc: xu,huilong

pci unit test case remove already in dpdk 17.08
---
 tests/TestSuite_unit_tests_eal.py | 10 ----------
 1 file changed, 10 deletions(-)

diff --git a/tests/TestSuite_unit_tests_eal.py b/tests/TestSuite_unit_tests_eal.py
index 2b46952..ba58891 100644
--- a/tests/TestSuite_unit_tests_eal.py
+++ b/tests/TestSuite_unit_tests_eal.py
@@ -153,16 +153,6 @@ class TestUnitTestsEal(TestCase):
         self.dut.send_expect("quit", "# ")
         self.verify("Test OK" in out, "Test failed")
 
-    def test_pci(self):
-        """
-        Run pci autotest.
-        """
-        # should re-compile test app, this is only a demo. will implementation after framework support
-        self.dut.send_expect("./%s/app/test_pci -n 1 -c f" % self.target, "R.*T.*E.*>.*>" , self.start_test_time)
-        out = self.dut.send_expect("pci_autotest", "RTE>>", self.run_cmd_time)
-        self.dut.send_expect("quit", "# ")
-        self.verify("Test OK" in out, "Test failed")
-
     def test_atomic(self):
         """
         Run atomic autotest.
-- 
1.9.3

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dts] [PATCH V1] remove pci unit test case
  2017-07-31  7:44 ` [dts] [PATCH V1] remove pci unit test case xu,huilong
@ 2017-07-31  7:54   ` Liu, Yong
  0 siblings, 0 replies; 3+ messages in thread
From: Liu, Yong @ 2017-07-31  7:54 UTC (permalink / raw)
  To: Xu, HuilongX, dts; +Cc: Xu, HuilongX

Thanks, applied. Please add signed-off tag in your patch.

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of xu,huilong
> Sent: Monday, July 31, 2017 3:44 PM
> To: dts@dpdk.org
> Cc: Xu, HuilongX <huilongx.xu@intel.com>
> Subject: [dts] [PATCH V1] remove pci unit test case
> 
> pci unit test case remove already in dpdk 17.08
> ---
>  tests/TestSuite_unit_tests_eal.py | 10 ----------
>  1 file changed, 10 deletions(-)
> 
> diff --git a/tests/TestSuite_unit_tests_eal.py
> b/tests/TestSuite_unit_tests_eal.py
> index 2b46952..ba58891 100644
> --- a/tests/TestSuite_unit_tests_eal.py
> +++ b/tests/TestSuite_unit_tests_eal.py
> @@ -153,16 +153,6 @@ class TestUnitTestsEal(TestCase):
>          self.dut.send_expect("quit", "# ")
>          self.verify("Test OK" in out, "Test failed")
> 
> -    def test_pci(self):
> -        """
> -        Run pci autotest.
> -        """
> -        # should re-compile test app, this is only a demo. will
> implementation after framework support
> -        self.dut.send_expect("./%s/app/test_pci -n 1 -c f" % self.target,
> "R.*T.*E.*>.*>" , self.start_test_time)
> -        out = self.dut.send_expect("pci_autotest", "RTE>>",
> self.run_cmd_time)
> -        self.dut.send_expect("quit", "# ")
> -        self.verify("Test OK" in out, "Test failed")
> -
>      def test_atomic(self):
>          """
>          Run atomic autotest.
> --
> 1.9.3

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2017-07-31  8:02 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-07-31  7:44 [dts] [PATCH V1] fix dump failed case list xu,huilong
2017-07-31  7:44 ` [dts] [PATCH V1] remove pci unit test case xu,huilong
2017-07-31  7:54   ` Liu, Yong

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).