From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 0449D532D for ; Fri, 11 Aug 2017 09:12:35 +0200 (CEST) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Aug 2017 00:11:57 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.41,356,1498546800"; d="scan'208";a="139040128" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by fmsmga006.fm.intel.com with ESMTP; 11 Aug 2017 00:11:56 -0700 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 11 Aug 2017 00:11:56 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.236]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.114]) with mapi id 14.03.0319.002; Fri, 11 Aug 2017 15:11:54 +0800 From: "Liu, Yong" To: "Lu, PeipeiX" , "dts@dpdk.org" CC: "Lu, PeipeiX" Thread-Topic: [dts] [PATCH V1] Regular expressions don't match Thread-Index: AQHTEmeDUTnfZbY5bE+7Hxny1mwCoaJ+vLoQ Date: Fri, 11 Aug 2017 07:11:54 +0000 Message-ID: <86228AFD5BCD8E4EBFD2B90117B5E81E62E51CB8@SHSMSX103.ccr.corp.intel.com> References: <1502431422-65223-1-git-send-email-peipeix.lu@intel.com> In-Reply-To: <1502431422-65223-1-git-send-email-peipeix.lu@intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 10.0.102.7 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dts] [PATCH V1] Regular expressions don't match X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Aug 2017 07:12:36 -0000 Peipei, one comment below. > -----Original Message----- > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of lu,peipei > Sent: Friday, August 11, 2017 2:04 PM > To: dts@dpdk.org > Cc: Lu, PeipeiX > Subject: [dts] [PATCH V1] Regular expressions don't match >=20 > Signed-off-by: lu,peipei > --- > tests/TestSuite_unit_tests_dump.py | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) >=20 > diff --git a/tests/TestSuite_unit_tests_dump.py > b/tests/TestSuite_unit_tests_dump.py > index 03c9554..90588cb 100644 > --- a/tests/TestSuite_unit_tests_dump.py > +++ b/tests/TestSuite_unit_tests_dump.py > @@ -88,13 +88,13 @@ class TestUnitTestsDump(TestCase): > self.dut.send_expect("./%s/app/testpmd -n 1 -c f -- -i" % > (self.target), "testpmd>", self.start_test_time) > out =3D self.dut.send_expect("dump_ring", "testpmd>", > self.run_cmd_time) > self.dut.send_expect("quit", "# ") > - match_regex =3D "ring <(.*?)>@0x(.*)\r\n" > + match_regex =3D "ring <(.*?)>" > m =3D re.compile(r"%s" % match_regex, re.S) > result =3D m.findall(out) Ring dump information will be started with below format. ring @0x7fb9a7736280 Look like original code should be also workable. Could you give more inform= ation about why here need the change? >=20 > # Nic driver will create multiple rings. > # Only check the last one to make sure ring_dump function work. > - self.verify( 'MP_mbuf_pool_socket_0' in result[0], "dump ring > name failed") > + self.verify( 'MP_mbuf_pool_socket_0' in result, "dump ring name > failed") >=20 > def test_mempool_dump(self): > """ > @@ -107,7 +107,7 @@ class TestUnitTestsDump(TestCase): > m =3D re.compile(r"%s" % match_regex, re.S) > result =3D m.findall(out) >=20 > - self.verify(result[0][0] =3D=3D 'MP_mbuf_pool_socket_0', "dump > mempool name failed") > + self.verify(result[0][0] =3D=3D 'mbuf_pool_socket_0', "dump memp= ool > name failed") >=20 > def test_physmem_dump(self): > """ > -- > 1.9.3