test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts] [PATCH V1] discard malloc unit test case
@ 2017-08-11  7:13 xu,huilong
  2017-08-11  7:38 ` Liu, Yong
  0 siblings, 1 reply; 6+ messages in thread
From: xu,huilong @ 2017-08-11  7:13 UTC (permalink / raw)
  To: dts; +Cc: xu,huilong

in new dpdk code, malloc unit test case discard already, so should remove
this case in test suitein new dpdk code, malloc unit test case discard already, so should remove

Signed-off-by: xu,huilong <huilongx.xu@intel.com>
---
 tests/TestSuite_unit_tests_eal.py | 10 ----------
 1 file changed, 10 deletions(-)

diff --git a/tests/TestSuite_unit_tests_eal.py b/tests/TestSuite_unit_tests_eal.py
index ba58891..26fb1b3 100644
--- a/tests/TestSuite_unit_tests_eal.py
+++ b/tests/TestSuite_unit_tests_eal.py
@@ -128,16 +128,6 @@ class TestUnitTestsEal(TestCase):
         self.dut.send_expect("quit", "# ")
         self.verify("Test OK" in out, "Test failed")
 
-    def test_malloc(self):
-        """
-        Run malloc autotest.
-        """
-
-        self.dut.send_expect(self.test_app_cmdline, "R.*T.*E.*>.*>", self.start_test_time)
-        out = self.dut.send_expect("malloc_autotest", "RTE>>", self.run_cmd_time)
-        self.dut.send_expect("quit", "# ")
-        self.verify("Test OK" in out, "Test failed")
-
     def test_func_reentrancy(self):
         """
         Run function reentrancy autotest.
-- 
1.9.3

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dts] [PATCH V1] discard malloc unit test case
  2017-08-11  7:13 [dts] [PATCH V1] discard malloc unit test case xu,huilong
@ 2017-08-11  7:38 ` Liu, Yong
  2017-08-11  7:40   ` Xu, Qian Q
  2017-08-11  8:20   ` Xu, HuilongX
  0 siblings, 2 replies; 6+ messages in thread
From: Liu, Yong @ 2017-08-11  7:38 UTC (permalink / raw)
  To: Xu, HuilongX, dts; +Cc: Xu, HuilongX

Huilong,
Malloc autotest still existing in dpdk code. Please check again.

Thank,
Marvin

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of xu,huilong
> Sent: Friday, August 11, 2017 3:13 PM
> To: dts@dpdk.org
> Cc: Xu, HuilongX <huilongx.xu@intel.com>
> Subject: [dts] [PATCH V1] discard malloc unit test case
> 
> in new dpdk code, malloc unit test case discard already, so should remove
> this case in test suitein new dpdk code, malloc unit test case discard
> already, so should remove
> 
> Signed-off-by: xu,huilong <huilongx.xu@intel.com>

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dts] [PATCH V1] discard malloc unit test case
  2017-08-11  7:38 ` Liu, Yong
@ 2017-08-11  7:40   ` Xu, Qian Q
  2017-08-11  8:20   ` Xu, HuilongX
  1 sibling, 0 replies; 6+ messages in thread
From: Xu, Qian Q @ 2017-08-11  7:40 UTC (permalink / raw)
  To: Liu, Yong, Xu, HuilongX, dts; +Cc: Xu, HuilongX

But seems this case is invalid from dev's view. Is it the case, Huilong? 

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Liu, Yong
> Sent: Friday, August 11, 2017 3:38 PM
> To: Xu, HuilongX <huilongx.xu@intel.com>; dts@dpdk.org
> Cc: Xu, HuilongX <huilongx.xu@intel.com>
> Subject: Re: [dts] [PATCH V1] discard malloc unit test case
> 
> Huilong,
> Malloc autotest still existing in dpdk code. Please check again.
> 
> Thank,
> Marvin
> 
> > -----Original Message-----
> > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of xu,huilong
> > Sent: Friday, August 11, 2017 3:13 PM
> > To: dts@dpdk.org
> > Cc: Xu, HuilongX <huilongx.xu@intel.com>
> > Subject: [dts] [PATCH V1] discard malloc unit test case
> >
> > in new dpdk code, malloc unit test case discard already, so should
> > remove this case in test suitein new dpdk code, malloc unit test case
> > discard already, so should remove
> >
> > Signed-off-by: xu,huilong <huilongx.xu@intel.com>

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dts] [PATCH V1] discard malloc unit test case
  2017-08-11  7:38 ` Liu, Yong
  2017-08-11  7:40   ` Xu, Qian Q
@ 2017-08-11  8:20   ` Xu, HuilongX
  2017-08-11  8:22     ` Liu, Yong
  1 sibling, 1 reply; 6+ messages in thread
From: Xu, HuilongX @ 2017-08-11  8:20 UTC (permalink / raw)
  To: Liu, Yong, dts

Yes,
This cmdline still existing in dpdk, but development not maintain already, you can check dpdk-2340 in jira
Thanks  a lot

-----Original Message-----
From: Liu, Yong 
Sent: Friday, August 11, 2017 3:38 PM
To: Xu, HuilongX <huilongx.xu@intel.com>; dts@dpdk.org
Cc: Xu, HuilongX <huilongx.xu@intel.com>
Subject: RE: [dts] [PATCH V1] discard malloc unit test case

Huilong,
Malloc autotest still existing in dpdk code. Please check again.

Thank,
Marvin

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of xu,huilong
> Sent: Friday, August 11, 2017 3:13 PM
> To: dts@dpdk.org
> Cc: Xu, HuilongX <huilongx.xu@intel.com>
> Subject: [dts] [PATCH V1] discard malloc unit test case
> 
> in new dpdk code, malloc unit test case discard already, so should 
> remove this case in test suitein new dpdk code, malloc unit test case 
> discard already, so should remove
> 
> Signed-off-by: xu,huilong <huilongx.xu@intel.com>

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dts] [PATCH V1] discard malloc unit test case
  2017-08-11  8:20   ` Xu, HuilongX
@ 2017-08-11  8:22     ` Liu, Yong
  0 siblings, 0 replies; 6+ messages in thread
From: Liu, Yong @ 2017-08-11  8:22 UTC (permalink / raw)
  To: Xu, HuilongX, dts

Huilong, thanks for double check. Please also add this information in the commit log.

Thanks,
Marvin
> -----Original Message-----
> From: Xu, HuilongX
> Sent: Friday, August 11, 2017 4:21 PM
> To: Liu, Yong <yong.liu@intel.com>; dts@dpdk.org
> Subject: RE: [dts] [PATCH V1] discard malloc unit test case
> 
> Yes,
> This cmdline still existing in dpdk, but development not maintain already,
> you can check dpdk-2340 in jira
> Thanks  a lot
> 
> -----Original Message-----
> From: Liu, Yong
> Sent: Friday, August 11, 2017 3:38 PM
> To: Xu, HuilongX <huilongx.xu@intel.com>; dts@dpdk.org
> Cc: Xu, HuilongX <huilongx.xu@intel.com>
> Subject: RE: [dts] [PATCH V1] discard malloc unit test case
> 
> Huilong,
> Malloc autotest still existing in dpdk code. Please check again.
> 
> Thank,
> Marvin
> 
> > -----Original Message-----
> > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of xu,huilong
> > Sent: Friday, August 11, 2017 3:13 PM
> > To: dts@dpdk.org
> > Cc: Xu, HuilongX <huilongx.xu@intel.com>
> > Subject: [dts] [PATCH V1] discard malloc unit test case
> >
> > in new dpdk code, malloc unit test case discard already, so should
> > remove this case in test suitein new dpdk code, malloc unit test case
> > discard already, so should remove
> >
> > Signed-off-by: xu,huilong <huilongx.xu@intel.com>

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [dts] [PATCH V1] discard malloc unit test case
@ 2017-03-09  8:24 xu,huilong
  0 siblings, 0 replies; 6+ messages in thread
From: xu,huilong @ 2017-03-09  8:24 UTC (permalink / raw)
  To: dts; +Cc: xu,huilong

in new dpdk code, malloc unit test case discard already, so should remove
this case in test suite

Signed-off-by: xu,huilong <huilongx.xu@intel.com>
---
 tests/TestSuite_unit_tests_eal.py | 10 ----------
 1 file changed, 10 deletions(-)

diff --git a/tests/TestSuite_unit_tests_eal.py b/tests/TestSuite_unit_tests_eal.py
index 2b46952..2e6344a 100644
--- a/tests/TestSuite_unit_tests_eal.py
+++ b/tests/TestSuite_unit_tests_eal.py
@@ -128,16 +128,6 @@ class TestUnitTestsEal(TestCase):
         self.dut.send_expect("quit", "# ")
         self.verify("Test OK" in out, "Test failed")
 
-    def test_malloc(self):
-        """
-        Run malloc autotest.
-        """
-
-        self.dut.send_expect(self.test_app_cmdline, "R.*T.*E.*>.*>", self.start_test_time)
-        out = self.dut.send_expect("malloc_autotest", "RTE>>", self.run_cmd_time)
-        self.dut.send_expect("quit", "# ")
-        self.verify("Test OK" in out, "Test failed")
-
     def test_func_reentrancy(self):
         """
         Run function reentrancy autotest.
-- 
1.9.3

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2017-08-11  8:22 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-08-11  7:13 [dts] [PATCH V1] discard malloc unit test case xu,huilong
2017-08-11  7:38 ` Liu, Yong
2017-08-11  7:40   ` Xu, Qian Q
2017-08-11  8:20   ` Xu, HuilongX
2017-08-11  8:22     ` Liu, Yong
  -- strict thread matches above, loose matches on Subject: below --
2017-03-09  8:24 xu,huilong

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).