Re: [dts] [PATCH V1] Regular expressions don't match

["Liu, Yong" <yong.liu@intel.com>]

Peipei,
I think your commit log is not so accurate. The root cause is that "MP_mbuf_pool_socket_0" is no longer the first mempool.
So the check function will be failed. Please modify your commit log.

Thanks,
Marvin

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of lu,peipei
> Sent: Monday, August 14, 2017 4:25 PM
> To: dts@dpdk.org
> Cc: Lu, PeipeiX <peipeix.lu@intel.com>
> Subject: [dts] [PATCH V1] Regular expressions don't match
> 
> Output format is:
>   ring <HT_fdir_0000:05:00.0>@0x7f03bff6e500
>   flags=0
>   ring <HT_l2_tn_0000:05:00.0>@0x7f03bfc6dc00
>   flags=0
>   ring <HT_fdir_0000:05:00.1>@0x7f03bfc22780
>   flags=0
>   ring <MP_mbuf_pool_socket_0>@0x7f03a724c580
>   flags=0
> Original regex format can not parse it for "MP_mbuf_pool_socket_0"
> New regex format is "ring <(.*?)>"
> 
> 
> 
> 
> Signed-off-by: lu,peipei <peipeix.lu@intel.com>
> ---
>  tests/TestSuite_unit_tests_dump.py | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/tests/TestSuite_unit_tests_dump.py
> b/tests/TestSuite_unit_tests_dump.py
> index 03c9554..90588cb 100644
> --- a/tests/TestSuite_unit_tests_dump.py
> +++ b/tests/TestSuite_unit_tests_dump.py
> @@ -88,13 +88,13 @@ class TestUnitTestsDump(TestCase):
>          self.dut.send_expect("./%s/app/testpmd -n 1 -c f -- -i" %
> (self.target), "testpmd>", self.start_test_time)
>          out = self.dut.send_expect("dump_ring", "testpmd>",
> self.run_cmd_time)
>          self.dut.send_expect("quit", "# ")
> -        match_regex = "ring <(.*?)>@0x(.*)\r\n"
> +        match_regex = "ring <(.*?)>"
>          m = re.compile(r"%s" % match_regex, re.S)
>          result = m.findall(out)
> 
>          # Nic driver will create multiple rings.
>          # Only check the last one to make sure ring_dump function work.
> -        self.verify( 'MP_mbuf_pool_socket_0' in result[0], "dump ring
> name failed")
> +        self.verify( 'MP_mbuf_pool_socket_0' in result, "dump ring name
> failed")
> 
>      def test_mempool_dump(self):
>          """
> @@ -107,7 +107,7 @@ class TestUnitTestsDump(TestCase):
>          m = re.compile(r"%s" % match_regex, re.S)
>          result = m.findall(out)
> 
> -        self.verify(result[0][0] == 'MP_mbuf_pool_socket_0', "dump
> mempool name failed")
> +        self.verify(result[0][0] == 'mbuf_pool_socket_0', "dump mempool
> name failed")
> 
>      def test_physmem_dump(self):
>          """
> --
> 1.9.3