From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 29D329137 for ; Mon, 14 Aug 2017 10:53:23 +0200 (CEST) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga105.fm.intel.com with ESMTP; 14 Aug 2017 01:53:23 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.41,372,1498546800"; d="scan'208";a="1003327476" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga003.jf.intel.com with ESMTP; 14 Aug 2017 01:53:22 -0700 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 14 Aug 2017 01:53:22 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.236]) by shsmsx102.ccr.corp.intel.com ([169.254.2.183]) with mapi id 14.03.0319.002; Mon, 14 Aug 2017 16:53:20 +0800 From: "Liu, Yong" To: "Lu, PeipeiX" , "dts@dpdk.org" CC: "Lu, PeipeiX" Thread-Topic: [dts] [PATCH V1] Regular expressions don't match Thread-Index: AQHTFNbID5RMgUtpEkCK4Y/BN6ZkmqKDifFQ Date: Mon, 14 Aug 2017 08:53:19 +0000 Message-ID: <86228AFD5BCD8E4EBFD2B90117B5E81E62E530FC@SHSMSX103.ccr.corp.intel.com> References: <1502699127-70950-1-git-send-email-peipeix.lu@intel.com> In-Reply-To: <1502699127-70950-1-git-send-email-peipeix.lu@intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 10.0.102.7 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dts] [PATCH V1] Regular expressions don't match X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Aug 2017 08:53:25 -0000 Peipei, I think your commit log is not so accurate. The root cause is that "MP_mbuf= _pool_socket_0" is no longer the first mempool. So the check function will be failed. Please modify your commit log. Thanks, Marvin > -----Original Message----- > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of lu,peipei > Sent: Monday, August 14, 2017 4:25 PM > To: dts@dpdk.org > Cc: Lu, PeipeiX > Subject: [dts] [PATCH V1] Regular expressions don't match >=20 > Output format is: > ring @0x7f03bff6e500 > flags=3D0 > ring @0x7f03bfc6dc00 > flags=3D0 > ring @0x7f03bfc22780 > flags=3D0 > ring @0x7f03a724c580 > flags=3D0 > Original regex format can not parse it for "MP_mbuf_pool_socket_0" > New regex format is "ring <(.*?)>" >=20 >=20 >=20 >=20 > Signed-off-by: lu,peipei > --- > tests/TestSuite_unit_tests_dump.py | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) >=20 > diff --git a/tests/TestSuite_unit_tests_dump.py > b/tests/TestSuite_unit_tests_dump.py > index 03c9554..90588cb 100644 > --- a/tests/TestSuite_unit_tests_dump.py > +++ b/tests/TestSuite_unit_tests_dump.py > @@ -88,13 +88,13 @@ class TestUnitTestsDump(TestCase): > self.dut.send_expect("./%s/app/testpmd -n 1 -c f -- -i" % > (self.target), "testpmd>", self.start_test_time) > out =3D self.dut.send_expect("dump_ring", "testpmd>", > self.run_cmd_time) > self.dut.send_expect("quit", "# ") > - match_regex =3D "ring <(.*?)>@0x(.*)\r\n" > + match_regex =3D "ring <(.*?)>" > m =3D re.compile(r"%s" % match_regex, re.S) > result =3D m.findall(out) >=20 > # Nic driver will create multiple rings. > # Only check the last one to make sure ring_dump function work. > - self.verify( 'MP_mbuf_pool_socket_0' in result[0], "dump ring > name failed") > + self.verify( 'MP_mbuf_pool_socket_0' in result, "dump ring name > failed") >=20 > def test_mempool_dump(self): > """ > @@ -107,7 +107,7 @@ class TestUnitTestsDump(TestCase): > m =3D re.compile(r"%s" % match_regex, re.S) > result =3D m.findall(out) >=20 > - self.verify(result[0][0] =3D=3D 'MP_mbuf_pool_socket_0', "dump > mempool name failed") > + self.verify(result[0][0] =3D=3D 'mbuf_pool_socket_0', "dump memp= ool > name failed") >=20 > def test_physmem_dump(self): > """ > -- > 1.9.3