test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Liu, Yong" <yong.liu@intel.com>
To: "Xu, GangX" <gangx.xu@intel.com>, "dts@dpdk.org" <dts@dpdk.org>
Cc: "Xu, GangX" <gangx.xu@intel.com>
Subject: Re: [dts] [PATCH V1] fix Pmd set_up_all on FreeBSD
Date: Tue, 22 Aug 2017 01:19:59 +0000	[thread overview]
Message-ID: <86228AFD5BCD8E4EBFD2B90117B5E81E62E5744F@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <1503298566-83950-1-git-send-email-gangx.xu@intel.com>

Gang,
Your change may make this suite not workable for regular performance report.
You'd better to add functions support on FreeBSD. Another choice is that just skip the execution if found FreeBSD system.

Thanks,
Marvin

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of xu,gang
> Sent: Monday, August 21, 2017 2:56 PM
> To: dts@dpdk.org
> Cc: Xu, GangX <gangx.xu@intel.com>
> Subject: [dts] [PATCH V1] fix Pmd set_up_all on FreeBSD
> 
> dts have not bind_driver() on FreeBSD and the code is
> not used by context
> 
> Signed-off-by: xu,gang <gangx.xu@intel.com>
> ---
>  tests/TestSuite_pmd.py | 13 -------------
>  1 file changed, 13 deletions(-)
> 
> diff --git a/tests/TestSuite_pmd.py b/tests/TestSuite_pmd.py
> index 8f4b22c..b69761f 100644
> --- a/tests/TestSuite_pmd.py
> +++ b/tests/TestSuite_pmd.py
> @@ -84,19 +84,6 @@ class TestPmd(TestCase,IxiaPacketGenerator):
>          # Based on h/w type, choose how many ports to use
>          self.dut_ports = self.dut.get_ports()
> 
> -        # Get dut system information
> -        port_num = self.dut_ports[0]
> -        pci_device_id = self.dut.ports_info[port_num]['pci']
> -        ori_driver =
> self.dut.ports_info[port_num]['port'].get_nic_driver()
> -        self.dut.ports_info[port_num]['port'].bind_driver()
> -
> -        sut = SystemInfo(self.dut, pci_device_id)
> -        self.system_info = sut.get_system_info()
> -        self.nic_info = sut.get_nic_info()
> -
> -        self.dut.ports_info[port_num]['port'].bind_driver(ori_driver)
> -        ######
> -
>          self.headers_size = HEADER_SIZE['eth'] + HEADER_SIZE[
>              'ip'] + HEADER_SIZE['tcp']
> 
> --
> 1.9.3

      reply	other threads:[~2017-08-22  1:20 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-21  6:56 xu,gang
2017-08-22  1:19 ` Liu, Yong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86228AFD5BCD8E4EBFD2B90117B5E81E62E5744F@SHSMSX103.ccr.corp.intel.com \
    --to=yong.liu@intel.com \
    --cc=dts@dpdk.org \
    --cc=gangx.xu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).