From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 8B84B7CAB for ; Tue, 22 Aug 2017 03:20:06 +0200 (CEST) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Aug 2017 18:20:02 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.41,410,1498546800"; d="scan'208";a="143015422" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga006.fm.intel.com with ESMTP; 21 Aug 2017 18:20:02 -0700 Received: from fmsmsx114.amr.corp.intel.com (10.18.116.8) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 21 Aug 2017 18:20:02 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by FMSMSX114.amr.corp.intel.com (10.18.116.8) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 21 Aug 2017 18:20:02 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.236]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.25]) with mapi id 14.03.0319.002; Tue, 22 Aug 2017 09:20:00 +0800 From: "Liu, Yong" To: "Xu, GangX" , "dts@dpdk.org" CC: "Xu, GangX" Thread-Topic: [dts] [PATCH V1] fix Pmd set_up_all on FreeBSD Thread-Index: AQHTGkpxVucxSvQqvEGdi/Doh2VSkaKPlABQ Date: Tue, 22 Aug 2017 01:19:59 +0000 Message-ID: <86228AFD5BCD8E4EBFD2B90117B5E81E62E5744F@SHSMSX103.ccr.corp.intel.com> References: <1503298566-83950-1-git-send-email-gangx.xu@intel.com> In-Reply-To: <1503298566-83950-1-git-send-email-gangx.xu@intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 10.0.102.7 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dts] [PATCH V1] fix Pmd set_up_all on FreeBSD X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Aug 2017 01:20:07 -0000 Gang, Your change may make this suite not workable for regular performance report= . You'd better to add functions support on FreeBSD. Another choice is that ju= st skip the execution if found FreeBSD system. Thanks, Marvin > -----Original Message----- > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of xu,gang > Sent: Monday, August 21, 2017 2:56 PM > To: dts@dpdk.org > Cc: Xu, GangX > Subject: [dts] [PATCH V1] fix Pmd set_up_all on FreeBSD >=20 > dts have not bind_driver() on FreeBSD and the code is > not used by context >=20 > Signed-off-by: xu,gang > --- > tests/TestSuite_pmd.py | 13 ------------- > 1 file changed, 13 deletions(-) >=20 > diff --git a/tests/TestSuite_pmd.py b/tests/TestSuite_pmd.py > index 8f4b22c..b69761f 100644 > --- a/tests/TestSuite_pmd.py > +++ b/tests/TestSuite_pmd.py > @@ -84,19 +84,6 @@ class TestPmd(TestCase,IxiaPacketGenerator): > # Based on h/w type, choose how many ports to use > self.dut_ports =3D self.dut.get_ports() >=20 > - # Get dut system information > - port_num =3D self.dut_ports[0] > - pci_device_id =3D self.dut.ports_info[port_num]['pci'] > - ori_driver =3D > self.dut.ports_info[port_num]['port'].get_nic_driver() > - self.dut.ports_info[port_num]['port'].bind_driver() > - > - sut =3D SystemInfo(self.dut, pci_device_id) > - self.system_info =3D sut.get_system_info() > - self.nic_info =3D sut.get_nic_info() > - > - self.dut.ports_info[port_num]['port'].bind_driver(ori_driver) > - ###### > - > self.headers_size =3D HEADER_SIZE['eth'] + HEADER_SIZE[ > 'ip'] + HEADER_SIZE['tcp'] >=20 > -- > 1.9.3