* [dts] [PATCH V1] fix Pmd set_up_all on FreeBSD
@ 2017-08-21 6:56 xu,gang
2017-08-22 1:19 ` Liu, Yong
0 siblings, 1 reply; 2+ messages in thread
From: xu,gang @ 2017-08-21 6:56 UTC (permalink / raw)
To: dts; +Cc: xu,gang
dts have not bind_driver() on FreeBSD and the code is
not used by context
Signed-off-by: xu,gang <gangx.xu@intel.com>
---
tests/TestSuite_pmd.py | 13 -------------
1 file changed, 13 deletions(-)
diff --git a/tests/TestSuite_pmd.py b/tests/TestSuite_pmd.py
index 8f4b22c..b69761f 100644
--- a/tests/TestSuite_pmd.py
+++ b/tests/TestSuite_pmd.py
@@ -84,19 +84,6 @@ class TestPmd(TestCase,IxiaPacketGenerator):
# Based on h/w type, choose how many ports to use
self.dut_ports = self.dut.get_ports()
- # Get dut system information
- port_num = self.dut_ports[0]
- pci_device_id = self.dut.ports_info[port_num]['pci']
- ori_driver = self.dut.ports_info[port_num]['port'].get_nic_driver()
- self.dut.ports_info[port_num]['port'].bind_driver()
-
- sut = SystemInfo(self.dut, pci_device_id)
- self.system_info = sut.get_system_info()
- self.nic_info = sut.get_nic_info()
-
- self.dut.ports_info[port_num]['port'].bind_driver(ori_driver)
- ######
-
self.headers_size = HEADER_SIZE['eth'] + HEADER_SIZE[
'ip'] + HEADER_SIZE['tcp']
--
1.9.3
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dts] [PATCH V1] fix Pmd set_up_all on FreeBSD
2017-08-21 6:56 [dts] [PATCH V1] fix Pmd set_up_all on FreeBSD xu,gang
@ 2017-08-22 1:19 ` Liu, Yong
0 siblings, 0 replies; 2+ messages in thread
From: Liu, Yong @ 2017-08-22 1:19 UTC (permalink / raw)
To: Xu, GangX, dts; +Cc: Xu, GangX
Gang,
Your change may make this suite not workable for regular performance report.
You'd better to add functions support on FreeBSD. Another choice is that just skip the execution if found FreeBSD system.
Thanks,
Marvin
> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of xu,gang
> Sent: Monday, August 21, 2017 2:56 PM
> To: dts@dpdk.org
> Cc: Xu, GangX <gangx.xu@intel.com>
> Subject: [dts] [PATCH V1] fix Pmd set_up_all on FreeBSD
>
> dts have not bind_driver() on FreeBSD and the code is
> not used by context
>
> Signed-off-by: xu,gang <gangx.xu@intel.com>
> ---
> tests/TestSuite_pmd.py | 13 -------------
> 1 file changed, 13 deletions(-)
>
> diff --git a/tests/TestSuite_pmd.py b/tests/TestSuite_pmd.py
> index 8f4b22c..b69761f 100644
> --- a/tests/TestSuite_pmd.py
> +++ b/tests/TestSuite_pmd.py
> @@ -84,19 +84,6 @@ class TestPmd(TestCase,IxiaPacketGenerator):
> # Based on h/w type, choose how many ports to use
> self.dut_ports = self.dut.get_ports()
>
> - # Get dut system information
> - port_num = self.dut_ports[0]
> - pci_device_id = self.dut.ports_info[port_num]['pci']
> - ori_driver =
> self.dut.ports_info[port_num]['port'].get_nic_driver()
> - self.dut.ports_info[port_num]['port'].bind_driver()
> -
> - sut = SystemInfo(self.dut, pci_device_id)
> - self.system_info = sut.get_system_info()
> - self.nic_info = sut.get_nic_info()
> -
> - self.dut.ports_info[port_num]['port'].bind_driver(ori_driver)
> - ######
> -
> self.headers_size = HEADER_SIZE['eth'] + HEADER_SIZE[
> 'ip'] + HEADER_SIZE['tcp']
>
> --
> 1.9.3
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-08-22 1:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-08-21 6:56 [dts] [PATCH V1] fix Pmd set_up_all on FreeBSD xu,gang
2017-08-22 1:19 ` Liu, Yong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).