From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 3B6787D36 for ; Thu, 24 Aug 2017 05:50:54 +0200 (CEST) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 23 Aug 2017 20:50:53 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.41,419,1498546800"; d="scan'208";a="1187571020" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga001.fm.intel.com with ESMTP; 23 Aug 2017 20:50:53 -0700 Received: from fmsmsx116.amr.corp.intel.com (10.18.116.20) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 23 Aug 2017 20:50:53 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by fmsmsx116.amr.corp.intel.com (10.18.116.20) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 23 Aug 2017 20:50:52 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.128]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.98]) with mapi id 14.03.0319.002; Thu, 24 Aug 2017 11:50:50 +0800 From: "Liu, Yong" To: "Xu, GangX" , "dts@dpdk.org" CC: "Xu, HuilongX" Thread-Topic: [dts] [PATCH V1] fix userspace failed case Thread-Index: AQHTG+5usX0RH4BQDEWV1e4eKiS3OKKS3zYA Date: Thu, 24 Aug 2017 03:50:49 +0000 Message-ID: <86228AFD5BCD8E4EBFD2B90117B5E81E62E665E0@SHSMSX101.ccr.corp.intel.com> References: <1503478919-86948-1-git-send-email-gangx.xu@intel.com> In-Reply-To: <1503478919-86948-1-git-send-email-gangx.xu@intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 10.0.102.7 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dts] [PATCH V1] fix userspace failed case X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Aug 2017 03:50:55 -0000 Thanks gang, few comments below. > -----Original Message----- > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of xu,gang > Sent: Wednesday, August 23, 2017 5:02 PM > To: dts@dpdk.org > Cc: Xu, HuilongX > Subject: [dts] [PATCH V1] fix userspace failed case >=20 > From: "xu,huilong" >=20 > update list: > 1. update userspace example path for setup app > 2. add sleep time for app update link status with fortville nic in port > config case > 3. dpdk userspace tools dump eeprom file size different kernel ethtools > dump, so only compare same size bytes > 4. use scapy tool send packet replace packet model, because app can't > received packet by use packet model >=20 > Signed-off-by: xu,huilong > --- > tests/TestSuite_userspace_ethtool.py | 16 ++++++++++++---- > 1 file changed, 12 insertions(+), 4 deletions(-) >=20 > diff --git a/tests/TestSuite_userspace_ethtool.py > b/tests/TestSuite_userspace_ethtool.py > index 937a9e5..1b234c1 100644 > --- a/tests/TestSuite_userspace_ethtool.py > +++ b/tests/TestSuite_userspace_ethtool.py > @@ -61,7 +61,7 @@ class TestUserspaceEthtool(TestCase, > IxiaPacketGenerator): > self.verify("Error" not in out, "compilation error 1") > self.verify("No such file" not in out, "compilation error 2") >=20 > - path =3D "./examples/ethtool/ethtool-app/ethtool-app/%s/ethtool"= % > self.target > + path =3D "./examples/ethtool/ethtool-app/%s/ethtool" % self.targ= et > self.cmd =3D "%s -c f -n %d" % (path, > self.dut.get_memory_channels()) >=20 > # pause frame basic configuration > @@ -370,7 +370,10 @@ class TestUserspaceEthtool(TestCase, > IxiaPacketGenerator): > self.dut.send_expect("ethtool --eeprom-dump %s raw on > %s" = % > (intf, ethtool_eeprom), "# ") > # wait for file ready > time.sleep(2) > - portinfo['ethtool_eeprom'] =3D ethtool_eeprom > + # dpdk userspace dump eeprom-dump size different with kernel > ethtool dump eeprom-dump, so only compare same size bytes > + dpdk_eeprom_size =3D int(self.dut.send_expect('ls -all %s' % > portinfo['eeprom_file'], '# ').split(' ')[4].strip()) There is one more simple command to get file size. "stat -c %s" > + self.dut.send_expect('dd if=3D%s of=3D%s bs=3D%d count=3D1' = % > (ethtool_eeprom, "ethtool_eeprom_%d_cat.bin" % index, dpdk_eeprom_size), > "#") > + portinfo['ethtool_eeprom'] =3D "ethtool_eeprom_%d_cat.bin" % > index > # bind to original driver > portinfo['net_dev'].bind_driver(portinfo['ori_driver']) >=20 > @@ -394,10 +397,12 @@ class TestUserspaceEthtool(TestCase, > IxiaPacketGenerator): > rx_ring, _, tx_ring, _ =3D self.strip_ringparam(index) > self.verify(rx_ring =3D=3D rx_max, "Userspace tool failed to= set > Rx ring parameter") > self.verify(tx_ring =3D=3D tx_max, "Userspace tool failed to= set > Tx ring parameter") > - pkt =3D Packet() > tester_port =3D self.tester.get_local_port(port) > intf =3D self.tester.get_interface(tester_port) > - pkt.send_pkt(tx_port=3Dintf) > + # use scapy send packet, because example can't receive packe= t > by packet model > + packet =3D > r'sendp([Ether(dst=3D"ff:ff:ff:ff:ff:ff")/IP()/UDP()/Raw()], iface=3D"%s"= )' % > intf > + self.tester.scapy_append(packet) > + self.tester.scapy_execute() The only difference I can see is the destination mac address. Could you please try again with below code? pkt.config_layer('ether', {'dst': 'ff:ff:ff:ff:ff:ff'}) > rx_pkts, tx_pkts =3D self.strip_portstats(index) > self.verify(rx_pkts =3D=3D ori_rx_pkts + 1, "Failed to forwa= rd > after ring parameter changed") > self.dut.send_expect("quit", "# ") > @@ -499,8 +504,11 @@ class TestUserspaceEthtool(TestCase, > IxiaPacketGenerator): > for index in range(len(self.ports)): > port =3D self.ports[index] > ori_rx_pkts, _ =3D self.strip_portstats(index) > + # add sleep time for example update port link status > + time.sleep(10) > # stop port > self.dut.send_expect("stop %d" % index, "EthApp>") > + time.sleep(10) > # check packet not forwarded when port is stop > pkt =3D Packet() > tester_port =3D self.tester.get_local_port(port) > -- > 1.9.3