Re: [dts] [PATCH V1] tests/generic_filter: fix testpmd not support 128 queues

["Liu, Yong" <yong.liu@intel.com>]

Peipei, 
Some comments below.

Thanks,
Marvin

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of lu,peipei
> Sent: Monday, August 28, 2017 1:51 PM
> To: dts@dpdk.org
> Cc: Lu, PeipeiX <peipeix.lu@intel.com>
> Subject: [dts] [PATCH V1] tests/generic_filter: fix testpmd not support
> 128 queues
> 
> due to testpmd support 64 queues by default,so test the case need to
> modify ixgbe_ethdev.h.
> 
> Signed-off-by: lu,peipei <peipeix.lu@intel.com>
> ---
>  tests/TestSuite_generic_filter.py | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/TestSuite_generic_filter.py
> b/tests/TestSuite_generic_filter.py
> index c42ec5a..508b9cb 100644
> --- a/tests/TestSuite_generic_filter.py
> +++ b/tests/TestSuite_generic_filter.py
> @@ -690,8 +690,10 @@ class TestGeneric_filter(TestCase):
> 
>      def test_128_queues(self):
>          # testpmd can't support assign queue to received package, so
> can't test
> -        self.verify(False, "testpmd not support assign queue 127 received
> package")
> +        #self.verify(False, "testpmd not support assign queue 127
> received package")

Please just remove this line, there's no reference value in this comment.

>          if self.nic == "niantic":
> +	    self.dut.send_expect("sed -i -e 's/#define
> IXGBE_NONE_MODE_TX_NB_QUEUES 64$/#define IXGBE_NONE_MODE_TX_NB_QUEUES
> 128/' drivers/net/ixgbe/ixgbe_ethdev.h", "# ",30)

It's better to use self.kdriver for checking, because of some NICs like "sageville" still need to the same modification.

> +	    self.dut.build_install_dpdk(self.target)
>              global valports
>              total_mbufs = self.request_mbufs(128) * len(valports)
>              self.pmdout.start_testpmd(
> @@ -825,3 +827,4 @@ class TestGeneric_filter(TestCase):
>          Run after each test case.
>          """
>          self.dut.kill_all()
> +	self.dut.send_expect("sed -i -e 's/#define
> IXGBE_NONE_MODE_TX_NB_QUEUES 128$/#define IXGBE_NONE_MODE_TX_NB_QUEUES
> 64/' drivers/net/ixgbe/ixgbe_ethdev.h", "# ",30)

Please add dpdk build here after changed to default value.

> --
> 1.9.3