* [dts] [PATCH V1] tests/generic_filter: fix testpmd not support 128 queues
@ 2017-08-28 5:51 lu,peipei
2017-08-28 9:08 ` Liu, Yong
0 siblings, 1 reply; 7+ messages in thread
From: lu,peipei @ 2017-08-28 5:51 UTC (permalink / raw)
To: dts; +Cc: lu,peipei
due to testpmd support 64 queues by default,so test the case need to modify ixgbe_ethdev.h.
Signed-off-by: lu,peipei <peipeix.lu@intel.com>
---
tests/TestSuite_generic_filter.py | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/tests/TestSuite_generic_filter.py b/tests/TestSuite_generic_filter.py
index c42ec5a..508b9cb 100644
--- a/tests/TestSuite_generic_filter.py
+++ b/tests/TestSuite_generic_filter.py
@@ -690,8 +690,10 @@ class TestGeneric_filter(TestCase):
def test_128_queues(self):
# testpmd can't support assign queue to received package, so can't test
- self.verify(False, "testpmd not support assign queue 127 received package")
+ #self.verify(False, "testpmd not support assign queue 127 received package")
if self.nic == "niantic":
+ self.dut.send_expect("sed -i -e 's/#define IXGBE_NONE_MODE_TX_NB_QUEUES 64$/#define IXGBE_NONE_MODE_TX_NB_QUEUES 128/' drivers/net/ixgbe/ixgbe_ethdev.h", "# ",30)
+ self.dut.build_install_dpdk(self.target)
global valports
total_mbufs = self.request_mbufs(128) * len(valports)
self.pmdout.start_testpmd(
@@ -825,3 +827,4 @@ class TestGeneric_filter(TestCase):
Run after each test case.
"""
self.dut.kill_all()
+ self.dut.send_expect("sed -i -e 's/#define IXGBE_NONE_MODE_TX_NB_QUEUES 128$/#define IXGBE_NONE_MODE_TX_NB_QUEUES 64/' drivers/net/ixgbe/ixgbe_ethdev.h", "# ",30)
--
1.9.3
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [dts] [PATCH V1] tests/generic_filter: fix testpmd not support 128 queues
2017-08-28 5:51 [dts] [PATCH V1] tests/generic_filter: fix testpmd not support 128 queues lu,peipei
@ 2017-08-28 9:08 ` Liu, Yong
0 siblings, 0 replies; 7+ messages in thread
From: Liu, Yong @ 2017-08-28 9:08 UTC (permalink / raw)
To: Lu, PeipeiX, dts; +Cc: Lu, PeipeiX
Peipei,
Some comments below.
Thanks,
Marvin
> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of lu,peipei
> Sent: Monday, August 28, 2017 1:51 PM
> To: dts@dpdk.org
> Cc: Lu, PeipeiX <peipeix.lu@intel.com>
> Subject: [dts] [PATCH V1] tests/generic_filter: fix testpmd not support
> 128 queues
>
> due to testpmd support 64 queues by default,so test the case need to
> modify ixgbe_ethdev.h.
>
> Signed-off-by: lu,peipei <peipeix.lu@intel.com>
> ---
> tests/TestSuite_generic_filter.py | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/tests/TestSuite_generic_filter.py
> b/tests/TestSuite_generic_filter.py
> index c42ec5a..508b9cb 100644
> --- a/tests/TestSuite_generic_filter.py
> +++ b/tests/TestSuite_generic_filter.py
> @@ -690,8 +690,10 @@ class TestGeneric_filter(TestCase):
>
> def test_128_queues(self):
> # testpmd can't support assign queue to received package, so
> can't test
> - self.verify(False, "testpmd not support assign queue 127 received
> package")
> + #self.verify(False, "testpmd not support assign queue 127
> received package")
Please just remove this line, there's no reference value in this comment.
> if self.nic == "niantic":
> + self.dut.send_expect("sed -i -e 's/#define
> IXGBE_NONE_MODE_TX_NB_QUEUES 64$/#define IXGBE_NONE_MODE_TX_NB_QUEUES
> 128/' drivers/net/ixgbe/ixgbe_ethdev.h", "# ",30)
It's better to use self.kdriver for checking, because of some NICs like "sageville" still need to the same modification.
> + self.dut.build_install_dpdk(self.target)
> global valports
> total_mbufs = self.request_mbufs(128) * len(valports)
> self.pmdout.start_testpmd(
> @@ -825,3 +827,4 @@ class TestGeneric_filter(TestCase):
> Run after each test case.
> """
> self.dut.kill_all()
> + self.dut.send_expect("sed -i -e 's/#define
> IXGBE_NONE_MODE_TX_NB_QUEUES 128$/#define IXGBE_NONE_MODE_TX_NB_QUEUES
> 64/' drivers/net/ixgbe/ixgbe_ethdev.h", "# ",30)
Please add dpdk build here after changed to default value.
> --
> 1.9.3
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [dts] [PATCH V1] tests/generic_filter: fix testpmd not support 128 queues
2017-08-29 1:09 lu,peipei
@ 2017-08-29 17:35 ` Liu, Yong
0 siblings, 0 replies; 7+ messages in thread
From: Liu, Yong @ 2017-08-29 17:35 UTC (permalink / raw)
To: lu,peipei, dts
Applied, please take core your description. Root cause is that ixgbe
driver rather than testpmd can not support 128 queues.
On 08/29/2017 09:09 AM, lu,peipei wrote:
> due to testpmd support 64 queues by default,so test the case need to modify ixgbe_ethdev.h.
>
> Signed-off-by: lu,peipei<peipeix.lu@intel.com>
> ---
> tests/TestSuite_generic_filter.py | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
^ permalink raw reply [flat|nested] 7+ messages in thread
* [dts] [PATCH V1] tests/generic_filter: fix testpmd not support 128 queues
@ 2017-08-29 1:09 lu,peipei
2017-08-29 17:35 ` Liu, Yong
0 siblings, 1 reply; 7+ messages in thread
From: lu,peipei @ 2017-08-29 1:09 UTC (permalink / raw)
To: dts; +Cc: lu,peipei
due to testpmd support 64 queues by default,so test the case need to modify ixgbe_ethdev.h.
Signed-off-by: lu,peipei <peipeix.lu@intel.com>
---
tests/TestSuite_generic_filter.py | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/tests/TestSuite_generic_filter.py b/tests/TestSuite_generic_filter.py
index c42ec5a..42287aa 100644
--- a/tests/TestSuite_generic_filter.py
+++ b/tests/TestSuite_generic_filter.py
@@ -690,8 +690,9 @@ class TestGeneric_filter(TestCase):
def test_128_queues(self):
# testpmd can't support assign queue to received package, so can't test
- self.verify(False, "testpmd not support assign queue 127 received package")
- if self.nic == "niantic":
+ if self.kdriver == "ixgbe":
+ self.dut.send_expect("sed -i -e 's/#define IXGBE_NONE_MODE_TX_NB_QUEUES 64$/#define IXGBE_NONE_MODE_TX_NB_QUEUES 128/' drivers/net/ixgbe/ixgbe_ethdev.h", "# ",30)
+ self.dut.build_install_dpdk(self.target)
global valports
total_mbufs = self.request_mbufs(128) * len(valports)
self.pmdout.start_testpmd(
@@ -825,3 +826,5 @@ class TestGeneric_filter(TestCase):
Run after each test case.
"""
self.dut.kill_all()
+ self.dut.send_expect("sed -i -e 's/#define IXGBE_NONE_MODE_TX_NB_QUEUES 64$/#define IXGBE_NONE_MODE_TX_NB_QUEUES 128/' drivers/net/ixgbe/ixgbe_ethdev.h", "# ",30)
+ self.dut.build_install_dpdk(self.target)
--
1.9.3
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [dts] [PATCH V1] tests/generic_filter: fix testpmd not support 128 queues
2017-08-25 8:35 lu,peipei
2017-08-25 8:38 ` Xu, Qian Q
@ 2017-08-28 1:16 ` Liu, Yong
1 sibling, 0 replies; 7+ messages in thread
From: Liu, Yong @ 2017-08-28 1:16 UTC (permalink / raw)
To: Lu, PeipeiX, dts; +Cc: Lu, PeipeiX
Peipei,
Look like your patch only aimed for 8259x nics. If that please add judgement that check self.kdriver is ixgbe first and then do these changes.
It will waste some time if we are running test over other types of Nics.
Thanks,
Marvin
> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of lu,peipei
> Sent: Friday, August 25, 2017 4:36 PM
> To: dts@dpdk.org
> Cc: Lu, PeipeiX <peipeix.lu@intel.com>
> Subject: [dts] [PATCH V1] tests/generic_filter: fix testpmd not support
> 128 queues
>
> due to testpmd support 64 queues by default,so test the case need to
> modify ixgbe_ethdev.h.
>
> Signed-off-by: lu,peipei <peipeix.lu@intel.com>
> ---
> tests/TestSuite_generic_filter.py | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/tests/TestSuite_generic_filter.py
> b/tests/TestSuite_generic_filter.py
> index c42ec5a..a8eb2d9 100644
> --- a/tests/TestSuite_generic_filter.py
> +++ b/tests/TestSuite_generic_filter.py
> @@ -55,6 +55,8 @@ class TestGeneric_filter(TestCase):
>
> Generic filter Prerequistites
> """
> + self.dut.send_expect("sed -i -e 's/#define
> IXGBE_NONE_MODE_TX_NB_QUEUES 64$/#define IXGBE_NONE_MODE_TX_NB_QUEUES
> 128/' drivers/net/ixgbe/ixgbe_ethdev.h", "# ",30)
> + self.dut.build_install_dpdk(self.target)
>
> # Based on h/w type, choose how many ports to use
> ports = self.dut.get_ports(self.nic)
> @@ -690,7 +692,7 @@ class TestGeneric_filter(TestCase):
>
> def test_128_queues(self):
> # testpmd can't support assign queue to received package, so
> can't test
> - self.verify(False, "testpmd not support assign queue 127 received
> package")
> + #self.verify(False, "testpmd not support assign queue 127
> received package")
> if self.nic == "niantic":
> global valports
> total_mbufs = self.request_mbufs(128) * len(valports)
> @@ -825,3 +827,4 @@ class TestGeneric_filter(TestCase):
> Run after each test case.
> """
> self.dut.kill_all()
> + self.dut.send_expect("sed -i -e 's/#define
> IXGBE_NONE_MODE_TX_NB_QUEUES 128$/#define IXGBE_NONE_MODE_TX_NB_QUEUES
> 64/' drivers/net/ixgbe/ixgbe_ethdev.h", "# ",30)
> --
> 1.9.3
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [dts] [PATCH V1] tests/generic_filter: fix testpmd not support 128 queues
2017-08-25 8:35 lu,peipei
@ 2017-08-25 8:38 ` Xu, Qian Q
2017-08-28 1:16 ` Liu, Yong
1 sibling, 0 replies; 7+ messages in thread
From: Xu, Qian Q @ 2017-08-25 8:38 UTC (permalink / raw)
To: Lu, PeipeiX, dts; +Cc: Lu, PeipeiX
Thanks Peipei, do we need build again when we quit this case?
> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of lu,peipei
> Sent: Friday, August 25, 2017 4:36 PM
> To: dts@dpdk.org
> Cc: Lu, PeipeiX <peipeix.lu@intel.com>
> Subject: [dts] [PATCH V1] tests/generic_filter: fix testpmd not support 128
> queues
>
> due to testpmd support 64 queues by default,so test the case need to modify
> ixgbe_ethdev.h.
>
> Signed-off-by: lu,peipei <peipeix.lu@intel.com>
> ---
> tests/TestSuite_generic_filter.py | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/tests/TestSuite_generic_filter.py b/tests/TestSuite_generic_filter.py
> index c42ec5a..a8eb2d9 100644
> --- a/tests/TestSuite_generic_filter.py
> +++ b/tests/TestSuite_generic_filter.py
> @@ -55,6 +55,8 @@ class TestGeneric_filter(TestCase):
>
> Generic filter Prerequistites
> """
> + self.dut.send_expect("sed -i -e 's/#define
> IXGBE_NONE_MODE_TX_NB_QUEUES 64$/#define
> IXGBE_NONE_MODE_TX_NB_QUEUES 128/' drivers/net/ixgbe/ixgbe_ethdev.h",
> "# ",30)
> + self.dut.build_install_dpdk(self.target)
>
> # Based on h/w type, choose how many ports to use
> ports = self.dut.get_ports(self.nic) @@ -690,7 +692,7 @@ class
> TestGeneric_filter(TestCase):
>
> def test_128_queues(self):
> # testpmd can't support assign queue to received package, so can't test
> - self.verify(False, "testpmd not support assign queue 127 received package")
> + #self.verify(False, "testpmd not support assign queue 127
> + received package")
> if self.nic == "niantic":
> global valports
> total_mbufs = self.request_mbufs(128) * len(valports) @@ -825,3 +827,4
> @@ class TestGeneric_filter(TestCase):
> Run after each test case.
> """
> self.dut.kill_all()
> + self.dut.send_expect("sed -i -e 's/#define
> +IXGBE_NONE_MODE_TX_NB_QUEUES 128$/#define
> IXGBE_NONE_MODE_TX_NB_QUEUES
> +64/' drivers/net/ixgbe/ixgbe_ethdev.h", "# ",30)
> --
> 1.9.3
^ permalink raw reply [flat|nested] 7+ messages in thread
* [dts] [PATCH V1] tests/generic_filter: fix testpmd not support 128 queues
@ 2017-08-25 8:35 lu,peipei
2017-08-25 8:38 ` Xu, Qian Q
2017-08-28 1:16 ` Liu, Yong
0 siblings, 2 replies; 7+ messages in thread
From: lu,peipei @ 2017-08-25 8:35 UTC (permalink / raw)
To: dts; +Cc: lu,peipei
due to testpmd support 64 queues by default,so test the case need to modify ixgbe_ethdev.h.
Signed-off-by: lu,peipei <peipeix.lu@intel.com>
---
tests/TestSuite_generic_filter.py | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/tests/TestSuite_generic_filter.py b/tests/TestSuite_generic_filter.py
index c42ec5a..a8eb2d9 100644
--- a/tests/TestSuite_generic_filter.py
+++ b/tests/TestSuite_generic_filter.py
@@ -55,6 +55,8 @@ class TestGeneric_filter(TestCase):
Generic filter Prerequistites
"""
+ self.dut.send_expect("sed -i -e 's/#define IXGBE_NONE_MODE_TX_NB_QUEUES 64$/#define IXGBE_NONE_MODE_TX_NB_QUEUES 128/' drivers/net/ixgbe/ixgbe_ethdev.h", "# ",30)
+ self.dut.build_install_dpdk(self.target)
# Based on h/w type, choose how many ports to use
ports = self.dut.get_ports(self.nic)
@@ -690,7 +692,7 @@ class TestGeneric_filter(TestCase):
def test_128_queues(self):
# testpmd can't support assign queue to received package, so can't test
- self.verify(False, "testpmd not support assign queue 127 received package")
+ #self.verify(False, "testpmd not support assign queue 127 received package")
if self.nic == "niantic":
global valports
total_mbufs = self.request_mbufs(128) * len(valports)
@@ -825,3 +827,4 @@ class TestGeneric_filter(TestCase):
Run after each test case.
"""
self.dut.kill_all()
+ self.dut.send_expect("sed -i -e 's/#define IXGBE_NONE_MODE_TX_NB_QUEUES 128$/#define IXGBE_NONE_MODE_TX_NB_QUEUES 64/' drivers/net/ixgbe/ixgbe_ethdev.h", "# ",30)
--
1.9.3
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2017-08-29 8:52 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-08-28 5:51 [dts] [PATCH V1] tests/generic_filter: fix testpmd not support 128 queues lu,peipei
2017-08-28 9:08 ` Liu, Yong
-- strict thread matches above, loose matches on Subject: below --
2017-08-29 1:09 lu,peipei
2017-08-29 17:35 ` Liu, Yong
2017-08-25 8:35 lu,peipei
2017-08-25 8:38 ` Xu, Qian Q
2017-08-28 1:16 ` Liu, Yong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).