From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id EB8F21B53 for ; Mon, 28 Aug 2017 11:08:38 +0200 (CEST) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Aug 2017 02:08:37 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.41,441,1498546800"; d="scan'208";a="305105840" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga004.fm.intel.com with ESMTP; 28 Aug 2017 02:08:37 -0700 Received: from fmsmsx123.amr.corp.intel.com (10.18.125.38) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 28 Aug 2017 02:08:37 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by fmsmsx123.amr.corp.intel.com (10.18.125.38) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 28 Aug 2017 02:08:37 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.219]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.93]) with mapi id 14.03.0319.002; Mon, 28 Aug 2017 17:08:30 +0800 From: "Liu, Yong" To: "Lu, PeipeiX" , "dts@dpdk.org" CC: "Lu, PeipeiX" Thread-Topic: [dts] [PATCH V1] tests/generic_filter: fix testpmd not support 128 queues Thread-Index: AQHTH8GR8KSU22tYKkGy0b6SsH5cuKKZef1g Date: Mon, 28 Aug 2017 09:08:30 +0000 Message-ID: <86228AFD5BCD8E4EBFD2B90117B5E81E62E7816F@SHSMSX103.ccr.corp.intel.com> References: <1503899478-95662-1-git-send-email-peipeix.lu@intel.com> In-Reply-To: <1503899478-95662-1-git-send-email-peipeix.lu@intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dts] [PATCH V1] tests/generic_filter: fix testpmd not support 128 queues X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 28 Aug 2017 09:08:39 -0000 Peipei,=20 Some comments below. Thanks, Marvin > -----Original Message----- > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of lu,peipei > Sent: Monday, August 28, 2017 1:51 PM > To: dts@dpdk.org > Cc: Lu, PeipeiX > Subject: [dts] [PATCH V1] tests/generic_filter: fix testpmd not support > 128 queues >=20 > due to testpmd support 64 queues by default,so test the case need to > modify ixgbe_ethdev.h. >=20 > Signed-off-by: lu,peipei > --- > tests/TestSuite_generic_filter.py | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) >=20 > diff --git a/tests/TestSuite_generic_filter.py > b/tests/TestSuite_generic_filter.py > index c42ec5a..508b9cb 100644 > --- a/tests/TestSuite_generic_filter.py > +++ b/tests/TestSuite_generic_filter.py > @@ -690,8 +690,10 @@ class TestGeneric_filter(TestCase): >=20 > def test_128_queues(self): > # testpmd can't support assign queue to received package, so > can't test > - self.verify(False, "testpmd not support assign queue 127 receive= d > package") > + #self.verify(False, "testpmd not support assign queue 127 > received package") Please just remove this line, there's no reference value in this comment. > if self.nic =3D=3D "niantic": > + self.dut.send_expect("sed -i -e 's/#define > IXGBE_NONE_MODE_TX_NB_QUEUES 64$/#define IXGBE_NONE_MODE_TX_NB_QUEUES > 128/' drivers/net/ixgbe/ixgbe_ethdev.h", "# ",30) It's better to use self.kdriver for checking, because of some NICs like "sa= geville" still need to the same modification. > + self.dut.build_install_dpdk(self.target) > global valports > total_mbufs =3D self.request_mbufs(128) * len(valports) > self.pmdout.start_testpmd( > @@ -825,3 +827,4 @@ class TestGeneric_filter(TestCase): > Run after each test case. > """ > self.dut.kill_all() > + self.dut.send_expect("sed -i -e 's/#define > IXGBE_NONE_MODE_TX_NB_QUEUES 128$/#define IXGBE_NONE_MODE_TX_NB_QUEUES > 64/' drivers/net/ixgbe/ixgbe_ethdev.h", "# ",30) Please add dpdk build here after changed to default value. > -- > 1.9.3