test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Liu, Yong" <yong.liu@intel.com>
To: "Xu, GangX" <gangx.xu@intel.com>, "dts@dpdk.org" <dts@dpdk.org>
Cc: "Xu, GangX" <gangx.xu@intel.com>
Subject: Re: [dts] [PATCH V1] fix FreeBSD get mac addr error
Date: Wed, 30 Aug 2017 08:44:09 +0000	[thread overview]
Message-ID: <86228AFD5BCD8E4EBFD2B90117B5E81E62E9574E@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <1504073431-102098-1-git-send-email-gangx.xu@intel.com>

Gang,
Unload driver is very critical action, some cases will use this function to get mac address.
Thus will lead to all suites after these cases.

Please do this kind of action in upper layer which handler the overall execution.

Thanks,
Marvin


> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of xu,gang
> Sent: Wednesday, August 30, 2017 2:11 PM
> To: dts@dpdk.org
> Cc: Xu, GangX <gangx.xu@intel.com>
> Subject: [dts] [PATCH V1] fix FreeBSD get mac addr error
> 
> get mac addr need restore interface
> 
> Signed-off-by: xu,gang <gangx.xu@intel.com>
> ---
>  nics/net_device.py | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/nics/net_device.py b/nics/net_device.py
> index 4861145..9edf6f6 100644
> --- a/nics/net_device.py
> +++ b/nics/net_device.py
> @@ -330,6 +330,11 @@ class NetDevice(object):
>          """
>          Get the MAC by the default way on Freebsd.
>          """
> +        out = self.__send_expect('kldstat', '# ')
> +        if 'nic_uio.ko' in out:
> +            self.__send_expect('kldunload nic_uio.ko', '# ')
> +            self.__send_expect('kldunload contigmem.ko', '# ')
> +
>          out = self.__send_expect('ifconfig %s' % intf, '# ')
>          rexp = r"ether ([\da-f:]*)"
>          pattern = re.compile(rexp)
> --
> 1.9.3

      reply	other threads:[~2017-08-30  8:44 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-30  6:10 xu,gang
2017-08-30  8:44 ` Liu, Yong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86228AFD5BCD8E4EBFD2B90117B5E81E62E9574E@SHSMSX103.ccr.corp.intel.com \
    --to=yong.liu@intel.com \
    --cc=dts@dpdk.org \
    --cc=gangx.xu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).