* [dts] [PATCH V1] fix FreeBSD get mac addr error
@ 2017-08-30 6:10 xu,gang
2017-08-30 8:44 ` Liu, Yong
0 siblings, 1 reply; 2+ messages in thread
From: xu,gang @ 2017-08-30 6:10 UTC (permalink / raw)
To: dts; +Cc: xu,gang
get mac addr need restore interface
Signed-off-by: xu,gang <gangx.xu@intel.com>
---
nics/net_device.py | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/nics/net_device.py b/nics/net_device.py
index 4861145..9edf6f6 100644
--- a/nics/net_device.py
+++ b/nics/net_device.py
@@ -330,6 +330,11 @@ class NetDevice(object):
"""
Get the MAC by the default way on Freebsd.
"""
+ out = self.__send_expect('kldstat', '# ')
+ if 'nic_uio.ko' in out:
+ self.__send_expect('kldunload nic_uio.ko', '# ')
+ self.__send_expect('kldunload contigmem.ko', '# ')
+
out = self.__send_expect('ifconfig %s' % intf, '# ')
rexp = r"ether ([\da-f:]*)"
pattern = re.compile(rexp)
--
1.9.3
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dts] [PATCH V1] fix FreeBSD get mac addr error
2017-08-30 6:10 [dts] [PATCH V1] fix FreeBSD get mac addr error xu,gang
@ 2017-08-30 8:44 ` Liu, Yong
0 siblings, 0 replies; 2+ messages in thread
From: Liu, Yong @ 2017-08-30 8:44 UTC (permalink / raw)
To: Xu, GangX, dts; +Cc: Xu, GangX
Gang,
Unload driver is very critical action, some cases will use this function to get mac address.
Thus will lead to all suites after these cases.
Please do this kind of action in upper layer which handler the overall execution.
Thanks,
Marvin
> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of xu,gang
> Sent: Wednesday, August 30, 2017 2:11 PM
> To: dts@dpdk.org
> Cc: Xu, GangX <gangx.xu@intel.com>
> Subject: [dts] [PATCH V1] fix FreeBSD get mac addr error
>
> get mac addr need restore interface
>
> Signed-off-by: xu,gang <gangx.xu@intel.com>
> ---
> nics/net_device.py | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/nics/net_device.py b/nics/net_device.py
> index 4861145..9edf6f6 100644
> --- a/nics/net_device.py
> +++ b/nics/net_device.py
> @@ -330,6 +330,11 @@ class NetDevice(object):
> """
> Get the MAC by the default way on Freebsd.
> """
> + out = self.__send_expect('kldstat', '# ')
> + if 'nic_uio.ko' in out:
> + self.__send_expect('kldunload nic_uio.ko', '# ')
> + self.__send_expect('kldunload contigmem.ko', '# ')
> +
> out = self.__send_expect('ifconfig %s' % intf, '# ')
> rexp = r"ether ([\da-f:]*)"
> pattern = re.compile(rexp)
> --
> 1.9.3
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-08-30 8:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-08-30 6:10 [dts] [PATCH V1] fix FreeBSD get mac addr error xu,gang
2017-08-30 8:44 ` Liu, Yong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).