test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Liu, Yong" <yong.liu@intel.com>
To: "Lu, PeipeiX" <peipeix.lu@intel.com>, "dts@dpdk.org" <dts@dpdk.org>
Cc: "Lu, PeipeiX" <peipeix.lu@intel.com>
Subject: Re: [dts] [PATCH V1] tests/unit_tests_lpm: fix lpm set hugepage failed
Date: Fri, 1 Sep 2017 01:47:06 +0000	[thread overview]
Message-ID: <86228AFD5BCD8E4EBFD2B90117B5E81E62E97E9B@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <1504172843-105900-1-git-send-email-peipeix.lu@intel.com>

Peipei,
We can assume that every host have the same setting as yours. 
There're two options here, one is like original version, just allocate enough hugepage for this case.
The second option is that check the number of hugepages, raise one error if not enough. 


Thanks,
Marvin

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of lu,peipei
> Sent: Thursday, August 31, 2017 5:47 PM
> To: dts@dpdk.org
> Cc: Lu, PeipeiX <peipeix.lu@intel.com>
> Subject: [dts] [PATCH V1] tests/unit_tests_lpm: fix lpm set hugepage
> failed
> 
> Now all servers hugepage size were set 1G by default,the source codes were
> not must.
> 
> Signed-off-by: lu,peipei <peipeix.lu@intel.com>
> ---
>  tests/TestSuite_unit_tests_lpm.py | 12 ------------
>  1 file changed, 12 deletions(-)
> 
> diff --git a/tests/TestSuite_unit_tests_lpm.py
> b/tests/TestSuite_unit_tests_lpm.py
> index e8149ff..792be40 100644
> --- a/tests/TestSuite_unit_tests_lpm.py
> +++ b/tests/TestSuite_unit_tests_lpm.py
> @@ -81,21 +81,9 @@ class TestUnitTestsLpmIpv6(TestCase):
>          """
>          [arch, machine, env, toolchain] = self.target.split('-')
>          self.verify(arch in ["x86_64", "arm64"], "lpm6 request huge
> memory")
> -        if env == 'bsdapp':
> -            pass
> -        else:
> -            hugepage_ori = self.dut.get_total_huge_pages()
> -            self.dut.set_huge_pages(4096)
> -            hugepage_num = self.dut.get_total_huge_pages()
> -            self.verify(hugepage_num >= 4096, "failed to request huge
> memory")
> -
>          self.dut.send_expect("./%s/app/test -n 1 -c f" % self.target,
> "R.*T.*E.*>.*>", 60)
>          out = self.dut.send_expect("lpm6_autotest", "RTE>>", 3600)
>          self.dut.send_expect("quit", "# ")
> -        if env == 'bsdapp':
> -            pass
> -        else:
> -            self.dut.set_huge_pages(hugepage_ori)
>          self.verify("Test OK" in out, "Test failed")
> 
>      def tear_down(self):
> --
> 1.9.3

      reply	other threads:[~2017-09-01  1:47 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-31  9:47 lu,peipei
2017-09-01  1:47 ` Liu, Yong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86228AFD5BCD8E4EBFD2B90117B5E81E62E97E9B@SHSMSX103.ccr.corp.intel.com \
    --to=yong.liu@intel.com \
    --cc=dts@dpdk.org \
    --cc=peipeix.lu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).