test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Liu, Yong" <yong.liu@intel.com>
To: "Lu, PeipeiX" <peipeix.lu@intel.com>, "dts@dpdk.org" <dts@dpdk.org>
Cc: "Lu, PeipeiX" <peipeix.lu@intel.com>
Subject: Re: [dts] [PATCH V1] tests/unit_tests_lpm: fix set hugepage failed
Date: Wed, 6 Sep 2017 03:15:26 +0000	[thread overview]
Message-ID: <86228AFD5BCD8E4EBFD2B90117B5E81E62E9BACA@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <A95ECF8D0A9726439A39A44EF4CA97F2022F2E4D@shsmsx102.ccr.corp.intel.com>

Peipei,
As we discussed before, please just check whether host hugepage fulfill the requirement.
If host setup can't run this case, just raise one warning and skip it.

Thanks,
Marvin

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Lu, PeipeiX
> Sent: Tuesday, September 05, 2017 10:42 AM
> To: dts@dpdk.org
> Cc: Lu, PeipeiX <peipeix.lu@intel.com>
> Subject: Re: [dts] [PATCH V1] tests/unit_tests_lpm: fix set hugepage
> failed
> 
> Hi yong ,
> 
> Have you reviewed this patch, any comments? Thanks
> 
> Peipei
> 
> -----Original Message-----
> From: Lu, PeipeiX
> Sent: Friday, September 01, 2017 1:42 PM
> To: dts@dpdk.org
> Cc: Lu, PeipeiX
> Subject: [dts][PATCH V1] tests/unit_tests_lpm: fix set hugepage failed
> 
> jubge hugepage size and the number of hugepages,if allocate enough
> hugepage was pass, Otherwise need to adjust.
> 
> Signed-off-by: lu,peipei <peipeix.lu@intel.com>
> ---
>  tests/TestSuite_unit_tests_lpm.py | 13 ++++++++-----
>  1 file changed, 8 insertions(+), 5 deletions(-)
> 
> diff --git a/tests/TestSuite_unit_tests_lpm.py
> b/tests/TestSuite_unit_tests_lpm.py
> index e8149ff..53e65d9 100644
> --- a/tests/TestSuite_unit_tests_lpm.py
> +++ b/tests/TestSuite_unit_tests_lpm.py
> @@ -81,14 +81,17 @@ class TestUnitTestsLpmIpv6(TestCase):
>          """
>          [arch, machine, env, toolchain] = self.target.split('-')
>          self.verify(arch in ["x86_64", "arm64"], "lpm6 request huge
> memory")
> +	hugepages_size = int(self.dut.send_expect("awk '/Hugepagesize/
> {print $2}' /proc/meminfo", "# "))
> +	hugepage_ori = self.dut.get_total_huge_pages()
>          if env == 'bsdapp':
>              pass
>          else:
> -            hugepage_ori = self.dut.get_total_huge_pages()
> -            self.dut.set_huge_pages(4096)
> -            hugepage_num = self.dut.get_total_huge_pages()
> -            self.verify(hugepage_num >= 4096, "failed to request huge
> memory")
> -
> +	   1G_hugepage = 1024 * 1024
> +           8G_hugepage = 8 * 1G_hugepage
> +	   if (hugepages_size * hugepage_ori) < 8G_hugepage and
> hugepage_size != 1G_hugepage:
> +	      self.dut.set_huge_pages(8G_hugepage / hugepages_size)
> +	   else:
> +	      pass
>          self.dut.send_expect("./%s/app/test -n 1 -c f" % self.target,
> "R.*T.*E.*>.*>", 60)
>          out = self.dut.send_expect("lpm6_autotest", "RTE>>", 3600)
>          self.dut.send_expect("quit", "# ")
> --
> 1.9.3

      reply	other threads:[~2017-09-06  3:15 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-01  5:42 lu,peipei
2017-09-05  2:41 ` Lu, PeipeiX
2017-09-06  3:15   ` Liu, Yong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86228AFD5BCD8E4EBFD2B90117B5E81E62E9BACA@SHSMSX103.ccr.corp.intel.com \
    --to=yong.liu@intel.com \
    --cc=dts@dpdk.org \
    --cc=peipeix.lu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).