test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Liu, Yong" <yong.liu@intel.com>
To: "Lu, PeipeiX" <peipeix.lu@intel.com>, "dts@dpdk.org" <dts@dpdk.org>
Cc: "Lu, PeipeiX" <peipeix.lu@intel.com>
Subject: Re: [dts] [PATCH V1] framework/tester: fix not get all the content of a datagram
Date: Wed, 6 Sep 2017 03:28:53 +0000	[thread overview]
Message-ID: <86228AFD5BCD8E4EBFD2B90117B5E81E62E9BAFF@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <A95ECF8D0A9726439A39A44EF4CA97F2022F2E3B@shsmsx102.ccr.corp.intel.com>

Peipei,
Please give the sample which current parsing method can't work for it.
Several test cases are still using scapy_get_result to strip the result.
It is need to make sure that this patch won't affect all those test cases.

Thanks,
Marvin

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Lu, PeipeiX
> Sent: Tuesday, September 05, 2017 10:38 AM
> To: dts@dpdk.org
> Cc: Lu, PeipeiX <peipeix.lu@intel.com>
> Subject: Re: [dts] [PATCH V1] framework/tester: fix not get all the
> content of a datagram
> 
> Hi yong
>   Pls  merge the patch to dts. Thanks
> 
> peipei
> 
> -----Original Message-----
> From: Lu, PeipeiX
> Sent: Thursday, August 31, 2017 4:08 PM
> To: dts@dpdk.org
> Cc: Lu, PeipeiX
> Subject: [dts][PATCH V1] framework/tester: fix not get all the content of
> a datagram
> 
> Some time get result need to get all the content of a datagram, the
> original code only get part of the content.
> 
> Signed-off-by: lu,peipei <peipeix.lu@intel.com>
> ---
>  framework/tester.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/framework/tester.py b/framework/tester.py index
> e7fb6bc..1611ade 100644
> --- a/framework/tester.py
> +++ b/framework/tester.py
> @@ -489,7 +489,7 @@ class Tester(Crb):
>          out = self.send_expect("cat scapyResult.txt", "# ")
>          self.logger.info('SCAPY Result:\n' + out + '\n\n\n')
> 
> -        return out.rpartition('[')[0]
> +        return out.rpartition('>>>')[0]
> 
>      def traffic_generator_throughput(self, portList, rate_percent=100,
> delay=5):
>          """
> --
> 1.9.3

      reply	other threads:[~2017-09-06  3:28 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-31  8:08 lu,peipei
2017-09-05  2:37 ` Lu, PeipeiX
2017-09-06  3:28   ` Liu, Yong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86228AFD5BCD8E4EBFD2B90117B5E81E62E9BAFF@SHSMSX103.ccr.corp.intel.com \
    --to=yong.liu@intel.com \
    --cc=dts@dpdk.org \
    --cc=peipeix.lu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).