test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts] [PATCH V1] framework/tester: fix not get all the content of a datagram
@ 2017-08-31  8:08 lu,peipei
  2017-09-05  2:37 ` Lu, PeipeiX
  0 siblings, 1 reply; 3+ messages in thread
From: lu,peipei @ 2017-08-31  8:08 UTC (permalink / raw)
  To: dts; +Cc: lu,peipei

Some time get result need to get all the content of a datagram, 
the original code only get part of the content.

Signed-off-by: lu,peipei <peipeix.lu@intel.com>
---
 framework/tester.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/framework/tester.py b/framework/tester.py
index e7fb6bc..1611ade 100644
--- a/framework/tester.py
+++ b/framework/tester.py
@@ -489,7 +489,7 @@ class Tester(Crb):
         out = self.send_expect("cat scapyResult.txt", "# ")
         self.logger.info('SCAPY Result:\n' + out + '\n\n\n')
 
-        return out.rpartition('[')[0]
+        return out.rpartition('>>>')[0]
 
     def traffic_generator_throughput(self, portList, rate_percent=100, delay=5):
         """
-- 
1.9.3

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dts] [PATCH V1] framework/tester: fix not get all the content of a datagram
  2017-08-31  8:08 [dts] [PATCH V1] framework/tester: fix not get all the content of a datagram lu,peipei
@ 2017-09-05  2:37 ` Lu, PeipeiX
  2017-09-06  3:28   ` Liu, Yong
  0 siblings, 1 reply; 3+ messages in thread
From: Lu, PeipeiX @ 2017-09-05  2:37 UTC (permalink / raw)
  To: dts; +Cc: Lu, PeipeiX

Hi yong
  Pls  merge the patch to dts. Thanks

peipei

-----Original Message-----
From: Lu, PeipeiX 
Sent: Thursday, August 31, 2017 4:08 PM
To: dts@dpdk.org
Cc: Lu, PeipeiX
Subject: [dts][PATCH V1] framework/tester: fix not get all the content of a datagram

Some time get result need to get all the content of a datagram, the original code only get part of the content.

Signed-off-by: lu,peipei <peipeix.lu@intel.com>
---
 framework/tester.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/framework/tester.py b/framework/tester.py index e7fb6bc..1611ade 100644
--- a/framework/tester.py
+++ b/framework/tester.py
@@ -489,7 +489,7 @@ class Tester(Crb):
         out = self.send_expect("cat scapyResult.txt", "# ")
         self.logger.info('SCAPY Result:\n' + out + '\n\n\n')
 
-        return out.rpartition('[')[0]
+        return out.rpartition('>>>')[0]
 
     def traffic_generator_throughput(self, portList, rate_percent=100, delay=5):
         """
--
1.9.3

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dts] [PATCH V1] framework/tester: fix not get all the content of a datagram
  2017-09-05  2:37 ` Lu, PeipeiX
@ 2017-09-06  3:28   ` Liu, Yong
  0 siblings, 0 replies; 3+ messages in thread
From: Liu, Yong @ 2017-09-06  3:28 UTC (permalink / raw)
  To: Lu, PeipeiX, dts; +Cc: Lu, PeipeiX

Peipei,
Please give the sample which current parsing method can't work for it.
Several test cases are still using scapy_get_result to strip the result.
It is need to make sure that this patch won't affect all those test cases.

Thanks,
Marvin

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Lu, PeipeiX
> Sent: Tuesday, September 05, 2017 10:38 AM
> To: dts@dpdk.org
> Cc: Lu, PeipeiX <peipeix.lu@intel.com>
> Subject: Re: [dts] [PATCH V1] framework/tester: fix not get all the
> content of a datagram
> 
> Hi yong
>   Pls  merge the patch to dts. Thanks
> 
> peipei
> 
> -----Original Message-----
> From: Lu, PeipeiX
> Sent: Thursday, August 31, 2017 4:08 PM
> To: dts@dpdk.org
> Cc: Lu, PeipeiX
> Subject: [dts][PATCH V1] framework/tester: fix not get all the content of
> a datagram
> 
> Some time get result need to get all the content of a datagram, the
> original code only get part of the content.
> 
> Signed-off-by: lu,peipei <peipeix.lu@intel.com>
> ---
>  framework/tester.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/framework/tester.py b/framework/tester.py index
> e7fb6bc..1611ade 100644
> --- a/framework/tester.py
> +++ b/framework/tester.py
> @@ -489,7 +489,7 @@ class Tester(Crb):
>          out = self.send_expect("cat scapyResult.txt", "# ")
>          self.logger.info('SCAPY Result:\n' + out + '\n\n\n')
> 
> -        return out.rpartition('[')[0]
> +        return out.rpartition('>>>')[0]
> 
>      def traffic_generator_throughput(self, portList, rate_percent=100,
> delay=5):
>          """
> --
> 1.9.3

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2017-09-06  3:28 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-08-31  8:08 [dts] [PATCH V1] framework/tester: fix not get all the content of a datagram lu,peipei
2017-09-05  2:37 ` Lu, PeipeiX
2017-09-06  3:28   ` Liu, Yong

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).