Re: [dts] [PATCH V1] tests/unit_tests_lpm: Add the size of the judgment hugepage

["Liu, Yong" <yong.liu@intel.com>]

Jianbo,
Look like this patch only impacted lpm6_autotest. 
I remembered that lpm_perf_autotest required for huge memories for millions of entries.
Just checked with latest version, there's no such requirement now. Will remove the limitation in unit_test_lpm suite.
Thanks for reminder.

Thanks,
Marvin 

> -----Original Message-----
> From: Jianbo Liu [mailto:jianbo.liu@linaro.org]
> Sent: Tuesday, October 17, 2017 2:27 PM
> To: Liu, Yong <yong.liu@intel.com>
> Cc: Lu, PeipeiX <peipeix.lu@intel.com>; dts@dpdk.org
> Subject: Re: [dts] [PATCH V1] tests/unit_tests_lpm: Add the size of the
> judgment hugepage
> 
> Hi Yong,
> 
> Can you tell me what the failed cases are? I don't think it need 8G memory.
> 
> Thanks!
> Jianbo
> 
> On 16 October 2017 at 15:53, Liu, Yong <yong.liu@intel.com> wrote:
> > Jianbo,
> > Only lpm unit test required for so much memory. If there's not enough
> resource for some cases, this kind of cases should be taken as failed. The
> error reason has been included in the message, so user can choose either
> enlarge DUT resource and rerun or just ignore it
> >
> > Thanks,
> > Marvin
> >
> >> -----Original Message-----
> >> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Jianbo Liu
> >> Sent: Wednesday, October 11, 2017 3:23 PM
> >> To: Lu, PeipeiX <peipeix.lu@intel.com>
> >> Cc: dts@dpdk.org
> >> Subject: Re: [dts] [PATCH V1] tests/unit_tests_lpm: Add the size of the
> >> judgment hugepage
> >>
> >> Hi Peipei,
> >>
> >> Is there any requirement that the total hugepages should be larger than
> 8G?
> >> Besides, self.verify will exit this test, not raise one warning as you
> >> declared. Could it be wrong?
> >>
> >> Thanks!
> >> Jianbo
> >>
> >> On 6 September 2017 at 16:05, lu,peipei <peipeix.lu@intel.com> wrote:
> >> > Check whether host hugepage fulfill the requirement.If host setup
> can't
> >> run this case, just raise one warning
> >> >
> >> > Signed-off-by: lu,peipei <peipeix.lu@intel.com>
> >> > ---
> >> >  tests/TestSuite_unit_tests_lpm.py | 15 ++++++---------
> >> >  1 file changed, 6 insertions(+), 9 deletions(-)
> >> >
> >> > diff --git a/tests/TestSuite_unit_tests_lpm.py
> >> b/tests/TestSuite_unit_tests_lpm.py
> >> > index e8149ff..f9a2bf7 100644
> >> > --- a/tests/TestSuite_unit_tests_lpm.py
> >> > +++ b/tests/TestSuite_unit_tests_lpm.py
> >> > @@ -81,21 +81,18 @@ class TestUnitTestsLpmIpv6(TestCase):
> >> >          """
> >> >          [arch, machine, env, toolchain] = self.target.split('-')
> >> >          self.verify(arch in ["x86_64", "arm64"], "lpm6 request huge
> >> memory")
> >> > -        if env == 'bsdapp':
> >> > +        hugepages_size = int(self.dut.send_expect("awk
> '/Hugepagesize/
> >> {print $2}' /proc/meminfo", "# "))
> >> > +       hugepage_ori = self.dut.get_total_huge_pages()
> >> > +       if env == 'bsdapp':
> >> >              pass
> >> >          else:
> >> > -            hugepage_ori = self.dut.get_total_huge_pages()
> >> > -            self.dut.set_huge_pages(4096)
> >> > -            hugepage_num = self.dut.get_total_huge_pages()
> >> > -            self.verify(hugepage_num >= 4096, "failed to request
> huge
> >> memory")
> >> > +           hugepage_8G = 8 * 1024 * 1024
> >> > +            total_hugepage = hugepages_size * hugepage_ori
> >> > +            self.verify(total_hugepage >= hugepage_8G,"have no
> enough
> >> hugepage")
> >> >
> >> >          self.dut.send_expect("./%s/app/test -n 1 -c f" % self.target,
> >> "R.*T.*E.*>.*>", 60)
> >> >          out = self.dut.send_expect("lpm6_autotest", "RTE>>", 3600)
> >> >          self.dut.send_expect("quit", "# ")
> >> > -        if env == 'bsdapp':
> >> > -            pass
> >> > -        else:
> >> > -            self.dut.set_huge_pages(hugepage_ori)
> >> >          self.verify("Test OK" in out, "Test failed")
> >> >
> >> >      def tear_down(self):
> >> > --
> >> > 1.9.3
> >> >