Re: [dts] [PATCH V1] tests/vm_power: add sleep time

["Liu, Yong" <yong.liu@intel.com>]

Fangfang,
Please try your best to not use killall command. That's for two reasons. 
1: user may run other qemu process on the host. 
2: killall may not existed on every host.

For the sleep command, I think cpu frequency tuning should be rapidly. 
There may be one issue that if need to wait one second for frequency changed.

Thanks,
Marvin

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Fangfang Wei
> Sent: Wednesday, October 18, 2017 5:34 PM
> To: dts@dpdk.org
> Cc: Wei, FangfangX <fangfangx.wei@intel.com>
> Subject: [dts] [PATCH V1] tests/vm_power: add sleep time
> 
> From: Fangfangx Wei <fangfangx.wei@intel.com>
> 
> After running power command on vm, it should add sleeping timg to get cpu
> frequence on host.
> Add "killall qemu-system-x86_64" in teardown_all to clear vm environment.
> 
> Signed-off-by: Fangfangx Wei <fangfangx.wei@intel.com>
> ---
>  tests/TestSuite_vm_power_manager.py | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/tests/TestSuite_vm_power_manager.py
> b/tests/TestSuite_vm_power_manager.py
> index 5e273f4..c2b2759 100644
> --- a/tests/TestSuite_vm_power_manager.py
> +++ b/tests/TestSuite_vm_power_manager.py
> @@ -35,6 +35,7 @@ VM power manager test suite.
>  """
> 
>  import re
> +import time
>  import utils
>  from test_case import TestCase
>  from etgen import IxiaPacketGenerator
> @@ -141,6 +142,7 @@ class TestVmPowerManager(TestCase,
> IxiaPacketGenerator):
>              self.vm_dut.send_expect(
>                  "set_cpu_freq %d max" % vcpu, "vmpower\(guest\)>")
> 
> +        time.sleep(1)
>          for vcpu in range(self.core_num):
>              # map between host cpu and guest cpu
>              ori_freq = self.get_cpu_frequency(self.vcpu_map[vcpu])
> @@ -151,6 +153,7 @@ class TestVmPowerManager(TestCase,
> IxiaPacketGenerator):
>                  # connect vm power host and guest
>                  self.vm_dut.send_expect(
>                      "set_cpu_freq %d down" % vcpu, "vmpower\(guest\)>")
> +                time.sleep(1)
>                  cur_freq = self.get_cpu_frequency(self.vcpu_map[vcpu])
>                  print utils.GREEN("After freqency down, freq is %d\n" %
> cur_freq)
>                  self.verify(
> @@ -171,6 +174,7 @@ class TestVmPowerManager(TestCase,
> IxiaPacketGenerator):
>              self.vm_dut.send_expect(
>                  "set_cpu_freq %d min" % vcpu, "vmpower\(guest\)>")
> 
> +        time.sleep(1)
>          for vcpu in range(self.core_num):
>              ori_freq = self.get_cpu_frequency(self.vcpu_map[vcpu])
>              # get cpu frequencies range
> @@ -178,6 +182,7 @@ class TestVmPowerManager(TestCase,
> IxiaPacketGenerator):
>              for loop in range(len(freqs)-1):
>                  self.vm_dut.send_expect(
>                      "set_cpu_freq %d up" % vcpu, "vmpower\(guest\)>")
> +                time.sleep(1)
>                  cur_freq = self.get_cpu_frequency(self.vcpu_map[vcpu])
>                  print utils.GREEN("After freqency up, freq is %d\n" %
> cur_freq)
>                  self.verify(
> @@ -199,6 +204,7 @@ class TestVmPowerManager(TestCase,
> IxiaPacketGenerator):
>          for vcpu in range(self.core_num):
>              self.vm_dut.send_expect(
>                  "set_cpu_freq %d max" % vcpu, "vmpower\(guest\)>")
> +            time.sleep(1)
>              freq = self.get_cpu_frequency(self.vcpu_map[vcpu])
> 
>              out = self.dut.alt_session.send_expect(
> @@ -222,6 +228,7 @@ class TestVmPowerManager(TestCase,
> IxiaPacketGenerator):
>          for vcpu in range(self.core_num):
>              self.vm_dut.send_expect(
>                  "set_cpu_freq %d min" % vcpu, "vmpower\(guest\)>")
> +            time.sleep(1)
>              freq = self.get_cpu_frequency(self.vcpu_map[vcpu])
> 
>              out = self.dut.alt_session.send_expect(
> @@ -432,4 +439,5 @@ class TestVmPowerManager(TestCase,
> IxiaPacketGenerator):
>          self.dut.send_expect("quit", "# ")
>          self.vm.stop()
>          self.dut.virt_exit()
> +        self.dut.send_expect("killall qemu-system-x86_64", "# ")
>          pass
> --
> 2.7.5