From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 1B5E42B9F for ; Thu, 19 Oct 2017 04:24:35 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Oct 2017 19:24:34 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.43,399,1503385200"; d="scan'208";a="911355970" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by FMSMGA003.fm.intel.com with ESMTP; 18 Oct 2017 19:24:34 -0700 Received: from fmsmsx154.amr.corp.intel.com (10.18.116.70) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 18 Oct 2017 19:24:34 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by FMSMSX154.amr.corp.intel.com (10.18.116.70) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 18 Oct 2017 19:24:33 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.213]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.159]) with mapi id 14.03.0319.002; Thu, 19 Oct 2017 10:24:31 +0800 From: "Liu, Yong" To: "Wei, FangfangX" , "dts@dpdk.org" CC: "Wei, FangfangX" Thread-Topic: [dts] [PATCH V1] tests/vm_power: add sleep time Thread-Index: AQHTR/QUw1gmLT5FJU2n/+P6DP5lwqLqcXBg Date: Thu, 19 Oct 2017 02:24:31 +0000 Message-ID: <86228AFD5BCD8E4EBFD2B90117B5E81E62EF9BDD@SHSMSX103.ccr.corp.intel.com> References: <1508319235-13454-1-git-send-email-fangfangx.wei@intel.com> In-Reply-To: <1508319235-13454-1-git-send-email-fangfangx.wei@intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dts] [PATCH V1] tests/vm_power: add sleep time X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Oct 2017 02:24:36 -0000 Fangfang, Please try your best to not use killall command. That's for two reasons.=20 1: user may run other qemu process on the host.=20 2: killall may not existed on every host. For the sleep command, I think cpu frequency tuning should be rapidly.=20 There may be one issue that if need to wait one second for frequency change= d. Thanks, Marvin > -----Original Message----- > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Fangfang Wei > Sent: Wednesday, October 18, 2017 5:34 PM > To: dts@dpdk.org > Cc: Wei, FangfangX > Subject: [dts] [PATCH V1] tests/vm_power: add sleep time >=20 > From: Fangfangx Wei >=20 > After running power command on vm, it should add sleeping timg to get cpu > frequence on host. > Add "killall qemu-system-x86_64" in teardown_all to clear vm environment. >=20 > Signed-off-by: Fangfangx Wei > --- > tests/TestSuite_vm_power_manager.py | 8 ++++++++ > 1 file changed, 8 insertions(+) >=20 > diff --git a/tests/TestSuite_vm_power_manager.py > b/tests/TestSuite_vm_power_manager.py > index 5e273f4..c2b2759 100644 > --- a/tests/TestSuite_vm_power_manager.py > +++ b/tests/TestSuite_vm_power_manager.py > @@ -35,6 +35,7 @@ VM power manager test suite. > """ >=20 > import re > +import time > import utils > from test_case import TestCase > from etgen import IxiaPacketGenerator > @@ -141,6 +142,7 @@ class TestVmPowerManager(TestCase, > IxiaPacketGenerator): > self.vm_dut.send_expect( > "set_cpu_freq %d max" % vcpu, "vmpower\(guest\)>") >=20 > + time.sleep(1) > for vcpu in range(self.core_num): > # map between host cpu and guest cpu > ori_freq =3D self.get_cpu_frequency(self.vcpu_map[vcpu]) > @@ -151,6 +153,7 @@ class TestVmPowerManager(TestCase, > IxiaPacketGenerator): > # connect vm power host and guest > self.vm_dut.send_expect( > "set_cpu_freq %d down" % vcpu, "vmpower\(guest\)>") > + time.sleep(1) > cur_freq =3D self.get_cpu_frequency(self.vcpu_map[vcpu]) > print utils.GREEN("After freqency down, freq is %d\n" % > cur_freq) > self.verify( > @@ -171,6 +174,7 @@ class TestVmPowerManager(TestCase, > IxiaPacketGenerator): > self.vm_dut.send_expect( > "set_cpu_freq %d min" % vcpu, "vmpower\(guest\)>") >=20 > + time.sleep(1) > for vcpu in range(self.core_num): > ori_freq =3D self.get_cpu_frequency(self.vcpu_map[vcpu]) > # get cpu frequencies range > @@ -178,6 +182,7 @@ class TestVmPowerManager(TestCase, > IxiaPacketGenerator): > for loop in range(len(freqs)-1): > self.vm_dut.send_expect( > "set_cpu_freq %d up" % vcpu, "vmpower\(guest\)>") > + time.sleep(1) > cur_freq =3D self.get_cpu_frequency(self.vcpu_map[vcpu]) > print utils.GREEN("After freqency up, freq is %d\n" % > cur_freq) > self.verify( > @@ -199,6 +204,7 @@ class TestVmPowerManager(TestCase, > IxiaPacketGenerator): > for vcpu in range(self.core_num): > self.vm_dut.send_expect( > "set_cpu_freq %d max" % vcpu, "vmpower\(guest\)>") > + time.sleep(1) > freq =3D self.get_cpu_frequency(self.vcpu_map[vcpu]) >=20 > out =3D self.dut.alt_session.send_expect( > @@ -222,6 +228,7 @@ class TestVmPowerManager(TestCase, > IxiaPacketGenerator): > for vcpu in range(self.core_num): > self.vm_dut.send_expect( > "set_cpu_freq %d min" % vcpu, "vmpower\(guest\)>") > + time.sleep(1) > freq =3D self.get_cpu_frequency(self.vcpu_map[vcpu]) >=20 > out =3D self.dut.alt_session.send_expect( > @@ -432,4 +439,5 @@ class TestVmPowerManager(TestCase, > IxiaPacketGenerator): > self.dut.send_expect("quit", "# ") > self.vm.stop() > self.dut.virt_exit() > + self.dut.send_expect("killall qemu-system-x86_64", "# ") > pass > -- > 2.7.5