Re: [dts] [PATCH V2] Add a function used to verify keep packets' order feature

["Liu, Yong" <yong.liu@intel.com>]

Thanks Yuwei, some comments are inline.

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Yuwei Zhang
> Sent: Monday, November 13, 2017 11:08 PM
> To: dts@dpdk.org
> Cc: Zhang, Yuwei1 <yuwei1.zhang@intel.com>
> Subject: [dts] [PATCH V2] Add a function used to verify keep packets'
> order feature
> 
> Signed-off-by: Yuwei Zhang <yuwei1.zhang@intel.com>
> ---
>  framework/etgen.py  | 74 +++++++++++++++++++++++-------------------------
> -----
>  framework/tester.py |  7 +++++
>  2 files changed, 39 insertions(+), 42 deletions(-)
> 
> diff --git a/framework/etgen.py b/framework/etgen.py
> index b19ae84..373e420 100644
> --- a/framework/etgen.py
> +++ b/framework/etgen.py
> @@ -558,6 +558,38 @@ class IxiaPacketGenerator(SSHConnection):
>          rxPortlist, txPortlist = self._configure_everything(port_list,
> rate_percent)
>          return self.get_transmission_results(rxPortlist, txPortlist,
> delay)
> 
> +    def is_packet_ordered(self, port_list, delay):
Please add some descriptions for this function, not everyone familiar with the concept. 
Please also add the limitation description here like only one stream is supported. 

> +        rxPortlist, txPortlist = self.prepare_port_list(port_list)
> +        self.prepare_ixia_for_transmission(txPortlist, rxPortlist)
> +        self.send_expect('port config -receiveMode [expr
> $::portCapture|$::portRxFirstTimeStamp|$::portRxSequenceChecking|$::portRx
> ModeWidePacketGroup]', '%')

Please check whether portCapture and portRxFirstTimeStamp is needed in sequence check function.

> +        self.send_expect('port config -autonegotiate true', '%')
> +        self.send_expect('ixWritePortsToHardware portList', '%')
> +        self.send_expect('set streamId 1', '%')
> +        self.send_expect('stream setDefault', '%')
> +        self.send_expect('ixStartPortPacketGroups %d %d %d' %
> (self.chasId, self.ports[0]['card'], self.ports[0]['port']), '%')
> +        self.send_expect('ixStartTransmit portList', '%')
> +        self.send_expect('after 1000 * %d' % delay, '%')
> +        self.send_expect('ixStopTransmit portList', '%')
> +        self.send_expect('ixStopPortPacketGroups %d %d %d' % (self.chasId,
> self.ports[0]['card'], self.ports[0]['port']), '%')
> +        self.send_expect('after 1000 * %d' % delay, '%')
Look like add delay here is useless.

> +        self.send_expect('packetGroupStats get %d %d %d 1 1' %
> (self.chasId, self.ports[0]['card'], self.ports[0]['port']), '%')
> +        self.send_expect('packetroupStats getGroup 1', '%')
> +        self.send_expect('set reverseSequenceError [packetGroupStats cget
> -reverseSequenceError]]', '%')
> +        output = self.send_expect('puts $reverseSequenceError', '%')
> +        return int(output[:-2])
> +
>      def _configure_everything(self, port_list, rate_percent,
> latency=False):
>          """
>          Prepare and configure IXIA ports for performance test.
> 
> diff --git a/framework/tester.py b/framework/tester.py
> index 9208b0e..1c854d7 100644
> --- a/framework/tester.py
> +++ b/framework/tester.py
> @@ -502,6 +502,13 @@ class Tester(Crb):
>              return None
>          return self.packet_gen.throughput(portList, rate_percent)
> 
> +    def verify_packet_order(self, portList, delay):
> +        if self.check_port_list(portList, 'ixia'):
> +            return self.ixia_packet_gen.is_packet_ordered(portList, delay)
> +        else:
> +            self.logger.warning("Only ixia port support check verify
> packet order function")
> +            return False
> +
>      def run_rfc2544(self, portlist, delay=120, permit_loss_rate=0):
>          """
>          test_rate: the line rate we are going to test.
> --
> 2.14.1.windows.1