From: "Liu, Yong" <yong.liu@intel.com>
To: Phil Yang <Phil.Yang@arm.com>, "dts@dpdk.org" <dts@dpdk.org>
Cc: nd <nd@arm.com>
Subject: Re: [dts] [PATCH] tests/vhost_user_live_migration: Optimize for multi-platform.
Date: Tue, 9 Jan 2018 06:43:52 +0000 [thread overview]
Message-ID: <86228AFD5BCD8E4EBFD2B90117B5E81E62F42A55@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <AM4PR08MB091324767712ACEB76485F62E9100@AM4PR08MB0913.eurprd08.prod.outlook.com>
You're welcome, Phil.
> -----Original Message-----
> From: Phil Yang [mailto:Phil.Yang@arm.com]
> Sent: Tuesday, January 09, 2018 2:16 PM
> To: Liu, Yong <yong.liu@intel.com>; dts@dpdk.org
> Cc: nd <nd@arm.com>
> Subject: RE: [PATCH] tests/vhost_user_live_migration: Optimize for multi-
> platform.
>
> Hi Marvin
>
> Thanks for your comments. Updated.
>
> Thanks,
> Phil Yang
>
> > -----Original Message-----
> > From: Liu, Yong [mailto:yong.liu@intel.com]
> > Sent: Tuesday, January 9, 2018 9:10 PM
> > To: Phil Yang <Phil.Yang@arm.com>; dts@dpdk.org
> > Cc: nd <nd@arm.com>
> > Subject: Re: [PATCH] tests/vhost_user_live_migration: Optimize for
> multi-
> > platform.
> >
> > Phil,
> > There's one comment as below.
> >
> > On 01/05/2018 06:29 PM, Phil Yang wrote:
> > > +
> > > + dirct_pat = re.compile(r"(\s+)\[ (\S+) in\|out\|inout \]")
> > > + vm_dut.send_expect("tcpdump -h", "# ")
> > > + out = vm_dut.get_session_output(timeout=1)
> > > + m = dirct_pat.search(out)
> > > + if m:
> > > + dirct_para = "-" + m.group(2)[1] + " in"
> > > + else:
> > > + dirct_para = ""
> > > +
> >
> > Please change variable name to more meaning full name "direct_param".
> >
> > Thanks,
> > Marvin
prev parent reply other threads:[~2018-01-09 6:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-05 10:29 Phil Yang
2018-01-09 6:14 ` [dts] [PATCH v2] " Phil Yang
2018-01-09 14:32 ` Liu, Yong
2018-01-09 13:10 ` [dts] [PATCH] " Liu, Yong
2018-01-09 6:15 ` Phil Yang
2018-01-09 6:43 ` Liu, Yong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86228AFD5BCD8E4EBFD2B90117B5E81E62F42A55@SHSMSX103.ccr.corp.intel.com \
--to=yong.liu@intel.com \
--cc=Phil.Yang@arm.com \
--cc=dts@dpdk.org \
--cc=nd@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).