Re: [dts] [PATCH] framework: add virt_type option for virt type(kvm/libvirt) selection

["Liu, Yong" <yong.liu@intel.com>]

Hi Herbert,
I think argument "virt_type" is not needed for suite level configuration. There will be one possible scenario like libvirt and qemu VMs enabled in one suite. 
Please see my inline comment. 

Thanks,
Marvin

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Herbert Guan
> Sent: Tuesday, January 09, 2018 2:01 PM
> To: dts@dpdk.org
> Cc: Herbert Guan <herbert.guan@arm.com>
> Subject: [dts] [PATCH] framework: add virt_type option for virt
> type(kvm/libvirt) selection
> 
> Allow users to use test config file to specify virt type(kvm, libvirt, etc)
> by
> 'virt_type' option.  If not specified in config file, the default
> virt_type
> is kvm (qemu_kvm).
> 
> 
> Signed-off-by: Herbert Guan <herbert.guan@arm.com>
> ---
>  framework/virt_base.py | 16 ++++++++++++++--
>  1 file changed, 14 insertions(+), 2 deletions(-)
> 
> diff --git a/framework/virt_base.py b/framework/virt_base.py
> index 1838ca1..cd6dc0c 100644
> --- a/framework/virt_base.py
> +++ b/framework/virt_base.py
> @@ -98,13 +98,22 @@ class VirtBase(object):
>          """
>          Get the virtual type, such as KVM, XEN or LIBVIRT.
>          """
> -        NotImplemented
> +        conf = VirtConf(CONFIG_ROOT_PATH + os.sep + self.suite + '.cfg')
> +        conf.load_virt_config(self.vm_name)
> +        local_conf = conf.get_virt_config()
> +        for param in local_conf:
> +            if 'virt_type' in param.keys():
> +                return param['virt_type'][0]['virt_type']
> +        # if virt_type is not existing in config file, return 'KVM' by
> default
> +        return 'KVM'
> +

Virt_type has been specified when instantiating virtual machine object, so can initialize virt_type variable in init function of VM object.

> 
>      def has_virtual_ability(self):
>          """
>          Check if the host have the ability of virtualization.
>          """
> -        NotImplemented
> +        # Return True for non-derived virt_base object.
> +        return True
> 
>      def enable_virtual_ability(self):
>          """
> @@ -140,6 +149,9 @@ class VirtBase(object):
>              if 'cpu' in param.keys():
>                  self.__save_local_config('cpu', param['cpu'])
>                  continue
> +            if 'virt_type' in param.keys():
> +                # param 'virt_type' is for virt_base only
> +                continue
>              # save local configurations
>              for key in param.keys():
>                  self.__save_local_config(key, param[key])
> --
> 1.8.3.1