From: "Liu, Yong" <yong.liu@intel.com>
To: Ali Alnubani <alialnu@mellanox.com>,
"Tu, LijuanX A" <lijuanx.a.tu@intel.com>,
"dts@dpdk.org" <dts@dpdk.org>
Cc: Raslan Darawsheh <rasland@mellanox.com>,
Shahaf Shuler <shahafs@mellanox.com>,
Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [dts] [PATCH]Convert dts to new Tx offload API
Date: Sun, 21 Jan 2018 14:27:07 +0000 [thread overview]
Message-ID: <86228AFD5BCD8E4EBFD2B90117B5E81E62F5619D@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <DB6PR0501MB26301966F567DCB814E6AD22D7ED0@DB6PR0501MB2630.eurprd05.prod.outlook.com>
Thanks for your information, Ali. Lijuan's patch just converted txqflags into txoffloads flags.
It will be better that Tx offloads default flags is none and enabled specified feature for case requirement.
But it will need some time for testing.
Regards,
Marvin
> -----Original Message-----
> From: Ali Alnubani [mailto:alialnu@mellanox.com]
> Sent: Sunday, January 21, 2018 7:34 PM
> To: Liu, Yong <yong.liu@intel.com>; Tu, LijuanX A <lijuanx.a.tu@intel.com>;
> dts@dpdk.org
> Cc: Raslan Darawsheh <rasland@mellanox.com>; Shahaf Shuler
> <shahafs@mellanox.com>; Thomas Monjalon <thomas@monjalon.net>
> Subject: RE: [dts] [PATCH]Convert dts to new Tx offload API
>
> Hi,
>
> This patch is causing failure to run testpmd with MLX5, since it doesn't
> support all the requested offloads. And the patch doesn't consider this
> limitation in some PMDs.
> How do you suggest a fix or a workaround for this issue?
>
> Thanks,
> Ali Alnubani
>
>
> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Liu, Yong
> Sent: Tuesday, January 16, 2018 5:10 PM
> To: Lijuan Tu <lijuanx.a.tu@intel.com>; dts@dpdk.org
> Subject: Re: [dts] [PATCH]Convert dts to new Tx offload API
>
> Thanks, lijuan. Applied.
>
> On 01/16/2018 11:17 PM, Lijuan Tu wrote:
> > dpdk18.02 tx offloads API changed.
> > dpdk commit 28da7d752bf0("app/testpmd: remove txqflags option")
> >
> > As app/testpmd is now using the new Ethdev offloads API, and there is
> > necessary to change DTS to align to it.
> >
> > Signed-off-by: Lijuan Tu<lijuanx.a.tu@intel.com>
prev parent reply other threads:[~2018-01-21 14:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-16 15:17 Lijuan Tu
2018-01-16 15:10 ` Liu, Yong
2018-01-21 11:34 ` Ali Alnubani
2018-01-21 14:27 ` Liu, Yong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86228AFD5BCD8E4EBFD2B90117B5E81E62F5619D@SHSMSX103.ccr.corp.intel.com \
--to=yong.liu@intel.com \
--cc=alialnu@mellanox.com \
--cc=dts@dpdk.org \
--cc=lijuanx.a.tu@intel.com \
--cc=rasland@mellanox.com \
--cc=shahafs@mellanox.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).