Re: [dts] [patch v1] fix coremask issue

["Liu, Yong" <yong.liu@intel.com>]

Gang,
In this suite, I do not think CONFIG_RTE_LOG_DP_LEVEL is needed. 
Please check whether it still can work without datapath log level modification.

Thanks,
Marvin

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of xu,gang
> Sent: Wednesday, January 24, 2018 5:08 PM
> To: dts@dpdk.org
> Cc: Xu, GangX <gangx.xu@intel.com>
> Subject: [dts] [patch v1] fix coremask issue
> 
> remove CONFIG_RTE_LOG_LEVEL, use CONFIG_RTE_LOG_DP_LEVEL=RTE_LOG_DEBUG
> modify log-level="lib.eal,8" mean open eal library debug log.
> 
> Signed-off-by: xu,gang <gangx.xu@intel.com>
> ---
>  tests/TestSuite_coremask.py | 15 ++++++---------
>  1 file changed, 6 insertions(+), 9 deletions(-)
> 
> diff --git a/tests/TestSuite_coremask.py b/tests/TestSuite_coremask.py
> index a28266a..d3773cb 100644
> --- a/tests/TestSuite_coremask.py
> +++ b/tests/TestSuite_coremask.py
> @@ -17,7 +17,7 @@ from test_case import TestCase
>  # Test class.
>  #
> 
> -command_line = """./%s/app/test -c %s -n %d --log-level 8"""
> +command_line = """./%s/app/test -c %s -n %d --log-level="lib.eal,8" """
> 
> 
>  class TestCoremask(TestCase):
> @@ -39,8 +39,8 @@ class TestCoremask(TestCase):
>          self.mem_channel = self.dut.get_memory_channels()
> 
>          self.all_cores = self.dut.get_core_list("all")
> -        self.dut.send_expect("sed -i -e 's/CONFIG_RTE_LOG_LEVEL=.*$/"
> -                          + "CONFIG_RTE_LOG_LEVEL=RTE_LOG_DEBUG/'
> config/common_base", "# ", 30)
> +        self.dut.send_expect("sed -i -e 's/CONFIG_RTE_LOG_DP_LEVEL=.*$/"
> +                          + "CONFIG_RTE_LOG_DP_LEVEL=RTE_LOG_DEBUG/'
> config/common_base", "# ", 30)
> 
>          self.dut.skip_setup = False
>          self.dut.build_install_dpdk(self.target)
> @@ -64,7 +64,6 @@ class TestCoremask(TestCase):
>                                        self.mem_channel)
> 
>              out = self.dut.send_expect(command, "RTE>>", 10)
> -
>              self.verify("EAL: Detected lcore %s as core" % core in out,
>                          "Core %s not detected" % core)
> 
> @@ -83,7 +82,6 @@ class TestCoremask(TestCase):
>          command = command_line % (self.target, core_mask,
> self.mem_channel)
> 
>          out = self.dut.send_expect(command, "RTE>>", 10)
> -
>          self.verify("EAL: Master lcore 1 is ready" in out,
>                      "Core 1 not ready")
> 
> @@ -104,7 +102,7 @@ class TestCoremask(TestCase):
>          Check coremask parsing for more cores than available.
>          """
> 
> -        command_line = """./%s/app/test -c %s -n %d --log-level 8 2>&1
> |tee out"""
> +        command_line = """./%s/app/test -c %s -n %d --log-
> level="lib.eal,8" 2>&1 |tee out"""
> 
>          # Default big coremask value 128
>          big_coremask_size = 128
> @@ -131,7 +129,6 @@ class TestCoremask(TestCase):
>              self.dut.send_expect(command, "RTE>>", 10)
>          except:
>              out = self.dut.send_expect("cat out", "# ")
> -
>              self.verify("EAL: invalid coremask" in out,
>                      "Small core mask set")
> 
> @@ -178,8 +175,8 @@ class TestCoremask(TestCase):
>          """
>          Run after each test suite.
>          """
> -        self.dut.send_expect("sed -i -e 's/CONFIG_RTE_LOG_LEVEL=.*$/"
> -                          + "CONFIG_RTE_LOG_LEVEL=RTE_LOG_INFO/'
> config/common_base", "# ", 30)
> +        self.dut.send_expect("sed -i -e 's/CONFIG_RTE_LOG_DP_LEVEL=.*$/"
> +                          + "CONFIG_RTE_LOG_DP_LEVEL=RTE_LOG_INFO/'
> config/common_base", "# ", 30)
> 
>          #self.dut.skip_setup = False
>          self.dut.build_install_dpdk(self.target)
> --
> 1.9.3